From fc1ce4e8be0d977e3d41699f5ec746d68f63c024 Mon Sep 17 00:00:00 2001 From: Alex Light Date: Fri, 22 Jan 2021 14:05:13 +0000 Subject: Revert^2 "Partial Load Store Elimination" This reverts commit 47ac53100303e7e864b7f6d65f17b23088ccf1d6. There was a bug in LSE where we would incorrectly record the shadow$_monitor_ field as not having a default initial value. This caused partial LSE to be unable to compile the Object.identityHashCode function, causing crashes. This issue was fixed in a parent CL. Also updated all Offsets in LSE_test to be outside of the object header regardless of configuration. Test: ./test.py --host Bug: 67037140 Reason for revert: Fixed issue with shadow$_monitor_ field and offsets Change-Id: I4fb2afff4d410da818db38ed833927dfc0f6be33 --- compiler/optimizing/optimizing_compiler.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'compiler/optimizing/optimizing_compiler.cc') diff --git a/compiler/optimizing/optimizing_compiler.cc b/compiler/optimizing/optimizing_compiler.cc index ac241aa9c9..8cd34cf68f 100644 --- a/compiler/optimizing/optimizing_compiler.cc +++ b/compiler/optimizing/optimizing_compiler.cc @@ -194,7 +194,9 @@ class PassObserver : public ValueObject { GraphChecker checker(graph_, codegen_); last_seen_graph_size_ = checker.Run(pass_change, last_seen_graph_size_); if (!checker.IsValid()) { - LOG(FATAL) << "Error after " << pass_name << ": " << Dumpable(checker); + LOG(FATAL_WITHOUT_ABORT) << "Error after " << pass_name << "(" << graph_->PrettyMethod() + << "): " << *graph_; + LOG(FATAL) << "(" << pass_name << "): " << Dumpable(checker); } } } -- cgit v1.2.3-59-g8ed1b