From dbd05fe1a6ed2c3e23c9f6b372dd439ad59e777b Mon Sep 17 00:00:00 2001 From: Orion Hodson Date: Thu, 10 Aug 2017 11:41:35 +0100 Subject: Revert recent JIT code cache changes Flakiness observed on the bots. Revert "Jit Code Cache instruction pipeline flushing" This reverts commit 56fe32eecd4f25237e66811fd766355a07908d22. Revert "ARM64: More JIT Code Cache maintenace" This reverts commit 17272ab679c9b5f5dac8754ac070b78b15271c27. Revert "ARM64: JIT Code Cache maintenance" This reverts commit 3ecac070ad55d433bbcbe11e21f4b44ab178effe. Revert "Change flush order in JIT code cache" This reverts commit 43ce5f82dae4dc5eebcf40e54b81ccd96eb5fba3. Revert "Separate rw from rx views of jit code cache" This reverts commit d1dbb74e5946fe6c6098a541012932e1e9dd3115. Test: art/test.py --target --64 Bug: 64527643 Bug: 62356545 Change-Id: Ifa10ac77a60ee96e8cb68881bade4d6b4f828714 --- compiler/optimizing/optimizing_compiler.cc | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) (limited to 'compiler/optimizing/optimizing_compiler.cc') diff --git a/compiler/optimizing/optimizing_compiler.cc b/compiler/optimizing/optimizing_compiler.cc index 76a243f793..51101f104a 100644 --- a/compiler/optimizing/optimizing_compiler.cc +++ b/compiler/optimizing/optimizing_compiler.cc @@ -1210,14 +1210,14 @@ bool OptimizingCompiler::JitCompile(Thread* self, uint8_t* stack_map_data = nullptr; uint8_t* method_info_data = nullptr; uint8_t* roots_data = nullptr; - code_cache->ReserveData(self, - stack_map_size, - method_info_size, - number_of_roots, - method, - &stack_map_data, - &method_info_data, - &roots_data); + uint32_t data_size = code_cache->ReserveData(self, + stack_map_size, + method_info_size, + number_of_roots, + method, + &stack_map_data, + &method_info_data, + &roots_data); if (stack_map_data == nullptr || roots_data == nullptr) { return false; } @@ -1238,6 +1238,7 @@ bool OptimizingCompiler::JitCompile(Thread* self, codegen->GetFpuSpillMask(), code_allocator.GetMemory().data(), code_allocator.GetSize(), + data_size, osr, roots, codegen->GetGraph()->HasShouldDeoptimizeFlag(), -- cgit v1.2.3-59-g8ed1b