From 3a73ffb70151dbc99fa41f300a237f8c29783e0e Mon Sep 17 00:00:00 2001 From: Alex Light Date: Mon, 25 Jan 2021 14:11:05 +0000 Subject: Revert^4 "Partial Load Store Elimination" This reverts commit 791df7a161ecfa28eb69862a4bc285282463b960. This unreverts commit fc1ce4e8be0d977e3d41699f5ec746d68f63c024. This unreverts commit b8686ce4c93eba7192ed7ef89e7ffd9f3aa6cd07. We incorrectly failed to include PredicatedInstanceFieldGet in a few conditions, including a DCHECK. This caused tests to fail under the read-barrier-table-lookup configuration. Reason for revert: Fixed 2 incorrect checks Bug: 67037140 Test: ./art/test/testrunner/run_build_test_target.py -j70 art-gtest-read-barrier-table-lookup Change-Id: I32b01b29fb32077fb5074e7c77a0226bd1fcaab4 --- compiler/optimizing/optimizing_compiler.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'compiler/optimizing/optimizing_compiler.cc') diff --git a/compiler/optimizing/optimizing_compiler.cc b/compiler/optimizing/optimizing_compiler.cc index ac241aa9c9..8cd34cf68f 100644 --- a/compiler/optimizing/optimizing_compiler.cc +++ b/compiler/optimizing/optimizing_compiler.cc @@ -194,7 +194,9 @@ class PassObserver : public ValueObject { GraphChecker checker(graph_, codegen_); last_seen_graph_size_ = checker.Run(pass_change, last_seen_graph_size_); if (!checker.IsValid()) { - LOG(FATAL) << "Error after " << pass_name << ": " << Dumpable(checker); + LOG(FATAL_WITHOUT_ABORT) << "Error after " << pass_name << "(" << graph_->PrettyMethod() + << "): " << *graph_; + LOG(FATAL) << "(" << pass_name << "): " << Dumpable(checker); } } } -- cgit v1.2.3-59-g8ed1b