From f89381fed12faf96c45a83a989ae2fff82c05f3b Mon Sep 17 00:00:00 2001 From: Anton Shamin Date: Mon, 16 May 2016 16:44:13 +0600 Subject: ART: ArrayGet hoisting restriction added. Currently if we hoist ArrayGet from loop there is no guarantee that insn will be executed at runtime. Because of that we could face issues like crashes in generated code. This patch introduces restriction for ArrayGet hoisting. We say that ArrayGet execution is guaranteed at least one time if its bb dominates all exit blocks. Change-Id: I9f72c0f4c33b358341109238bea46cb5a82f490f Signed-off-by: Anton Shamin --- compiler/optimizing/nodes.h | 2 ++ 1 file changed, 2 insertions(+) (limited to 'compiler/optimizing/nodes.h') diff --git a/compiler/optimizing/nodes.h b/compiler/optimizing/nodes.h index c08323a0c6..38472cf8e8 100644 --- a/compiler/optimizing/nodes.h +++ b/compiler/optimizing/nodes.h @@ -733,6 +733,8 @@ class HLoopInformation : public ArenaObject { return blocks_.GetHighestBitSet() != -1; } + bool DominatesAllBackEdges(HBasicBlock* block); + private: // Internal recursive implementation of `Populate`. void PopulateRecursive(HBasicBlock* block); -- cgit v1.2.3-59-g8ed1b