From e6f49b47b6a4dc9c7684e4483757872cfc7ff1a1 Mon Sep 17 00:00:00 2001 From: Calin Juravle Date: Thu, 17 Sep 2015 14:04:33 +0000 Subject: Revert "Support unresolved fields in optimizing" breaks debuggable tests. This reverts commit 23a8e35481face09183a24b9d11e505597c75ebb. Change-Id: I8e60b5c8f48525975f25d19e5e8066c1c94bd2e5 --- compiler/optimizing/nodes.h | 122 -------------------------------------------- 1 file changed, 122 deletions(-) (limited to 'compiler/optimizing/nodes.h') diff --git a/compiler/optimizing/nodes.h b/compiler/optimizing/nodes.h index a44c9828d5..90ff20cf4c 100644 --- a/compiler/optimizing/nodes.h +++ b/compiler/optimizing/nodes.h @@ -1066,10 +1066,6 @@ class HLoopInformationOutwardIterator : public ValueObject { M(Shr, BinaryOperation) \ M(StaticFieldGet, Instruction) \ M(StaticFieldSet, Instruction) \ - M(UnresolvedInstanceFieldGet, Instruction) \ - M(UnresolvedInstanceFieldSet, Instruction) \ - M(UnresolvedStaticFieldGet, Instruction) \ - M(UnresolvedStaticFieldSet, Instruction) \ M(StoreLocal, Instruction) \ M(Sub, BinaryOperation) \ M(SuspendCheck, Instruction) \ @@ -4675,124 +4671,6 @@ class HStaticFieldSet : public HTemplateInstruction<2> { DISALLOW_COPY_AND_ASSIGN(HStaticFieldSet); }; -class HUnresolvedInstanceFieldGet : public HExpression<1> { - public: - HUnresolvedInstanceFieldGet(HInstruction* obj, - Primitive::Type field_type, - uint32_t field_index, - uint32_t dex_pc) - : HExpression(field_type, SideEffects::AllExceptGCDependency()), - field_index_(field_index), - dex_pc_(dex_pc) { - SetRawInputAt(0, obj); - } - - bool NeedsEnvironment() const OVERRIDE { return true; } - bool CanThrow() const OVERRIDE { return true; } - - Primitive::Type GetFieldType() const { return GetType(); } - uint32_t GetFieldIndex() const { return field_index_; } - uint32_t GetDexPc() const { return dex_pc_; } - - DECLARE_INSTRUCTION(UnresolvedInstanceFieldGet); - - private: - const uint32_t field_index_; - const uint32_t dex_pc_; - - DISALLOW_COPY_AND_ASSIGN(HUnresolvedInstanceFieldGet); -}; - -class HUnresolvedInstanceFieldSet : public HTemplateInstruction<2> { - public: - HUnresolvedInstanceFieldSet(HInstruction* obj, - HInstruction* value, - Primitive::Type field_type, - uint32_t field_index, - uint32_t dex_pc) - : HTemplateInstruction(SideEffects::AllExceptGCDependency()), - field_type_(field_type), - field_index_(field_index), - dex_pc_(dex_pc) { - DCHECK_EQ(field_type, value->GetType()); - SetRawInputAt(0, obj); - SetRawInputAt(1, value); - } - - bool NeedsEnvironment() const OVERRIDE { return true; } - bool CanThrow() const OVERRIDE { return true; } - - Primitive::Type GetFieldType() const { return field_type_; } - uint32_t GetFieldIndex() const { return field_index_; } - uint32_t GetDexPc() const { return dex_pc_; } - - DECLARE_INSTRUCTION(UnresolvedInstanceFieldSet); - - private: - const Primitive::Type field_type_; - const uint32_t field_index_; - const uint32_t dex_pc_; - - DISALLOW_COPY_AND_ASSIGN(HUnresolvedInstanceFieldSet); -}; - -class HUnresolvedStaticFieldGet : public HExpression<0> { - public: - HUnresolvedStaticFieldGet(Primitive::Type field_type, - uint32_t field_index, - uint32_t dex_pc) - : HExpression(field_type, SideEffects::AllExceptGCDependency()), - field_index_(field_index), - dex_pc_(dex_pc) { - } - - bool NeedsEnvironment() const OVERRIDE { return true; } - bool CanThrow() const OVERRIDE { return true; } - - Primitive::Type GetFieldType() const { return GetType(); } - uint32_t GetFieldIndex() const { return field_index_; } - uint32_t GetDexPc() const { return dex_pc_; } - - DECLARE_INSTRUCTION(UnresolvedStaticFieldGet); - - private: - const uint32_t field_index_; - const uint32_t dex_pc_; - - DISALLOW_COPY_AND_ASSIGN(HUnresolvedStaticFieldGet); -}; - -class HUnresolvedStaticFieldSet : public HTemplateInstruction<1> { - public: - HUnresolvedStaticFieldSet(HInstruction* value, - Primitive::Type field_type, - uint32_t field_index, - uint32_t dex_pc) - : HTemplateInstruction(SideEffects::AllExceptGCDependency()), - field_type_(field_type), - field_index_(field_index), - dex_pc_(dex_pc) { - DCHECK_EQ(field_type, value->GetType()); - SetRawInputAt(0, value); - } - - bool NeedsEnvironment() const OVERRIDE { return true; } - bool CanThrow() const OVERRIDE { return true; } - - Primitive::Type GetFieldType() const { return field_type_; } - uint32_t GetFieldIndex() const { return field_index_; } - uint32_t GetDexPc() const { return dex_pc_; } - - DECLARE_INSTRUCTION(UnresolvedStaticFieldSet); - - private: - const Primitive::Type field_type_; - const uint32_t field_index_; - const uint32_t dex_pc_; - - DISALLOW_COPY_AND_ASSIGN(HUnresolvedStaticFieldSet); -}; - // Implement the move-exception DEX instruction. class HLoadException : public HExpression<0> { public: -- cgit v1.2.3-59-g8ed1b