From 1693a1f9c83a0bf5a29fa18ddc2d87e04e049233 Mon Sep 17 00:00:00 2001 From: Roland Levillain Date: Tue, 15 Mar 2016 14:57:31 +0000 Subject: Make art::HCompare side effect free. All our back ends implement all comparisons without making a runtime call, so we can mark art::HCompare as a side effect free instruction unconditionally. Change-Id: I9a9e7c09156c642edb6af1fe84408f887e762f2e --- compiler/optimizing/nodes.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'compiler/optimizing/nodes.h') diff --git a/compiler/optimizing/nodes.h b/compiler/optimizing/nodes.h index 1bb5f5df51..4ac8f9869f 100644 --- a/compiler/optimizing/nodes.h +++ b/compiler/optimizing/nodes.h @@ -3485,9 +3485,9 @@ class HCompare : public HBinaryOperation { return GetBias() == ComparisonBias::kGtBias; } - static SideEffects SideEffectsForArchRuntimeCalls(Primitive::Type type) { - // MIPS64 uses a runtime call for FP comparisons. - return Primitive::IsFloatingPointType(type) ? SideEffects::CanTriggerGC() : SideEffects::None(); + static SideEffects SideEffectsForArchRuntimeCalls(Primitive::Type type ATTRIBUTE_UNUSED) { + // Comparisons do not require a runtime call in any back end. + return SideEffects::None(); } DECLARE_INSTRUCTION(Compare); -- cgit v1.2.3-59-g8ed1b