From cde6497d286337de2ed21c71c85157e2745b742b Mon Sep 17 00:00:00 2001 From: Vladimir Marko Date: Tue, 25 Apr 2023 16:40:06 +0000 Subject: Optimizing: Add `HInstruction::As##type()`. After the old implementation was renamed in https://android-review.googlesource.com/2526708 , we introduce a new function with the old name but new behavior, just `DCHECK()`-ing the instruction kind before casting down the pointer. We change appropriate calls from `As##type##OrNull()` to `As##type()` to avoid unncessary run-time checks and reduce the size of libart-compiler.so. Test: m test-art-host-gtest Test: testrunner.py --host --optimizing Test: run-gtests.sh Test: testrunner.py --target --optimizing Bug: 181943478 Change-Id: I025681612a77ca2157fed4886ca47f2053975d4e --- compiler/optimizing/loop_optimization_test.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'compiler/optimizing/loop_optimization_test.cc') diff --git a/compiler/optimizing/loop_optimization_test.cc b/compiler/optimizing/loop_optimization_test.cc index 36976519c0..7f694fb655 100644 --- a/compiler/optimizing/loop_optimization_test.cc +++ b/compiler/optimizing/loop_optimization_test.cc @@ -324,8 +324,7 @@ TEST_F(LoopOptimizationTest, SimplifyLoopSinglePreheader) { EXPECT_EQ(preheader1->GetSingleSuccessor(), new_preheader); EXPECT_EQ(new_preheader->GetPhis().CountSize(), 1u); - // TODO: Remove "OrNull". - HPhi* new_preheader_phi = new_preheader->GetFirstPhi()->AsPhiOrNull(); + HPhi* new_preheader_phi = new_preheader->GetFirstPhi()->AsPhi(); EXPECT_EQ(new_preheader_phi->InputCount(), 2u); EXPECT_EQ(new_preheader_phi->InputAt(0), preheader0_add); EXPECT_EQ(new_preheader_phi->InputAt(1), preheader1_add); -- cgit v1.2.3-59-g8ed1b