From 2c45bc9137c29f886e69923535aff31a74d90829 Mon Sep 17 00:00:00 2001 From: Vladimir Marko Date: Tue, 25 Oct 2016 16:54:12 +0100 Subject: Remove H[Reverse]PostOrderIterator and HInsertionOrderIterator. Use range-based loops instead, introducing helper functions ReverseRange() for iteration in reverse order in containers. When the contents of the underlying container change inside the loop, use an index-based loop that better exposes the container data modifications, compared to the old iterator interface that's hiding it which may lead to subtle bugs. Test: m test-art-host Change-Id: I2a4e6c508b854c37a697fc4b1e8423a8c92c5ea0 --- compiler/optimizing/linear_order.h | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'compiler/optimizing/linear_order.h') diff --git a/compiler/optimizing/linear_order.h b/compiler/optimizing/linear_order.h index cdbdd0714b..7122d67be9 100644 --- a/compiler/optimizing/linear_order.h +++ b/compiler/optimizing/linear_order.h @@ -30,16 +30,12 @@ namespace art { // // for (HBasicBlock* block : linear_order) // linear order // -// for (HBasicBlock* block : LinearPostOrder(linear_order)) // linear post order +// for (HBasicBlock* block : ReverseRange(linear_order)) // linear post order // void LinearizeGraph(const HGraph* graph, ArenaAllocator* allocator, ArenaVector* linear_order); -inline auto LinearPostOrder(const ArenaVector& linear_order) { - return MakeIterationRange(linear_order.rbegin(), linear_order.rend()); -} - } // namespace art #endif // ART_COMPILER_OPTIMIZING_LINEAR_ORDER_H_ -- cgit v1.2.3-59-g8ed1b