From 343b9d9e103e281a4c4c337edb83d23473e28bcc Mon Sep 17 00:00:00 2001 From: Santiago Aboy Solanes Date: Tue, 6 Dec 2022 18:13:10 +0000 Subject: Allow inlining invokes that contain try catches into catch blocks Since catch blocks are never considered try blocks, we can guarantee that its invokes are not inside a TryBoundary (which is the blocker for enabling inlining of try catch invokes inside try blocks). Bug: 227283224 Test: art/test/testrunner/testrunner.py --host --64 --optimizing -b Change-Id: I747e2e8c2515e36041ad3966ca6a6388ef7d91df --- compiler/optimizing/inliner.cc | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'compiler/optimizing/inliner.cc') diff --git a/compiler/optimizing/inliner.cc b/compiler/optimizing/inliner.cc index e8b9b583ba..3e3b2d46ca 100644 --- a/compiler/optimizing/inliner.cc +++ b/compiler/optimizing/inliner.cc @@ -1440,17 +1440,17 @@ bool HInliner::IsInliningSupported(const HInvoke* invoke_instruction, << " is not inlined because inlining try catches is disabled globally"; return false; } - const bool inlined_into_try_catch = - // Direct parent is a try catch. - invoke_instruction->GetBlock()->GetTryCatchInformation() != nullptr || - // Indirect parent is a try catch. + const bool disallowed_try_catch_inlining = + // Direct parent is a try block. + invoke_instruction->GetBlock()->IsTryBlock() || + // Indirect parent disallows try catch inlining. !try_catch_inlining_allowed_; - if (inlined_into_try_catch) { + if (disallowed_try_catch_inlining) { LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedTryCatchCallee) << "Method " << method->PrettyMethod() << " is not inlined because it has a try catch and we are not supporting it for this" << " particular call. This is could be because e.g. it would be inlined inside another" - << " try catch, we arrived here from TryInlinePolymorphicCall, etc."; + << " try block, we arrived here from TryInlinePolymorphicCall, etc."; return false; } } @@ -2139,8 +2139,8 @@ bool HInliner::TryBuildAndInlineHelper(HInvoke* invoke_instruction, const bool try_catch_inlining_allowed_for_recursive_inline = // It was allowed previously. try_catch_inlining_allowed_ && - // The current invoke is not in a try or a catch. - invoke_instruction->GetBlock()->GetTryCatchInformation() == nullptr; + // The current invoke is not a try block. + !invoke_instruction->GetBlock()->IsTryBlock(); RunOptimizations(callee_graph, code_item, dex_compilation_unit, -- cgit v1.2.3-59-g8ed1b