From 86c4b39d929c37b2899b41c030c9756ea336333f Mon Sep 17 00:00:00 2001 From: Stefano Cianciulli Date: Thu, 9 Jun 2022 14:46:08 +0000 Subject: Fix modernize-use-using clang-tidy issues All the // NOLINT comments introduced in this CL were meant to disable only the modernize-use-using checks, but changing the comment to be // NOLINT(modernize-use-using) as explained in https://clang.llvm.org/extra/clang-tidy/#suppressing-undesired-diagnostics will make cpplint throw an error, as also cpplint uses the // NOLINT(...) notation to suppress unwanted warnings. Test: m tidy-art Test: art/libnativebridge/tests/runtests.sh Bug: 213953102 Change-Id: I9a992e0f0ecd06f7e64fd0bbf473bec4582370f6 --- compiler/optimizing/codegen_test_utils.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'compiler/optimizing/codegen_test_utils.h') diff --git a/compiler/optimizing/codegen_test_utils.h b/compiler/optimizing/codegen_test_utils.h index 397e601cee..95cb548905 100644 --- a/compiler/optimizing/codegen_test_utils.h +++ b/compiler/optimizing/codegen_test_utils.h @@ -45,7 +45,7 @@ namespace art { -typedef CodeGenerator* (*CreateCodegenFn)(HGraph*, const CompilerOptions&); +using CreateCodegenFn = CodeGenerator* (*)(HGraph*, const CompilerOptions&); class CodegenTargetConfig { public: @@ -257,7 +257,7 @@ static void Run(const InternalCodeAllocator& allocator, const void* code_ptr = code_holder.MakeExecutable(allocator.GetMemory(), ArrayRef(), target_isa); - typedef Expected (*fptr)(); + using fptr = Expected (*)(); fptr f = reinterpret_cast(reinterpret_cast(code_ptr)); if (target_isa == InstructionSet::kThumb2) { // For thumb we need the bottom bit set. -- cgit v1.2.3-59-g8ed1b