From a4bb8c918283b24da3939faf44d13db3bab597d8 Mon Sep 17 00:00:00 2001 From: Santiago Aboy Solanes Date: Fri, 17 Jan 2025 15:28:44 +0000 Subject: Remove unused dex_pc from InvokeRuntime Bug: 392802982 Test: art/test/testrunner/testrunner.py --host --64 -b --optimizing Test: m test-art-host-gtest Change-Id: I6e40215a5b1b18223c5f17e9e0ac70e05515fa94 --- compiler/optimizing/code_generator.cc | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) (limited to 'compiler/optimizing/code_generator.cc') diff --git a/compiler/optimizing/code_generator.cc b/compiler/optimizing/code_generator.cc index fb4e7b647b..79386defae 100644 --- a/compiler/optimizing/code_generator.cc +++ b/compiler/optimizing/code_generator.cc @@ -541,7 +541,7 @@ void CodeGenerator::GenerateInvokeStaticOrDirectRuntimeCall( UNREACHABLE(); } - InvokeRuntime(entrypoint, invoke, invoke->GetDexPc(), slow_path); + InvokeRuntime(entrypoint, invoke, slow_path); } void CodeGenerator::GenerateInvokeUnresolvedRuntimeCall(HInvokeUnresolved* invoke) { MethodReference method_reference(invoke->GetMethodReference()); @@ -570,7 +570,7 @@ void CodeGenerator::GenerateInvokeUnresolvedRuntimeCall(HInvokeUnresolved* invok LOG(FATAL) << "Unexpected invoke type: " << invoke->GetInvokeType(); UNREACHABLE(); } - InvokeRuntime(entrypoint, invoke, invoke->GetDexPc(), nullptr); + InvokeRuntime(entrypoint, invoke); } void CodeGenerator::GenerateInvokePolymorphicCall(HInvokePolymorphic* invoke, @@ -579,13 +579,13 @@ void CodeGenerator::GenerateInvokePolymorphicCall(HInvokePolymorphic* invoke, // method index) since it requires multiple info from the instruction (registers A, B, H). Not // using the reservation has no effect on the registers used in the runtime call. QuickEntrypointEnum entrypoint = kQuickInvokePolymorphic; - InvokeRuntime(entrypoint, invoke, invoke->GetDexPc(), slow_path); + InvokeRuntime(entrypoint, invoke, slow_path); } void CodeGenerator::GenerateInvokeCustomCall(HInvokeCustom* invoke) { MoveConstant(invoke->GetLocations()->GetTemp(0), invoke->GetCallSiteIndex()); QuickEntrypointEnum entrypoint = kQuickInvokeCustom; - InvokeRuntime(entrypoint, invoke, invoke->GetDexPc(), nullptr); + InvokeRuntime(entrypoint, invoke); } void CodeGenerator::CreateStringBuilderAppendLocations(HStringBuilderAppend* instruction, @@ -690,7 +690,7 @@ void CodeGenerator::GenerateUnresolvedFieldAccess( HInstruction* field_access, DataType::Type field_type, uint32_t field_index, - uint32_t dex_pc, + [[maybe_unused]] uint32_t dex_pc, const FieldAccessCallingConvention& calling_convention) { LocationSummary* locations = field_access->GetLocations(); @@ -754,7 +754,7 @@ void CodeGenerator::GenerateUnresolvedFieldAccess( default: LOG(FATAL) << "Invalid type " << field_type; } - InvokeRuntime(entrypoint, field_access, dex_pc, nullptr); + InvokeRuntime(entrypoint, field_access); if (is_get && DataType::IsFloatingPointType(field_type)) { MoveLocation(locations->Out(), calling_convention.GetReturnLocation(field_type), field_type); @@ -780,10 +780,10 @@ void CodeGenerator::GenerateLoadClassRuntimeCall(HLoadClass* cls) { MoveConstant(locations->GetTemp(0), cls->GetTypeIndex().index_); if (cls->NeedsAccessCheck()) { CheckEntrypointTypes(); - InvokeRuntime(kQuickResolveTypeAndVerifyAccess, cls, cls->GetDexPc()); + InvokeRuntime(kQuickResolveTypeAndVerifyAccess, cls); } else { CheckEntrypointTypes(); - InvokeRuntime(kQuickResolveType, cls, cls->GetDexPc()); + InvokeRuntime(kQuickResolveType, cls); } } @@ -804,7 +804,7 @@ void CodeGenerator::GenerateLoadMethodHandleRuntimeCall(HLoadMethodHandle* metho LocationSummary* locations = method_handle->GetLocations(); MoveConstant(locations->GetTemp(0), method_handle->GetMethodHandleIndex()); CheckEntrypointTypes(); - InvokeRuntime(kQuickResolveMethodHandle, method_handle, method_handle->GetDexPc()); + InvokeRuntime(kQuickResolveMethodHandle, method_handle); } void CodeGenerator::CreateLoadMethodTypeRuntimeCallLocationSummary( @@ -824,7 +824,7 @@ void CodeGenerator::GenerateLoadMethodTypeRuntimeCall(HLoadMethodType* method_ty LocationSummary* locations = method_type->GetLocations(); MoveConstant(locations->GetTemp(0), method_type->GetProtoIndex().index_); CheckEntrypointTypes(); - InvokeRuntime(kQuickResolveMethodType, method_type, method_type->GetDexPc()); + InvokeRuntime(kQuickResolveMethodType, method_type); } static uint32_t GetBootImageOffsetImpl(const void* object, ImageHeader::ImageSections section) { -- cgit v1.2.3-59-g8ed1b