From 0f800d14c692234f9c8302c0d4c031caa2afa5ba Mon Sep 17 00:00:00 2001 From: Santiago Aboy Solanes Date: Tue, 21 Jan 2025 12:53:10 +0000 Subject: Remove old workaround in RecordPcInfo Bug: 392802982 Test: art/test/testrunner/testrunner.py --host --64 -b --optimizing Change-Id: I5fefd6939e1d8434f1d7ad913ced582fefed1b30 --- compiler/optimizing/code_generator.cc | 20 -------------------- 1 file changed, 20 deletions(-) (limited to 'compiler/optimizing/code_generator.cc') diff --git a/compiler/optimizing/code_generator.cc b/compiler/optimizing/code_generator.cc index c4866146b4..e84cfcbe80 100644 --- a/compiler/optimizing/code_generator.cc +++ b/compiler/optimizing/code_generator.cc @@ -1167,26 +1167,6 @@ void CodeGenerator::RecordPcInfo(HInstruction* instruction, // the regular case, we retrieve the dex_pc from the instruction's environment. DCHECK_IMPLIES(native_debug_info, GetCompilerOptions().GetNativeDebuggable()); DCHECK_IMPLIES(!native_debug_info, instruction->HasEnvironment()) << *instruction; - // The code generated for some type conversions - // may call the runtime, thus normally requiring a subsequent - // call to this method. However, the method verifier does not - // produce PC information for certain instructions, which are - // considered "atomic" (they cannot join a GC). - // Therefore we do not currently record PC information for such - // instructions. As this may change later, we added this special - // case so that code generators may nevertheless call - // CodeGenerator::RecordPcInfo without triggering an error in - // CodeGenerator::BuildNativeGCMap ("Missing ref for dex pc 0x") - // thereafter. - if (instruction->IsTypeConversion()) { - return; - } - if (instruction->IsRem()) { - DataType::Type type = instruction->AsRem()->GetResultType(); - if ((type == DataType::Type::kFloat32) || (type == DataType::Type::kFloat64)) { - return; - } - } LocationSummary* locations = instruction->GetLocations(); uint32_t register_mask = locations->GetRegisterMask(); -- cgit v1.2.3-59-g8ed1b