From d34b73b4ac478462acc03c4cd42ae7568c832eb8 Mon Sep 17 00:00:00 2001 From: Vladimir Marko Date: Tue, 5 May 2020 10:07:59 +0100 Subject: Clean up internal stack trace construction. Simplify the code by ignoring active transactions. Writing to fields of a newly allocated object does not need to be recorded as aborting the transaction removes all references to the new object and it's unnecessary to roll back writes to unreachable object's fields. Test: m test-art-host-gtest Test: testrunner.py --host --optimizing Test: aosp_taimen-userdebug boots. Change-Id: Ia91d3274398b0ca0f5b0040dcf323921d915b657 --- compiler/exception_test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'compiler/exception_test.cc') diff --git a/compiler/exception_test.cc b/compiler/exception_test.cc index 633e124d07..7d56da07fb 100644 --- a/compiler/exception_test.cc +++ b/compiler/exception_test.cc @@ -213,7 +213,7 @@ TEST_F(ExceptionTest, StackTraceElement) { // Set up thread to appear as if we called out of method_g_ at given pc dex. thread->SetTopOfStack(reinterpret_cast(&fake_stack[0])); - jobject internal = thread->CreateInternalStackTrace(soa); + jobject internal = thread->CreateInternalStackTrace(soa); ASSERT_TRUE(internal != nullptr); jobjectArray ste_array = Thread::InternalStackTraceToStackTraceElementArray(soa, internal); ASSERT_TRUE(ste_array != nullptr); -- cgit v1.2.3-59-g8ed1b