From 3e09eebe1ffd38b12d67c90cfe609d27453469ff Mon Sep 17 00:00:00 2001 From: David Srbecky Date: Tue, 12 Jan 2016 14:54:03 +0000 Subject: Disable --generate-debug-info by default in all cases. The option is disabled by default unless explicitly enabled. In particular, it is no longer enabled in debug builds, and the --debuggable option does not affect it. I want to use this flag to control the debug data generated by the JIT as well. Since this takes run-time memory, I want to avoid enabling it unless explicitly requested. Change-Id: I2e2afa2f56bb0a113e92cc2e26e00dceac1689ca --- compiler/driver/compiler_options.cc | 2 -- compiler/driver/compiler_options.h | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) (limited to 'compiler/driver') diff --git a/compiler/driver/compiler_options.cc b/compiler/driver/compiler_options.cc index 209bb5a3c2..385f34a9f9 100644 --- a/compiler/driver/compiler_options.cc +++ b/compiler/driver/compiler_options.cc @@ -211,11 +211,9 @@ bool CompilerOptions::ParseCompilerOption(const StringPiece& option, UsageFn Usa generate_debug_info_ = false; } else if (option == "--debuggable") { debuggable_ = true; - generate_debug_info_ = true; } else if (option == "--native-debuggable") { native_debuggable_ = true; debuggable_ = true; - generate_debug_info_ = true; } else if (option.starts_with("--top-k-profile-threshold=")) { ParseDouble(option.data(), '=', 0.0, 100.0, &top_k_profile_threshold_, Usage); } else if (option == "--include-patch-information") { diff --git a/compiler/driver/compiler_options.h b/compiler/driver/compiler_options.h index f8032bb514..f14bdc4a2f 100644 --- a/compiler/driver/compiler_options.h +++ b/compiler/driver/compiler_options.h @@ -50,7 +50,7 @@ class CompilerOptions FINAL { static const size_t kDefaultNumDexMethodsThreshold = 900; static constexpr double kDefaultTopKProfileThreshold = 90.0; static const bool kDefaultNativeDebuggable = false; - static const bool kDefaultGenerateDebugInfo = kIsDebugBuild; + static const bool kDefaultGenerateDebugInfo = false; static const bool kDefaultIncludePatchInformation = false; static const size_t kDefaultInlineDepthLimit = 3; static const size_t kDefaultInlineMaxCodeUnits = 32; -- cgit v1.2.3-59-g8ed1b