From 3db70689e3e1c92344d436a8ea4265046bdef449 Mon Sep 17 00:00:00 2001 From: Andreas Gampe Date: Wed, 26 Dec 2018 15:12:03 -0800 Subject: ART: Refactor for bugprone-argument-comment Handles compiler. Bug: 116054210 Test: WITH_TIDY=1 mmma art Change-Id: I5cdfe73c31ac39144838a2736146b71de037425e --- compiler/driver/compiler_driver.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'compiler/driver/compiler_driver.cc') diff --git a/compiler/driver/compiler_driver.cc b/compiler/driver/compiler_driver.cc index f52c566727..8532586f30 100644 --- a/compiler/driver/compiler_driver.cc +++ b/compiler/driver/compiler_driver.cc @@ -802,7 +802,7 @@ static void InitializeTypeCheckBitstrings(CompilerDriver* driver, ObjPtr klass = class_linker->LookupResolvedType(type_index, dex_cache.Get(), - /* class_loader */ nullptr); + /* class_loader= */ nullptr); CHECK(klass != nullptr) << descriptor << " should have been previously resolved."; // Now assign the bitstring if the class is not final. Keep this in sync with sharpening. if (!klass->IsFinal()) { @@ -1191,7 +1191,7 @@ class ClinitImageUpdate { // Visitor for VisitReferences. void operator()(ObjPtr object, MemberOffset field_offset, - bool /* is_static */) const + bool is_static ATTRIBUTE_UNUSED) const REQUIRES_SHARED(Locks::mutator_lock_) { mirror::Object* ref = object->GetFieldObject(field_offset); if (ref != nullptr) { @@ -1361,7 +1361,7 @@ ArtField* CompilerDriver::ComputeInstanceFieldInfo(uint32_t field_idx, Handle dex_cache(mUnit->GetDexCache()); { Handle class_loader = mUnit->GetClassLoader(); - resolved_field = ResolveField(soa, dex_cache, class_loader, field_idx, /* is_static */ false); + resolved_field = ResolveField(soa, dex_cache, class_loader, field_idx, /* is_static= */ false); referrer_class = resolved_field != nullptr ? ResolveCompilingMethodsClass(soa, dex_cache, class_loader, mUnit) : nullptr; } @@ -2538,7 +2538,7 @@ void CompilerDriver::InitializeClasses(jobject class_loader, } if (GetCompilerOptions().IsBootImage()) { // Prune garbage objects created during aborted transactions. - Runtime::Current()->GetHeap()->CollectGarbage(/* clear_soft_references */ true); + Runtime::Current()->GetHeap()->CollectGarbage(/* clear_soft_references= */ true); } } -- cgit v1.2.3-59-g8ed1b