From 6127341b747ac26b361fd1779e155d940d49e39f Mon Sep 17 00:00:00 2001 From: Konstantin Baladurin Date: Sat, 14 Sep 2024 01:26:02 +0100 Subject: Arm64: fix VecPredToBoolean code generation for SVE This patch fixes code generation for VecPredToBoolean so it updates conditional flags itself based on its predicate input. Prior to this patch, code generation for VecPredToBoolean (incorrectly) implicitly assumed that the conditional flags were always updated by its input HIR (VecPredWhile) and that it immediately followed that HIR. Authors: Konstantin Baladurin Chris Jones Test: env ART_FORCE_TRY_PREDICATED_SIMD=true art/test.py --target --optimizing Test: art/tools/run-gtests.sh Change-Id: Id4c2494cdefd008509f9039e36081151aaf0e4a6 --- compiler/common_compiler_test.h | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'compiler/common_compiler_test.h') diff --git a/compiler/common_compiler_test.h b/compiler/common_compiler_test.h index 32a5234797..80b26eefe9 100644 --- a/compiler/common_compiler_test.h +++ b/compiler/common_compiler_test.h @@ -44,8 +44,12 @@ template class Handle; // Export all symbols in `CommonCompilerTestImpl` for dex2oat tests. class EXPORT CommonCompilerTestImpl { public: - static std::unique_ptr CreateCompilerOptions(InstructionSet instruction_set, - const std::string& variant); + // Create compiler options from the given instruction set and variant. Optionally use a string of + // instruction set features in addition to the features from the variant. + static std::unique_ptr CreateCompilerOptions( + InstructionSet instruction_set, + const std::string& variant, + const std::optional& extra_features = std::nullopt); CommonCompilerTestImpl(); virtual ~CommonCompilerTestImpl(); -- cgit v1.2.3-59-g8ed1b