From 302834e635f2f6ba8f55350c2b9af40b7d7ddc07 Mon Sep 17 00:00:00 2001 From: Martin Stjernholm Date: Fri, 1 Sep 2023 15:42:40 +0100 Subject: Always make cpplint runs quiet. The noise makes it hard to see any errors. Also, with current Soong behaviour the output is buffered, so it doesn't provide any progress indication either. Test: m cpplint-art-all with and without a lint error planted in a .cc file. Bug: 298645703 Change-Id: If3003342d921066f02b35e77338818684c359c71 --- build/Android.cpplint.mk | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'build/Android.cpplint.mk') diff --git a/build/Android.cpplint.mk b/build/Android.cpplint.mk index ab70e97ac5..6eeaa49d8d 100644 --- a/build/Android.cpplint.mk +++ b/build/Android.cpplint.mk @@ -26,9 +26,8 @@ ART_CPPLINT := tools/repohooks/tools/cpplint.py # Everything that could be moved to CPPLINT.cfg has moved there. # Please add new settings to CPPLINT.cfg over adding new flags in this file. -ART_CPPLINT_FLAGS := # No output when there are no errors. -ART_CPPLINT_QUIET := --quiet +ART_CPPLINT_FLAGS := --quiet # 1) Get list of all .h & .cc files in the art directory. # 2) Prepends 'art/' to each of them to make the full name. @@ -58,7 +57,7 @@ art_cpplint_file := $(1) art_cpplint_touch := $$(OUT_CPPLINT)/$$(subst /,__,$$(art_cpplint_file)) $$(art_cpplint_touch): $$(art_cpplint_file) $(ART_CPPLINT) $(ART_CPPLINT_CFG) art/build/Android.cpplint.mk - $(hide) $(ART_CPPLINT) $(ART_CPPLINT_QUIET) $(ART_CPPLINT_FLAGS) $$< + $(hide) $(ART_CPPLINT) $(ART_CPPLINT_FLAGS) $$< $(hide) mkdir -p $$(dir $$@) $(hide) touch $$@ -- cgit v1.2.3-59-g8ed1b