summaryrefslogtreecommitdiff
path: root/libnativeloader/open_system_library.cpp
AgeCommit message (Collapse)Author
2024-03-18Revert "libnativeloader_test: link non-public libs statically" and Martin Stjernholm
remove libnativeloader_test from CTS instead. This reverts commit b2b067192ac047b99c0d03104c5d7dbf79192ef1 which made the CTS test no longer work for API coverage. It also (effectively) reverts commit 996fa745c3ad3e3150363c85816ad2db3a00f5bd which put it in CTS in the first place for that purpose. It's clear libnativeloader_test won't work for API coverage due to the mocking it does, so we'd have to add new tests if there are gaps. However there doesn't seem to be any. Also do a few other cleanups in the Android.bp file. Test: atest libnativeloader_e2e_tests \ libnativeloader_test libnativeloader_lazy_test Bug: 327407752 Change-Id: I488c3d3c5143b7694a8456c3b56edfd511c3c610
2023-04-29libnativeloader_test: link non-public libs statically Lev Rumyantsev
Non-public NDK libs are not supposed to be tested in CTS. Specifically native-bridged execution (e.g. arm on x86) doesn't support this. The awkward thing here is that the test redefines all libnativebridge symbols, but still links shared libnativebridge to call its OpenSystemLibrary. Due to symbols duplication we cannot simply convert libnativebridge to static. Instead, as a quick fix, we copy OpenSystemLibrary implementation from native_bridge.cpp. We expect that one of the codebase owners will find a better way to share OpenSystemLibrary later. Test: cts-tradefed run cts -m libnativeloader_tests (arm on x86) Bug: b/268440713 Change-Id: I7c651200567a299742e7604ee07b043713ca1fec