diff options
Diffstat (limited to 'tools')
-rw-r--r-- | tools/art_verifier/art_verifier.cc | 10 | ||||
-rw-r--r-- | tools/dexanalyze/dexanalyze_experiments.h | 12 | ||||
-rw-r--r-- | tools/dexanalyze/dexanalyze_strings.h | 4 | ||||
-rw-r--r-- | tools/hiddenapi/hiddenapi.cc | 8 | ||||
-rw-r--r-- | tools/tracefast-plugin/tracefast.cc | 30 | ||||
-rw-r--r-- | tools/veridex/flow_analysis.h | 8 |
6 files changed, 36 insertions, 36 deletions
diff --git a/tools/art_verifier/art_verifier.cc b/tools/art_verifier/art_verifier.cc index fc62410889..500c1c5133 100644 --- a/tools/art_verifier/art_verifier.cc +++ b/tools/art_verifier/art_verifier.cc @@ -93,7 +93,7 @@ struct MethodVerifierArgs : public CmdlineArgs { using Base = CmdlineArgs; virtual ParseStatus ParseCustom(const StringPiece& option, - std::string* error_msg) OVERRIDE { + std::string* error_msg) override { { ParseStatus base_parse = Base::ParseCustom(option, error_msg); if (base_parse != kParseUnknownArgument) { @@ -119,7 +119,7 @@ struct MethodVerifierArgs : public CmdlineArgs { return kParseOk; } - virtual ParseStatus ParseChecks(std::string* error_msg) OVERRIDE { + virtual ParseStatus ParseChecks(std::string* error_msg) override { // Perform the parent checks. ParseStatus parent_checks = Base::ParseChecks(error_msg); if (parent_checks != kParseOk) { @@ -166,16 +166,16 @@ struct MethodVerifierArgs : public CmdlineArgs { }; struct MethodVerifierMain : public CmdlineMain<MethodVerifierArgs> { - bool NeedsRuntime() OVERRIDE { + bool NeedsRuntime() override { return true; } - bool ExecuteWithoutRuntime() OVERRIDE { + bool ExecuteWithoutRuntime() override { LOG(FATAL) << "Unreachable"; UNREACHABLE(); } - bool ExecuteWithRuntime(Runtime* runtime) OVERRIDE { + bool ExecuteWithRuntime(Runtime* runtime) override { CHECK(args_ != nullptr); const size_t dex_reps = args_->dex_file_verifier_ diff --git a/tools/dexanalyze/dexanalyze_experiments.h b/tools/dexanalyze/dexanalyze_experiments.h index 3542d959ba..55d2f44e99 100644 --- a/tools/dexanalyze/dexanalyze_experiments.h +++ b/tools/dexanalyze/dexanalyze_experiments.h @@ -65,8 +65,8 @@ class Experiment { // Analyze debug info sizes. class AnalyzeDebugInfo : public Experiment { public: - void ProcessDexFiles(const std::vector<std::unique_ptr<const DexFile>>& dex_files) OVERRIDE; - void Dump(std::ostream& os, uint64_t total_size) const OVERRIDE; + void ProcessDexFiles(const std::vector<std::unique_ptr<const DexFile>>& dex_files) override; + void Dump(std::ostream& os, uint64_t total_size) const override; private: int64_t total_bytes_ = 0u; @@ -91,8 +91,8 @@ class AnalyzeDebugInfo : public Experiment { // Count numbers of dex indices. class CountDexIndices : public Experiment { public: - void ProcessDexFile(const DexFile& dex_file) OVERRIDE; - void ProcessDexFiles(const std::vector<std::unique_ptr<const DexFile>>& dex_files) OVERRIDE; + void ProcessDexFile(const DexFile& dex_file) override; + void ProcessDexFiles(const std::vector<std::unique_ptr<const DexFile>>& dex_files) override; void Dump(std::ostream& os, uint64_t total_size) const; @@ -162,9 +162,9 @@ class CountDexIndices : public Experiment { // Measure various code metrics including args per invoke-virtual, fill/spill move patterns. class CodeMetrics : public Experiment { public: - void ProcessDexFile(const DexFile& dex_file) OVERRIDE; + void ProcessDexFile(const DexFile& dex_file) override; - void Dump(std::ostream& os, uint64_t total_size) const OVERRIDE; + void Dump(std::ostream& os, uint64_t total_size) const override; private: static constexpr size_t kMaxArgCount = 6; diff --git a/tools/dexanalyze/dexanalyze_strings.h b/tools/dexanalyze/dexanalyze_strings.h index a5c202e31f..3559afaff7 100644 --- a/tools/dexanalyze/dexanalyze_strings.h +++ b/tools/dexanalyze/dexanalyze_strings.h @@ -32,8 +32,8 @@ namespace dexanalyze { // Analyze string data and strings accessed from code. class AnalyzeStrings : public Experiment { public: - void ProcessDexFiles(const std::vector<std::unique_ptr<const DexFile>>& dex_files) OVERRIDE; - void Dump(std::ostream& os, uint64_t total_size) const OVERRIDE; + void ProcessDexFiles(const std::vector<std::unique_ptr<const DexFile>>& dex_files) override; + void Dump(std::ostream& os, uint64_t total_size) const override; private: int64_t wide_string_bytes_ = 0u; diff --git a/tools/hiddenapi/hiddenapi.cc b/tools/hiddenapi/hiddenapi.cc index bf8a1b755e..6d9b6fbe40 100644 --- a/tools/hiddenapi/hiddenapi.cc +++ b/tools/hiddenapi/hiddenapi.cc @@ -235,7 +235,7 @@ class DexMember { const bool is_method_; }; -class ClassPath FINAL { +class ClassPath final { public: ClassPath(const std::vector<std::string>& dex_paths, bool open_writable) { OpenDexFiles(dex_paths, open_writable); @@ -316,7 +316,7 @@ class ClassPath FINAL { std::vector<std::unique_ptr<const DexFile>> dex_files_; }; -class HierarchyClass FINAL { +class HierarchyClass final { public: HierarchyClass() {} @@ -455,7 +455,7 @@ class HierarchyClass FINAL { std::vector<HierarchyClass*> extended_by_; }; -class Hierarchy FINAL { +class Hierarchy final { public: explicit Hierarchy(ClassPath& classpath) : classpath_(classpath) { BuildClassHierarchy(); @@ -559,7 +559,7 @@ class Hierarchy FINAL { std::map<std::string, HierarchyClass> classes_; }; -class HiddenApi FINAL { +class HiddenApi final { public: HiddenApi() {} diff --git a/tools/tracefast-plugin/tracefast.cc b/tools/tracefast-plugin/tracefast.cc index ed6ac3d199..4ea5b2ddd9 100644 --- a/tools/tracefast-plugin/tracefast.cc +++ b/tools/tracefast-plugin/tracefast.cc @@ -38,7 +38,7 @@ static constexpr const char* kTracerInstrumentationKey = "tracefast_TRAMPOLINE"; static constexpr bool kNeedsInterpreter = false; #endif // TRACEFAST_INITERPRETER -class Tracer FINAL : public art::instrumentation::InstrumentationListener { +class Tracer final : public art::instrumentation::InstrumentationListener { public: Tracer() {} @@ -46,40 +46,40 @@ class Tracer FINAL : public art::instrumentation::InstrumentationListener { art::Handle<art::mirror::Object> this_object ATTRIBUTE_UNUSED, art::ArtMethod* method ATTRIBUTE_UNUSED, uint32_t dex_pc ATTRIBUTE_UNUSED) - OVERRIDE REQUIRES_SHARED(art::Locks::mutator_lock_) { } + override REQUIRES_SHARED(art::Locks::mutator_lock_) { } void MethodExited(art::Thread* thread ATTRIBUTE_UNUSED, art::Handle<art::mirror::Object> this_object ATTRIBUTE_UNUSED, art::ArtMethod* method ATTRIBUTE_UNUSED, uint32_t dex_pc ATTRIBUTE_UNUSED, art::Handle<art::mirror::Object> return_value ATTRIBUTE_UNUSED) - OVERRIDE REQUIRES_SHARED(art::Locks::mutator_lock_) { } + override REQUIRES_SHARED(art::Locks::mutator_lock_) { } void MethodExited(art::Thread* thread ATTRIBUTE_UNUSED, art::Handle<art::mirror::Object> this_object ATTRIBUTE_UNUSED, art::ArtMethod* method ATTRIBUTE_UNUSED, uint32_t dex_pc ATTRIBUTE_UNUSED, const art::JValue& return_value ATTRIBUTE_UNUSED) - OVERRIDE REQUIRES_SHARED(art::Locks::mutator_lock_) { } + override REQUIRES_SHARED(art::Locks::mutator_lock_) { } void MethodUnwind(art::Thread* thread ATTRIBUTE_UNUSED, art::Handle<art::mirror::Object> this_object ATTRIBUTE_UNUSED, art::ArtMethod* method ATTRIBUTE_UNUSED, uint32_t dex_pc ATTRIBUTE_UNUSED) - OVERRIDE REQUIRES_SHARED(art::Locks::mutator_lock_) { } + override REQUIRES_SHARED(art::Locks::mutator_lock_) { } void DexPcMoved(art::Thread* thread ATTRIBUTE_UNUSED, art::Handle<art::mirror::Object> this_object ATTRIBUTE_UNUSED, art::ArtMethod* method ATTRIBUTE_UNUSED, uint32_t new_dex_pc ATTRIBUTE_UNUSED) - OVERRIDE REQUIRES_SHARED(art::Locks::mutator_lock_) { } + override REQUIRES_SHARED(art::Locks::mutator_lock_) { } void FieldRead(art::Thread* thread ATTRIBUTE_UNUSED, art::Handle<art::mirror::Object> this_object ATTRIBUTE_UNUSED, art::ArtMethod* method ATTRIBUTE_UNUSED, uint32_t dex_pc ATTRIBUTE_UNUSED, art::ArtField* field ATTRIBUTE_UNUSED) - OVERRIDE REQUIRES_SHARED(art::Locks::mutator_lock_) { } + override REQUIRES_SHARED(art::Locks::mutator_lock_) { } void FieldWritten(art::Thread* thread ATTRIBUTE_UNUSED, art::Handle<art::mirror::Object> this_object ATTRIBUTE_UNUSED, @@ -87,7 +87,7 @@ class Tracer FINAL : public art::instrumentation::InstrumentationListener { uint32_t dex_pc ATTRIBUTE_UNUSED, art::ArtField* field ATTRIBUTE_UNUSED, art::Handle<art::mirror::Object> field_value ATTRIBUTE_UNUSED) - OVERRIDE REQUIRES_SHARED(art::Locks::mutator_lock_) { } + override REQUIRES_SHARED(art::Locks::mutator_lock_) { } void FieldWritten(art::Thread* thread ATTRIBUTE_UNUSED, art::Handle<art::mirror::Object> this_object ATTRIBUTE_UNUSED, @@ -95,32 +95,32 @@ class Tracer FINAL : public art::instrumentation::InstrumentationListener { uint32_t dex_pc ATTRIBUTE_UNUSED, art::ArtField* field ATTRIBUTE_UNUSED, const art::JValue& field_value ATTRIBUTE_UNUSED) - OVERRIDE REQUIRES_SHARED(art::Locks::mutator_lock_) { } + override REQUIRES_SHARED(art::Locks::mutator_lock_) { } void ExceptionThrown(art::Thread* thread ATTRIBUTE_UNUSED, art::Handle<art::mirror::Throwable> exception_object ATTRIBUTE_UNUSED) - OVERRIDE REQUIRES_SHARED(art::Locks::mutator_lock_) { } + override REQUIRES_SHARED(art::Locks::mutator_lock_) { } void ExceptionHandled(art::Thread* self ATTRIBUTE_UNUSED, art::Handle<art::mirror::Throwable> throwable ATTRIBUTE_UNUSED) - OVERRIDE REQUIRES_SHARED(art::Locks::mutator_lock_) { } + override REQUIRES_SHARED(art::Locks::mutator_lock_) { } void Branch(art::Thread* thread ATTRIBUTE_UNUSED, art::ArtMethod* method ATTRIBUTE_UNUSED, uint32_t dex_pc ATTRIBUTE_UNUSED, int32_t dex_pc_offset ATTRIBUTE_UNUSED) - OVERRIDE REQUIRES_SHARED(art::Locks::mutator_lock_) { } + override REQUIRES_SHARED(art::Locks::mutator_lock_) { } void InvokeVirtualOrInterface(art::Thread* thread ATTRIBUTE_UNUSED, art::Handle<art::mirror::Object> this_object ATTRIBUTE_UNUSED, art::ArtMethod* caller ATTRIBUTE_UNUSED, uint32_t dex_pc ATTRIBUTE_UNUSED, art::ArtMethod* callee ATTRIBUTE_UNUSED) - OVERRIDE REQUIRES_SHARED(art::Locks::mutator_lock_) { } + override REQUIRES_SHARED(art::Locks::mutator_lock_) { } void WatchedFramePop(art::Thread* thread ATTRIBUTE_UNUSED, const art::ShadowFrame& frame ATTRIBUTE_UNUSED) - OVERRIDE REQUIRES_SHARED(art::Locks::mutator_lock_) { } + override REQUIRES_SHARED(art::Locks::mutator_lock_) { } private: DISALLOW_COPY_AND_ASSIGN(Tracer); @@ -149,7 +149,7 @@ class TraceFastPhaseCB : public art::RuntimePhaseCallback { TraceFastPhaseCB() {} void NextRuntimePhase(art::RuntimePhaseCallback::RuntimePhase phase) - OVERRIDE REQUIRES_SHARED(art::Locks::mutator_lock_) { + override REQUIRES_SHARED(art::Locks::mutator_lock_) { if (phase == art::RuntimePhaseCallback::RuntimePhase::kInit) { art::ScopedThreadSuspension sts(art::Thread::Current(), art::ThreadState::kWaitingForMethodTracingStart); diff --git a/tools/veridex/flow_analysis.h b/tools/veridex/flow_analysis.h index 9c86024711..865b9df03d 100644 --- a/tools/veridex/flow_analysis.h +++ b/tools/veridex/flow_analysis.h @@ -192,8 +192,8 @@ class FlowAnalysisCollector : public VeriFlowAnalysis { return uses_; } - RegisterValue AnalyzeInvoke(const Instruction& instruction, bool is_range) OVERRIDE; - void AnalyzeFieldSet(const Instruction& instruction) OVERRIDE; + RegisterValue AnalyzeInvoke(const Instruction& instruction, bool is_range) override; + void AnalyzeFieldSet(const Instruction& instruction) override; private: // List of reflection uses found, concrete and abstract. @@ -212,8 +212,8 @@ class FlowAnalysisSubstitutor : public VeriFlowAnalysis { return uses_; } - RegisterValue AnalyzeInvoke(const Instruction& instruction, bool is_range) OVERRIDE; - void AnalyzeFieldSet(const Instruction& instruction) OVERRIDE; + RegisterValue AnalyzeInvoke(const Instruction& instruction, bool is_range) override; + void AnalyzeFieldSet(const Instruction& instruction) override; private: // List of reflection uses found, concrete and abstract. |