diff options
Diffstat (limited to 'disassembler')
-rw-r--r-- | disassembler/Android.mk | 4 | ||||
-rw-r--r-- | disassembler/disassembler.cc | 14 | ||||
-rw-r--r-- | disassembler/disassembler.h | 8 | ||||
-rw-r--r-- | disassembler/disassembler_arm.cc | 7 | ||||
-rw-r--r-- | disassembler/disassembler_arm64.cc | 6 | ||||
-rw-r--r-- | disassembler/disassembler_mips.cc | 6 | ||||
-rw-r--r-- | disassembler/disassembler_x86.cc | 6 |
7 files changed, 33 insertions, 18 deletions
diff --git a/disassembler/Android.mk b/disassembler/Android.mk index 630f3e4656..6304c57e3e 100644 --- a/disassembler/Android.mk +++ b/disassembler/Android.mk @@ -90,14 +90,14 @@ define build-libart-disassembler endif ifeq ($$(art_static_or_shared),static) - LOCAL_STATIC_LIBRARIES += liblog + LOCAL_STATIC_LIBRARIES += liblog libbase ifeq ($$(art_ndebug_or_debug),debug) LOCAL_STATIC_LIBRARIES += libartd else LOCAL_STATIC_LIBRARIES += libart endif else # shared - LOCAL_SHARED_LIBRARIES += liblog + LOCAL_SHARED_LIBRARIES += liblog libbase ifeq ($$(art_ndebug_or_debug),debug) LOCAL_SHARED_LIBRARIES += libartd else diff --git a/disassembler/disassembler.cc b/disassembler/disassembler.cc index bcd0d1630a..8eecc62cd5 100644 --- a/disassembler/disassembler.cc +++ b/disassembler/disassembler.cc @@ -18,15 +18,23 @@ #include <ostream> -#include "base/logging.h" -#include "base/stringprintf.h" +#include "android-base/logging.h" +#include "android-base/stringprintf.h" + #include "disassembler_arm.h" #include "disassembler_arm64.h" #include "disassembler_mips.h" #include "disassembler_x86.h" +using android::base::StringPrintf; + namespace art { +Disassembler::Disassembler(DisassemblerOptions* disassembler_options) + : disassembler_options_(disassembler_options) { + CHECK(disassembler_options_ != nullptr); +} + Disassembler* Disassembler::Create(InstructionSet instruction_set, DisassemblerOptions* options) { if (instruction_set == kArm || instruction_set == kThumb2) { return new arm::DisassemblerArm(options); @@ -39,7 +47,7 @@ Disassembler* Disassembler::Create(InstructionSet instruction_set, DisassemblerO } else if (instruction_set == kX86_64) { return new x86::DisassemblerX86(options, true); } else { - UNIMPLEMENTED(FATAL) << "no disassembler for " << instruction_set; + UNIMPLEMENTED(FATAL) << static_cast<uint32_t>(instruction_set); return nullptr; } } diff --git a/disassembler/disassembler.h b/disassembler/disassembler.h index 86793ccb19..1ef456cefd 100644 --- a/disassembler/disassembler.h +++ b/disassembler/disassembler.h @@ -21,8 +21,9 @@ #include <iosfwd> +#include "android-base/macros.h" + #include "arch/instruction_set.h" -#include "base/macros.h" namespace art { @@ -81,10 +82,7 @@ class Disassembler { } protected: - explicit Disassembler(DisassemblerOptions* disassembler_options) - : disassembler_options_(disassembler_options) { - CHECK(disassembler_options_ != nullptr); - } + explicit Disassembler(DisassemblerOptions* disassembler_options); std::string FormatInstructionPointer(const uint8_t* begin); diff --git a/disassembler/disassembler_arm.cc b/disassembler/disassembler_arm.cc index a47b6adcc9..c3e288deae 100644 --- a/disassembler/disassembler_arm.cc +++ b/disassembler/disassembler_arm.cc @@ -21,10 +21,13 @@ #include <ostream> #include <sstream> +#include "android-base/logging.h" +#include "android-base/stringprintf.h" + #include "arch/arm/registers_arm.h" #include "base/bit_utils.h" -#include "base/logging.h" -#include "base/stringprintf.h" + +using android::base::StringPrintf; namespace art { namespace arm { diff --git a/disassembler/disassembler_arm64.cc b/disassembler/disassembler_arm64.cc index 80bacb2be3..49b9623f4f 100644 --- a/disassembler/disassembler_arm64.cc +++ b/disassembler/disassembler_arm64.cc @@ -20,8 +20,10 @@ #include <sstream> -#include "base/logging.h" -#include "base/stringprintf.h" +#include "android-base/logging.h" +#include "android-base/stringprintf.h" + +using android::base::StringPrintf; using namespace vixl::aarch64; // NOLINT(build/namespaces) diff --git a/disassembler/disassembler_mips.cc b/disassembler/disassembler_mips.cc index 02c6d71510..9a73f29556 100644 --- a/disassembler/disassembler_mips.cc +++ b/disassembler/disassembler_mips.cc @@ -19,8 +19,10 @@ #include <ostream> #include <sstream> -#include "base/logging.h" -#include "base/stringprintf.h" +#include "android-base/logging.h" +#include "android-base/stringprintf.h" + +using android::base::StringPrintf; namespace art { namespace mips { diff --git a/disassembler/disassembler_x86.cc b/disassembler/disassembler_x86.cc index 2ca84e5e5b..9f49ec6f60 100644 --- a/disassembler/disassembler_x86.cc +++ b/disassembler/disassembler_x86.cc @@ -21,8 +21,10 @@ #include <ostream> #include <sstream> -#include "base/logging.h" -#include "base/stringprintf.h" +#include "android-base/logging.h" +#include "android-base/stringprintf.h" + +using android::base::StringPrintf; namespace art { namespace x86 { |