diff options
Diffstat (limited to 'compiler')
| -rw-r--r-- | compiler/dex/frontend.cc | 16 | ||||
| -rw-r--r-- | compiler/driver/compiler_driver.cc | 4 | ||||
| -rw-r--r-- | compiler/driver/compiler_driver.h | 15 | ||||
| -rw-r--r-- | compiler/oat_test.cc | 3 |
4 files changed, 9 insertions, 29 deletions
diff --git a/compiler/dex/frontend.cc b/compiler/dex/frontend.cc index 364a8bc55b..f5bb85a910 100644 --- a/compiler/dex/frontend.cc +++ b/compiler/dex/frontend.cc @@ -141,25 +141,24 @@ CompilationUnit::CompilationUnit(ArenaPool* pool) CompilationUnit::~CompilationUnit() { } +// TODO: Add a cumulative version of logging, and combine with dex2oat --dump-timing void CompilationUnit::StartTimingSplit(const char* label) { - if (compiler_driver->GetDumpPasses()) { + if (enable_debug & (1 << kDebugTimings)) { timings.StartSplit(label); } } void CompilationUnit::NewTimingSplit(const char* label) { - if (compiler_driver->GetDumpPasses()) { + if (enable_debug & (1 << kDebugTimings)) { timings.NewSplit(label); } } void CompilationUnit::EndTiming() { - if (compiler_driver->GetDumpPasses()) { + if (enable_debug & (1 << kDebugTimings)) { timings.EndSplit(); - if (enable_debug & (1 << kDebugTimings)) { - LOG(INFO) << "TIMINGS " << PrettyMethod(method_idx, *dex_file); - LOG(INFO) << Dumpable<TimingLogger>(timings); - } + LOG(INFO) << "TIMINGS " << PrettyMethod(method_idx, *dex_file); + LOG(INFO) << Dumpable<TimingLogger>(timings); } } @@ -317,9 +316,6 @@ static CompiledMethod* CompileMethod(CompilerDriver& compiler, } cu.EndTiming(); - compiler.GetTimingsLogger().Start(); - compiler.GetTimingsLogger().AddLogger(cu.timings); - compiler.GetTimingsLogger().End(); return result; } diff --git a/compiler/driver/compiler_driver.cc b/compiler/driver/compiler_driver.cc index 714dc4cb5e..5edc8b6771 100644 --- a/compiler/driver/compiler_driver.cc +++ b/compiler/driver/compiler_driver.cc @@ -341,7 +341,7 @@ CompilerDriver::CompilerDriver(VerifiedMethodsData* verified_methods_data, CompilerBackend compiler_backend, InstructionSet instruction_set, InstructionSetFeatures instruction_set_features, bool image, DescriptorSet* image_classes, size_t thread_count, - bool dump_stats, bool dump_passes, CumulativeLogger* timer) + bool dump_stats) : verified_methods_data_(verified_methods_data), method_inliner_map_(method_inliner_map), compiler_backend_(compiler_backend), @@ -356,8 +356,6 @@ CompilerDriver::CompilerDriver(VerifiedMethodsData* verified_methods_data, start_ns_(0), stats_(new AOTCompilationStats), dump_stats_(dump_stats), - dump_passes_(dump_passes), - timings_logger_(timer), compiler_library_(NULL), compiler_(NULL), compiler_context_(NULL), diff --git a/compiler/driver/compiler_driver.h b/compiler/driver/compiler_driver.h index aabdf2f9f6..9e316242ba 100644 --- a/compiler/driver/compiler_driver.h +++ b/compiler/driver/compiler_driver.h @@ -22,7 +22,6 @@ #include <vector> #include "base/mutex.h" -#include "base/timing_logger.h" #include "class_reference.h" #include "compiled_class.h" #include "compiled_method.h" @@ -98,8 +97,7 @@ class CompilerDriver { CompilerBackend compiler_backend, InstructionSet instruction_set, InstructionSetFeatures instruction_set_features, bool image, DescriptorSet* image_classes, - size_t thread_count, bool dump_stats, bool dump_passes, - CumulativeLogger* timer); + size_t thread_count, bool dump_stats); ~CompilerDriver(); @@ -269,14 +267,6 @@ class CompilerDriver { return thread_count_; } - bool GetDumpPasses() const { - return dump_passes_; - } - - CumulativeLogger& GetTimingsLogger() const { - return *timings_logger_; - } - class PatchInformation { public: const DexFile& GetDexFile() const { @@ -446,9 +436,6 @@ class CompilerDriver { UniquePtr<AOTCompilationStats> stats_; bool dump_stats_; - const bool dump_passes_; - - CumulativeLogger* const timings_logger_; typedef void (*CompilerCallbackFn)(CompilerDriver& driver); typedef MutexLock* (*CompilerMutexLockFn)(CompilerDriver& driver); diff --git a/compiler/oat_test.cc b/compiler/oat_test.cc index 12d821239f..2434262279 100644 --- a/compiler/oat_test.cc +++ b/compiler/oat_test.cc @@ -82,11 +82,10 @@ TEST_F(OatTest, WriteRead) { verified_methods_data_.reset(new VerifiedMethodsData); method_inliner_map_.reset(compiler_backend == kQuick ? new DexFileToMethodInlinerMap : nullptr); callbacks_.Reset(verified_methods_data_.get(), method_inliner_map_.get()); - CumulativeLogger timer("Compilation times"); compiler_driver_.reset(new CompilerDriver(verified_methods_data_.get(), method_inliner_map_.get(), compiler_backend, insn_set, - insn_features, false, NULL, 2, true, true, &timer)); + insn_features, false, NULL, 2, true)); jobject class_loader = NULL; if (kCompile) { TimingLogger timings("OatTest::WriteRead", false, false); |