summaryrefslogtreecommitdiff
path: root/compiler/optimizing/code_generator.cc
diff options
context:
space:
mode:
Diffstat (limited to 'compiler/optimizing/code_generator.cc')
-rw-r--r--compiler/optimizing/code_generator.cc30
1 files changed, 30 insertions, 0 deletions
diff --git a/compiler/optimizing/code_generator.cc b/compiler/optimizing/code_generator.cc
index b0e07e32ea..0e294b560a 100644
--- a/compiler/optimizing/code_generator.cc
+++ b/compiler/optimizing/code_generator.cc
@@ -158,6 +158,25 @@ ReadBarrierOption CodeGenerator::GetCompilerReadBarrierOption() const {
return EmitReadBarrier() ? kWithReadBarrier : kWithoutReadBarrier;
}
+bool CodeGenerator::ShouldCheckGCCard(DataType::Type type,
+ HInstruction* value,
+ WriteBarrierKind write_barrier_kind) const {
+ const CompilerOptions& options = GetCompilerOptions();
+ const bool result =
+ // Check the GC card in debug mode,
+ options.EmitRunTimeChecksInDebugMode() &&
+ // only for CC GC,
+ options.EmitReadBarrier() &&
+ // and if we eliminated the write barrier in WBE.
+ !StoreNeedsWriteBarrier(type, value, write_barrier_kind) &&
+ CodeGenerator::StoreNeedsWriteBarrier(type, value);
+
+ DCHECK_IMPLIES(result, write_barrier_kind == WriteBarrierKind::kDontEmit);
+ DCHECK_IMPLIES(result, !GetGraph()->IsCompilingBaseline());
+
+ return result;
+}
+
ScopedArenaAllocator* CodeGenerator::GetScopedAllocator() {
DCHECK(code_generation_data_ != nullptr);
return code_generation_data_->GetScopedAllocator();
@@ -1608,6 +1627,17 @@ void CodeGenerator::EmitParallelMoves(Location from1,
GetMoveResolver()->EmitNativeCode(&parallel_move);
}
+bool CodeGenerator::StoreNeedsWriteBarrier(DataType::Type type,
+ HInstruction* value,
+ WriteBarrierKind write_barrier_kind) const {
+ // Check that null value is not represented as an integer constant.
+ DCHECK_IMPLIES(type == DataType::Type::kReference, !value->IsIntConstant());
+ // Branch profiling currently doesn't support running optimizations.
+ return GetGraph()->IsCompilingBaseline()
+ ? CodeGenerator::StoreNeedsWriteBarrier(type, value)
+ : write_barrier_kind != WriteBarrierKind::kDontEmit;
+}
+
void CodeGenerator::ValidateInvokeRuntime(QuickEntrypointEnum entrypoint,
HInstruction* instruction,
SlowPathCode* slow_path) {