diff options
-rw-r--r-- | compiler/optimizing/code_generator_vector_arm64.cc | 2 | ||||
-rw-r--r-- | compiler/optimizing/code_generator_vector_x86.cc | 2 | ||||
-rw-r--r-- | compiler/optimizing/code_generator_vector_x86_64.cc | 2 | ||||
-rw-r--r-- | compiler/optimizing/intrinsics_mips.cc | 1 | ||||
-rw-r--r-- | compiler/optimizing/intrinsics_mips64.cc | 1 | ||||
-rw-r--r-- | compiler/optimizing/scheduler_arm.cc | 1 | ||||
-rw-r--r-- | compiler/optimizing/scheduler_arm64.cc | 1 | ||||
-rw-r--r-- | runtime/mirror/accessible_object.h | 11 | ||||
-rw-r--r-- | runtime/mirror/array-inl.h | 3 | ||||
-rw-r--r-- | runtime/mirror/field-inl.h | 7 | ||||
-rw-r--r-- | runtime/mirror/field.h | 7 | ||||
-rw-r--r-- | runtime/mirror/object-inl.h | 8 | ||||
-rw-r--r-- | runtime/mirror/object.h | 7 | ||||
-rw-r--r-- | runtime/native/java_lang_reflect_Field.cc | 2 |
14 files changed, 28 insertions, 27 deletions
diff --git a/compiler/optimizing/code_generator_vector_arm64.cc b/compiler/optimizing/code_generator_vector_arm64.cc index f422b9fc8b..9095ecdf16 100644 --- a/compiler/optimizing/code_generator_vector_arm64.cc +++ b/compiler/optimizing/code_generator_vector_arm64.cc @@ -15,7 +15,9 @@ */ #include "code_generator_arm64.h" + #include "mirror/array-inl.h" +#include "mirror/string.h" using namespace vixl::aarch64; // NOLINT(build/namespaces) diff --git a/compiler/optimizing/code_generator_vector_x86.cc b/compiler/optimizing/code_generator_vector_x86.cc index 14782d70a1..e7aec76aff 100644 --- a/compiler/optimizing/code_generator_vector_x86.cc +++ b/compiler/optimizing/code_generator_vector_x86.cc @@ -15,7 +15,9 @@ */ #include "code_generator_x86.h" + #include "mirror/array-inl.h" +#include "mirror/string.h" namespace art { namespace x86 { diff --git a/compiler/optimizing/code_generator_vector_x86_64.cc b/compiler/optimizing/code_generator_vector_x86_64.cc index 246044ebb8..c7ee81c60d 100644 --- a/compiler/optimizing/code_generator_vector_x86_64.cc +++ b/compiler/optimizing/code_generator_vector_x86_64.cc @@ -15,7 +15,9 @@ */ #include "code_generator_x86_64.h" + #include "mirror/array-inl.h" +#include "mirror/string.h" namespace art { namespace x86_64 { diff --git a/compiler/optimizing/intrinsics_mips.cc b/compiler/optimizing/intrinsics_mips.cc index 4cea6dfdfb..2669d97d82 100644 --- a/compiler/optimizing/intrinsics_mips.cc +++ b/compiler/optimizing/intrinsics_mips.cc @@ -22,6 +22,7 @@ #include "entrypoints/quick/quick_entrypoints.h" #include "intrinsics.h" #include "mirror/array-inl.h" +#include "mirror/object_array-inl.h" #include "mirror/string.h" #include "scoped_thread_state_change-inl.h" #include "thread.h" diff --git a/compiler/optimizing/intrinsics_mips64.cc b/compiler/optimizing/intrinsics_mips64.cc index d785567e0f..74be954a75 100644 --- a/compiler/optimizing/intrinsics_mips64.cc +++ b/compiler/optimizing/intrinsics_mips64.cc @@ -22,6 +22,7 @@ #include "entrypoints/quick/quick_entrypoints.h" #include "intrinsics.h" #include "mirror/array-inl.h" +#include "mirror/object_array-inl.h" #include "mirror/string.h" #include "scoped_thread_state_change-inl.h" #include "thread.h" diff --git a/compiler/optimizing/scheduler_arm.cc b/compiler/optimizing/scheduler_arm.cc index ea15790105..d6eb6e3c52 100644 --- a/compiler/optimizing/scheduler_arm.cc +++ b/compiler/optimizing/scheduler_arm.cc @@ -20,6 +20,7 @@ #include "code_generator_utils.h" #include "common_arm.h" #include "mirror/array-inl.h" +#include "mirror/string.h" namespace art { namespace arm { diff --git a/compiler/optimizing/scheduler_arm64.cc b/compiler/optimizing/scheduler_arm64.cc index f54d3f3de2..510619faf9 100644 --- a/compiler/optimizing/scheduler_arm64.cc +++ b/compiler/optimizing/scheduler_arm64.cc @@ -18,6 +18,7 @@ #include "code_generator_utils.h" #include "mirror/array-inl.h" +#include "mirror/string.h" namespace art { namespace arm64 { diff --git a/runtime/mirror/accessible_object.h b/runtime/mirror/accessible_object.h index a217193522..d489f14536 100644 --- a/runtime/mirror/accessible_object.h +++ b/runtime/mirror/accessible_object.h @@ -17,11 +17,8 @@ #ifndef ART_RUNTIME_MIRROR_ACCESSIBLE_OBJECT_H_ #define ART_RUNTIME_MIRROR_ACCESSIBLE_OBJECT_H_ -#include "class.h" -#include "gc_root.h" #include "object.h" #include "read_barrier_option.h" -#include "thread.h" namespace art { @@ -34,12 +31,6 @@ class MANAGED AccessibleObject : public Object { return OFFSET_OF_OBJECT_MEMBER(AccessibleObject, flag_); } - template<bool kTransactionActive> - void SetAccessible(bool value) REQUIRES_SHARED(Locks::mutator_lock_) { - UNUSED(padding_); - return SetFieldBoolean<kTransactionActive>(FlagOffset(), value ? 1u : 0u); - } - bool IsAccessible() REQUIRES_SHARED(Locks::mutator_lock_) { return GetFieldBoolean(FlagOffset()); } @@ -47,7 +38,7 @@ class MANAGED AccessibleObject : public Object { private: uint8_t flag_; // Padding required for correct alignment of subclasses like Executable, Field, etc. - uint8_t padding_[1]; + uint8_t padding_[1] ATTRIBUTE_UNUSED; DISALLOW_IMPLICIT_CONSTRUCTORS(AccessibleObject); }; diff --git a/runtime/mirror/array-inl.h b/runtime/mirror/array-inl.h index 63142d5c25..22812454d1 100644 --- a/runtime/mirror/array-inl.h +++ b/runtime/mirror/array-inl.h @@ -27,8 +27,7 @@ #include "class.h" #include "gc/heap-inl.h" #include "obj_ptr-inl.h" -#include "object-inl.h" -#include "thread.h" +#include "thread-current-inl.h" namespace art { namespace mirror { diff --git a/runtime/mirror/field-inl.h b/runtime/mirror/field-inl.h index d33df5c8e7..ad48202514 100644 --- a/runtime/mirror/field-inl.h +++ b/runtime/mirror/field-inl.h @@ -20,7 +20,8 @@ #include "field.h" #include "art_field-inl.h" -#include "mirror/dex_cache-inl.h" +#include "class-inl.h" +#include "dex_cache-inl.h" namespace art { @@ -87,6 +88,10 @@ inline void Field::SetType(ObjPtr<mirror::Class> type) { SetFieldObject<kTransactionActive>(OFFSET_OF_OBJECT_MEMBER(Field, type_), type); } +inline Primitive::Type Field::GetTypeAsPrimitiveType() { + return GetType()->GetPrimitiveType(); +} + } // namespace mirror } // namespace art diff --git a/runtime/mirror/field.h b/runtime/mirror/field.h index 40186a689b..6845575d18 100644 --- a/runtime/mirror/field.h +++ b/runtime/mirror/field.h @@ -20,8 +20,10 @@ #include "accessible_object.h" #include "base/enums.h" #include "gc_root.h" +#include "modifiers.h" #include "obj_ptr.h" #include "object.h" +#include "primitive.h" #include "read_barrier_option.h" namespace art { @@ -69,10 +71,7 @@ class MANAGED Field : public AccessibleObject { return (GetAccessFlags() & kAccVolatile) != 0; } - ALWAYS_INLINE Primitive::Type GetTypeAsPrimitiveType() - REQUIRES_SHARED(Locks::mutator_lock_) { - return GetType()->GetPrimitiveType(); - } + ALWAYS_INLINE Primitive::Type GetTypeAsPrimitiveType() REQUIRES_SHARED(Locks::mutator_lock_); mirror::Class* GetType() REQUIRES_SHARED(Locks::mutator_lock_) { return GetFieldObject<mirror::Class>(OFFSET_OF_OBJECT_MEMBER(Field, type_)); diff --git a/runtime/mirror/object-inl.h b/runtime/mirror/object-inl.h index 086925b9c7..4f8952d8c2 100644 --- a/runtime/mirror/object-inl.h +++ b/runtime/mirror/object-inl.h @@ -393,14 +393,6 @@ inline size_t Object::SizeOf() { } template<VerifyObjectFlags kVerifyFlags, bool kIsVolatile> -inline uint8_t Object::GetFieldBoolean(MemberOffset field_offset) { - if (kVerifyFlags & kVerifyThis) { - VerifyObject(this); - } - return GetField<uint8_t, kIsVolatile>(field_offset); -} - -template<VerifyObjectFlags kVerifyFlags, bool kIsVolatile> inline int8_t Object::GetFieldByte(MemberOffset field_offset) { if (kVerifyFlags & kVerifyThis) { VerifyObject(this); diff --git a/runtime/mirror/object.h b/runtime/mirror/object.h index 886780f051..aedcd66082 100644 --- a/runtime/mirror/object.h +++ b/runtime/mirror/object.h @@ -380,7 +380,12 @@ class MANAGED LOCKABLE Object { template<VerifyObjectFlags kVerifyFlags = kDefaultVerifyFlags, bool kIsVolatile = false> ALWAYS_INLINE uint8_t GetFieldBoolean(MemberOffset field_offset) - REQUIRES_SHARED(Locks::mutator_lock_); + REQUIRES_SHARED(Locks::mutator_lock_) { + if (kVerifyFlags & kVerifyThis) { + VerifyObject(this); + } + return GetField<uint8_t, kIsVolatile>(field_offset); + } template<VerifyObjectFlags kVerifyFlags = kDefaultVerifyFlags, bool kIsVolatile = false> ALWAYS_INLINE int8_t GetFieldByte(MemberOffset field_offset) diff --git a/runtime/native/java_lang_reflect_Field.cc b/runtime/native/java_lang_reflect_Field.cc index 9f59a1f751..2e4dd8a599 100644 --- a/runtime/native/java_lang_reflect_Field.cc +++ b/runtime/native/java_lang_reflect_Field.cc @@ -27,7 +27,7 @@ #include "dex_file_annotations.h" #include "jni_internal.h" #include "mirror/class-inl.h" -#include "mirror/field.h" +#include "mirror/field-inl.h" #include "native_util.h" #include "reflection-inl.h" #include "scoped_fast_native_object_access-inl.h" |