summaryrefslogtreecommitdiff
path: root/tools/cpp-define-generator
diff options
context:
space:
mode:
author Santiago Aboy Solanes <solanes@google.com> 2024-10-29 10:26:51 +0000
committer Santiago Aboy Solanes <solanes@google.com> 2024-11-07 14:23:49 +0000
commit07a58eb1cb4b7c5b1f307af6676c8b52b3e5c0cd (patch)
treeec1843a1922681b77843d4d0aba44640083b3f71 /tools/cpp-define-generator
parent3086bbd64c0b8ca90c891f9cb73e057b7c7dc45b (diff)
Revert^4 "IsMemorySharedMethod fix for intrinsics"
This reverts commit a5557d9da3e603a0531e566abf4d08579b9b8141. Reason for revert: Fixed adding SetHotCounter in SetIntrinsic. We are expecting both intrinsics and memory shared methods to have that set as 0 i.e. hot. Intrinsics are always considered hot, and memory shared methods use another counter. This is now DCHECKed in `Jit::AddSamples`. Changes can be seen in patchsets 1..5. I also noticed that there were comments in x86(_64) `s` files that needed to be moved to the right place. Test: art/test/testrunner/testrunner.py --host --64 -b --jit Test: No timeout in presubmit-cts-deviceside-cloud (see b/78151261) Test: No timeout in nexus_unit_test_multi_device_platform Bug: 78151261 Bug: 162110941 Change-Id: Iee99f0d42fcdb3f5ab2b20b4b7a8126c7c03b358
Diffstat (limited to 'tools/cpp-define-generator')
-rw-r--r--tools/cpp-define-generator/art_method.def4
1 files changed, 4 insertions, 0 deletions
diff --git a/tools/cpp-define-generator/art_method.def b/tools/cpp-define-generator/art_method.def
index d5ba59998d..3c34247ec2 100644
--- a/tools/cpp-define-generator/art_method.def
+++ b/tools/cpp-define-generator/art_method.def
@@ -21,6 +21,10 @@
ASM_DEFINE(ART_METHOD_ACCESS_FLAGS_OFFSET,
art::ArtMethod::AccessFlagsOffset().Int32Value())
+ASM_DEFINE(ART_METHOD_IS_INTRINSIC_FLAG,
+ art::kAccIntrinsic)
+ASM_DEFINE(ART_METHOD_IS_INTRINSIC_FLAG_BIT,
+ art::MostSignificantBit(art::kAccIntrinsic))
ASM_DEFINE(ART_METHOD_IS_MEMORY_SHARED_FLAG,
art::kAccMemorySharedMethod)
ASM_DEFINE(ART_METHOD_IS_MEMORY_SHARED_FLAG_BIT,