diff options
author | 2015-05-15 16:01:59 +0100 | |
---|---|---|
committer | 2015-05-15 16:50:23 +0100 | |
commit | c57397b2b87c7e6f28f4eee3c996d091e7dc0b01 (patch) | |
tree | 51ef8e6126cb41174f6103700c5f5442a38bbfe5 /test/474-checker-boolean-input/src/Main.java | |
parent | 06675720cc274eb9d91a4ecd3fb1eef94a2d88f0 (diff) |
ART: Print C1vis lists as [v1,...,vN]
Checker interprets whitespace as a don't-care placeholder, making it
easier to write assertions which test only parts of the output (e.g.
"//CHECK: Add liveness:44" does not test the inputs or any other
attributes apart from "liveness").
However, since the GraphVisualizer prints lists with elements
separated by spaces ("[ v1 ... vN ]"), this allows for false positives
caused by an occurrence elsewhere in the output. For example, the
assertion: "//CHECK: [ x y ]" will match "[ x y ]" but also
"[ x a y b ]" or even "[ x ] abc [ y ]".
Switching to comma-separated lists works around this issue.
This patch updates all test files, fixes one false positive that this
change revealed (test 442, line 337) and two occurrences of a wrong
match (test 462, lines 121, 149).
Bug: 21189305
Change-Id: I3b22503be3d92529dac0b13f66bccbcfabea6721
Diffstat (limited to 'test/474-checker-boolean-input/src/Main.java')
-rw-r--r-- | test/474-checker-boolean-input/src/Main.java | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/test/474-checker-boolean-input/src/Main.java b/test/474-checker-boolean-input/src/Main.java index a395ff915a..490f7f9cbc 100644 --- a/test/474-checker-boolean-input/src/Main.java +++ b/test/474-checker-boolean-input/src/Main.java @@ -29,7 +29,7 @@ public class Main { // CHECK-START: boolean Main.TestPhiAsBoolean(int) boolean_simplifier (after) // CHECK-DAG: <<Phi:i\d+>> Phi - // CHECK-DAG: BooleanNot [ <<Phi>> ] + // CHECK-DAG: BooleanNot [<<Phi>>] public static boolean f1; public static boolean f2; @@ -49,7 +49,7 @@ public class Main { // CHECK-START: boolean Main.TestAndAsBoolean(boolean, boolean) boolean_simplifier (after) // CHECK-DAG: <<And:i\d+>> And - // CHECK-DAG: BooleanNot [ <<And>> ] + // CHECK-DAG: BooleanNot [<<And>>] public static boolean InlineAnd(boolean x, boolean y) { return x & y; @@ -66,7 +66,7 @@ public class Main { // CHECK-START: boolean Main.TestOrAsBoolean(boolean, boolean) boolean_simplifier (after) // CHECK-DAG: <<Or:i\d+>> Or - // CHECK-DAG: BooleanNot [ <<Or>> ] + // CHECK-DAG: BooleanNot [<<Or>>] public static boolean InlineOr(boolean x, boolean y) { return x | y; @@ -83,7 +83,7 @@ public class Main { // CHECK-START: boolean Main.TestXorAsBoolean(boolean, boolean) boolean_simplifier (after) // CHECK-DAG: <<Xor:i\d+>> Xor - // CHECK-DAG: BooleanNot [ <<Xor>> ] + // CHECK-DAG: BooleanNot [<<Xor>>] public static boolean InlineXor(boolean x, boolean y) { return x ^ y; |