summaryrefslogtreecommitdiff
path: root/test/2238-checker-polymorphic-recursive-inlining/src/BaseClass.java
diff options
context:
space:
mode:
author Santiago Aboy Solanes <solanes@google.com> 2022-02-10 10:25:15 +0000
committer Santiago Aboy Solanes <solanes@google.com> 2022-02-15 09:51:13 +0000
commit4f5b7cb3dfef3ea175439a8a541f8c9f9458d34a (patch)
treedd97e8e556131c594b1adc8b7a963775a5009128 /test/2238-checker-polymorphic-recursive-inlining/src/BaseClass.java
parent2c3b085a3d16fc2b53175f56d3e4bcd52f34cf2d (diff)
Limit recursive polymorphic inlining to prevent code bloat
If both NoRecursion and Wrapper implement the same method MyMethod, NoRecursion with just `return false` and Wrapper with `return BaseClass.MyMethod()` we would end up with generated code similar to: ``` if (receiver == NoRecursion) { return false; } else if (receiver == Wrapper) { // A polymorphic invoke which turns into: if (unwrappedValue.receiver == NoRecursion) { return false; } else if (unwrappedValue.receiver == Wrapper) { // A polymorphic invoke which turns into // [...] you get the gist, we do this several times. } else { // HInvokeVirtual } } else { // HInvokeVirtual } ``` After the change we would have: ``` if (receiver == NoRecursion) { return false; } else { // HInvokeVirtual } ``` This pattern was worse when there were more than one recursive polymorphic case, increasing exponentially in size. This was common to see on Wrapper classes, but uncommon otherwise. In the two wrappers plus one non-wrapper case in test/2238-, we will now generate a .cfg which is about 6% the size versus before this CL (12M -> 779K). Test: art/test/testrunner/testrunner.py --host --64 --optimizing -b Bug: 217464625 Change-Id: I3c6444193ea2f24af29d97549776a283ef177efd
Diffstat (limited to 'test/2238-checker-polymorphic-recursive-inlining/src/BaseClass.java')
-rw-r--r--test/2238-checker-polymorphic-recursive-inlining/src/BaseClass.java19
1 files changed, 19 insertions, 0 deletions
diff --git a/test/2238-checker-polymorphic-recursive-inlining/src/BaseClass.java b/test/2238-checker-polymorphic-recursive-inlining/src/BaseClass.java
new file mode 100644
index 0000000000..38e6f071c1
--- /dev/null
+++ b/test/2238-checker-polymorphic-recursive-inlining/src/BaseClass.java
@@ -0,0 +1,19 @@
+/*
+ * Copyright (C) 2022 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+public abstract class BaseClass {
+ abstract boolean recursiveTwoWrappers();
+}