summaryrefslogtreecommitdiff
path: root/src/compiler/codegen/MethodBitcode.cc
diff options
context:
space:
mode:
author Ian Rogers <irogers@google.com> 2012-09-25 00:20:38 -0700
committer Ian Rogers <irogers@google.com> 2012-09-25 17:01:42 -0700
commit474b6da273c7ce6df50a4e51eb9929a77e1611c3 (patch)
treeb67074e7e4c16e01384c2f7d416f4e4ad3b3bd61 /src/compiler/codegen/MethodBitcode.cc
parentde1ef40bd5f344dbb0bdb68f555f45868f502ae6 (diff)
Move thread flags and state into 32bits.
We need to ensure that transitions to Runnable are atomic wrt to a thread modifying the suspend count. Currently this is achieved by holding the thread_suspend_count_lock_. This change creates a set of bit flags that summarize that the suspend_count_ is raised and also others flags that signify the managed code should go into a slow path. The effect of this change are two-fold: 1) transitions from suspended to runnable can CAS the thread state rather than holding the suspend_count_lock_. This will make JNI transitions cheaper. 2) the exception/suspend/interpreter poll needed for shadow frames can be rolled into a single compare of the bit fields against 0. Change-Id: I589f84e3dca396c3db448bf32d814565acf3d11f
Diffstat (limited to 'src/compiler/codegen/MethodBitcode.cc')
-rw-r--r--src/compiler/codegen/MethodBitcode.cc15
1 files changed, 1 insertions, 14 deletions
diff --git a/src/compiler/codegen/MethodBitcode.cc b/src/compiler/codegen/MethodBitcode.cc
index c50d74da59..682de7ad6a 100644
--- a/src/compiler/codegen/MethodBitcode.cc
+++ b/src/compiler/codegen/MethodBitcode.cc
@@ -2663,21 +2663,8 @@ void cvtArrayLength(CompilationUnit* cUnit, llvm::CallInst* callInst)
void cvtMoveException(CompilationUnit* cUnit, llvm::CallInst* callInst)
{
- DCHECK_EQ(callInst->getNumArgOperands(), 0U);
- int exOffset = Thread::ExceptionOffset().Int32Value();
RegLocation rlDest = getLoc(cUnit, callInst);
- RegLocation rlResult = oatEvalLoc(cUnit, rlDest, kCoreReg, true);
-#if defined(TARGET_X86)
- newLIR2(cUnit, kX86Mov32RT, rlResult.lowReg, exOffset);
- newLIR2(cUnit, kX86Mov32TI, exOffset, 0);
-#else
- int resetReg = oatAllocTemp(cUnit);
- loadWordDisp(cUnit, rSELF, exOffset, rlResult.lowReg);
- loadConstant(cUnit, resetReg, 0);
- storeWordDisp(cUnit, rSELF, exOffset, resetReg);
- oatFreeTemp(cUnit, resetReg);
-#endif
- storeValue(cUnit, rlDest, rlResult);
+ genMoveException(cUnit, rlDest);
}
void cvtSget(CompilationUnit* cUnit, llvm::CallInst* callInst, bool isWide,