verifier: Speed up failure recording.

Move the failure data to the `Arena` memory.

Test: m test-art-host-gtest
Test: testrunner.py --host --optimizing
Bug: 181943478
Change-Id: I92b503f366286c4ad73d1e0eacc815635c86c119

1 files changed, 11 insertions, 5 deletions

diff --git a/runtime/verifier/method_verifier.h b/runtime/verifier/method_verifier.h
index 13631850b7..36c033ab64 100644
--- a/runtime/verifier/method_verifier.h
+++ b/runtime/verifier/method_verifier.h
@@ -156,7 +156,7 @@ class MethodVerifier {
                                uint32_t api_level)
       REQUIRES_SHARED(Locks::mutator_lock_);
 
-  virtual ~MethodVerifier();
+  virtual ~MethodVerifier() {}
 
   const CodeItemDataAccessor& CodeItem() const {
     return code_item_accessor_;
@@ -331,10 +331,16 @@ class MethodVerifier {
   // Owned, but not unique_ptr since insn_flags_ are allocated in arenas.
   ArenaUniquePtr<InstructionFlags[]> insn_flags_;
 
-  // The types of any error that occurs.
-  std::vector<VerifyError> failures_;
-  // Error messages associated with failures.
-  std::vector<std::ostringstream*> failure_messages_;
+  // The types of any error that occurs and associated error messages.
+  using MessageOStream =
+      std::basic_ostringstream<char, std::char_traits<char>, ArenaAllocatorAdapter<char>>;
+  struct VerifyErrorAndMessage {
+    VerifyErrorAndMessage(VerifyError e, const std::string& location, ArenaAllocatorAdapter<char> a)
+        : error(e), message(location, std::ios_base::ate, a) {}
+    VerifyError error;
+    MessageOStream message;
+  };
+  ArenaList<VerifyErrorAndMessage> failures_;
 
   struct {
     // Is there a pending hard failure?