diff options
author | 2018-03-27 20:30:55 +0000 | |
---|---|---|
committer | 2018-03-27 22:36:09 +0000 | |
commit | 642e9d8249be5aff68022cabdc8ba576a57ff8d6 (patch) | |
tree | 1fa53cee639241bd3968997e55e38ed282235569 /runtime/thread.cc | |
parent | b939805d9d4b0957274c562fb8053512d04138b2 (diff) |
Revert "Revert "Revert "Add an option to disable native stack dumping on SIGQUIT."""
This reverts commit 74d25c9040dfd1e0985987eb38817e526878a3db.
Reason for revert: The original failing condition appears to be gone.
Bug: 74121887
Test: Ran 004-ThreadStress many times against the target.
Change-Id: Ie5bd050112e654a99bdfea7d6dd673882ca35567
Diffstat (limited to 'runtime/thread.cc')
-rw-r--r-- | runtime/thread.cc | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/runtime/thread.cc b/runtime/thread.cc index b13d8ec42a..50cf9e0bc4 100644 --- a/runtime/thread.cc +++ b/runtime/thread.cc @@ -1161,10 +1161,9 @@ void Thread::ShortDump(std::ostream& os) const { << "]"; } -void Thread::Dump(std::ostream& os, bool dump_native_stack, BacktraceMap* backtrace_map, - bool force_dump_stack) const { +void Thread::Dump(std::ostream& os, BacktraceMap* backtrace_map, bool force_dump_stack) const { DumpState(os); - DumpStack(os, dump_native_stack, backtrace_map, force_dump_stack); + DumpStack(os, backtrace_map, force_dump_stack); } mirror::String* Thread::GetThreadName() const { @@ -1968,10 +1967,7 @@ void Thread::DumpJavaStack(std::ostream& os, bool check_suspended, bool dump_loc } } -void Thread::DumpStack(std::ostream& os, - bool dump_native_stack, - BacktraceMap* backtrace_map, - bool force_dump_stack) const { +void Thread::DumpStack(std::ostream& os, BacktraceMap* backtrace_map, bool force_dump_stack) const { // TODO: we call this code when dying but may not have suspended the thread ourself. The // IsSuspended check is therefore racy with the use for dumping (normally we inhibit // the race with the thread_suspend_count_lock_). @@ -1984,7 +1980,7 @@ void Thread::DumpStack(std::ostream& os, } if (safe_to_dump || force_dump_stack) { // If we're currently in native code, dump that stack before dumping the managed stack. - if (dump_native_stack && (dump_for_abort || force_dump_stack || ShouldShowNativeStack(this))) { + if (dump_for_abort || force_dump_stack || ShouldShowNativeStack(this)) { DumpKernelStack(os, GetTid(), " kernel: ", false); ArtMethod* method = GetCurrentMethod(nullptr, |