diff options
| author | 2016-02-01 11:43:26 -0800 | |
|---|---|---|
| committer | 2016-02-02 10:56:01 -0800 | |
| commit | df187e4cc8b1b2dc6cb0043eb91d1dfd72cb490b (patch) | |
| tree | a2fbb7ec726c57311238eae04a395936b8709cbd /runtime/native/java_lang_Class.cc | |
| parent | 9f95ba750583735cff1f2921b8014099dd801734 (diff) | |
Revert "Revert "reflection: Add new 1.8 AnnotatedElement methods and tests""
This reverts commit 28a2a186537db9fc5a8492e36d9603b48854c04f.
Runtest failure has been fixed in I28c3707e38c1f69ea9d3660f68136f688122ac4e
Change-Id: I1749dc89b790d44b5e40bc8b20aa62885bda792b
Diffstat (limited to 'runtime/native/java_lang_Class.cc')
| -rw-r--r-- | runtime/native/java_lang_Class.cc | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/runtime/native/java_lang_Class.cc b/runtime/native/java_lang_Class.cc index 0ddd4a280c..a80585abca 100644 --- a/runtime/native/java_lang_Class.cc +++ b/runtime/native/java_lang_Class.cc @@ -469,14 +469,21 @@ static jobjectArray Class_getDeclaredMethodsUnchecked(JNIEnv* env, jobject javaT return soa.AddLocalReference<jobjectArray>(ret.Get()); } -static jobject Class_getDeclaredAnnotation(JNIEnv* env, jobject javaThis, jclass annotationType) { +static jobject Class_getDeclaredAnnotation(JNIEnv* env, jobject javaThis, jclass annotationClass) { ScopedFastNativeObjectAccess soa(env); StackHandleScope<2> hs(soa.Self()); Handle<mirror::Class> klass(hs.NewHandle(DecodeClass(soa, javaThis))); + + // Handle public contract to throw NPE if the "annotationClass" argument was null. + if (UNLIKELY(annotationClass == nullptr)) { + ThrowNullPointerException("annotationClass"); + return nullptr; + } + if (klass->IsProxyClass() || klass->GetDexCache() == nullptr) { return nullptr; } - Handle<mirror::Class> annotation_class(hs.NewHandle(soa.Decode<mirror::Class*>(annotationType))); + Handle<mirror::Class> annotation_class(hs.NewHandle(soa.Decode<mirror::Class*>(annotationClass))); return soa.AddLocalReference<jobject>( klass->GetDexFile().GetAnnotationForClass(klass, annotation_class)); } |