diff options
| author | 2020-05-05 10:07:59 +0100 | |
|---|---|---|
| committer | 2020-05-05 13:34:31 +0000 | |
| commit | d34b73b4ac478462acc03c4cd42ae7568c832eb8 (patch) | |
| tree | 27f1c4599178ba57451c29d0156c232768711b6d /runtime/native/dalvik_system_VMStack.cc | |
| parent | 4a48775376a4c0b180a7d32ad2cdf00bd0dca140 (diff) | |
Clean up internal stack trace construction.
Simplify the code by ignoring active transactions. Writing
to fields of a newly allocated object does not need to be
recorded as aborting the transaction removes all references
to the new object and it's unnecessary to roll back writes
to unreachable object's fields.
Test: m test-art-host-gtest
Test: testrunner.py --host --optimizing
Test: aosp_taimen-userdebug boots.
Change-Id: Ia91d3274398b0ca0f5b0040dcf323921d915b657
Diffstat (limited to 'runtime/native/dalvik_system_VMStack.cc')
| -rw-r--r-- | runtime/native/dalvik_system_VMStack.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/runtime/native/dalvik_system_VMStack.cc b/runtime/native/dalvik_system_VMStack.cc index 32733a8409..9d2dfac069 100644 --- a/runtime/native/dalvik_system_VMStack.cc +++ b/runtime/native/dalvik_system_VMStack.cc @@ -84,7 +84,7 @@ static jint VMStack_fillStackTraceElements(JNIEnv* env, jclass, jobject javaThre ScopedFastNativeObjectAccess soa(env); auto fn = [](Thread* thread, const ScopedFastNativeObjectAccess& soaa) REQUIRES_SHARED(Locks::mutator_lock_) -> jobject { - return thread->CreateInternalStackTrace<false>(soaa); + return thread->CreateInternalStackTrace(soaa); }; jobject trace = GetThreadStack(soa, javaThread, fn); if (trace == nullptr) { @@ -151,7 +151,7 @@ static jobjectArray VMStack_getThreadStackTrace(JNIEnv* env, jclass, jobject jav ScopedFastNativeObjectAccess soa(env); auto fn = [](Thread* thread, const ScopedFastNativeObjectAccess& soaa) REQUIRES_SHARED(Locks::mutator_lock_) -> jobject { - return thread->CreateInternalStackTrace<false>(soaa); + return thread->CreateInternalStackTrace(soaa); }; jobject trace = GetThreadStack(soa, javaThread, fn); if (trace == nullptr) { |