diff options
author | 2019-08-13 10:50:38 -0700 | |
---|---|---|
committer | 2019-09-17 23:52:12 +0000 | |
commit | c971eafeff43e4e26959a6e86b62ab0a8f1a6e1c (patch) | |
tree | f8647487e7465712fd73118ceb89e13167a12648 /runtime/mirror/var_handle-inl.h | |
parent | 1ba7e8c10af4e270864a417044244d63db53ccf5 (diff) |
Basic structural redefinition support
This adds basic support for adding methods and fields to already
loaded classes using redefinition. This 'structural class
redefinition' is currently limited to classes without any virtual
methods or instance fields. One cannot currently structurally redefine
multiple classes at once nor will structural redefinition trigger the
standard redefinition events.
After structural redefinition all references to the old class, and its
fields and methods are atomically updated. Any memory associated with
the static fields of the old class is zeroed. Offsets for field access
might change. If there are any active stack frames for methods from
the redefined class the original (obsolete method) code will continue
to execute. The identity hash code of the redefined class will not
change. Any locks being held, waited or blocked on by the old class
will be transferred to the new class.
To use this feature the process must be debuggable and running with
-Xopaque-jni-ids:true.
For device testing use a wrap.sh that adds the following flags:
'-Xopaque-jni-ids:true -Xcompiler-option --debuggable -XjdwpProvider:adbconnection'
Structural redefinition only available using the
"com.android.art.UNSAFE.class.structurally_redefine_class_direct"
extension. This will not trigger the normal class-redefinition events.
Only one class may be redefined at a time.
NB There are still some holes in this potentially allowing obsolete
methods/fields to be visible. Most notably during jni-id, MethodHandle
and VarHandle creation as well as potentially other places in the
runtime. These holes will be closed by later CLs. Until then the
extension to access structural class redefinition will remain tagged
as UNSAFE.
Test: ./test.py --host --all-compiler
Bug: 134162467
Change-Id: I825d3a4bdb9594c0147223ae69f433ce9bbfc307
Diffstat (limited to 'runtime/mirror/var_handle-inl.h')
-rw-r--r-- | runtime/mirror/var_handle-inl.h | 40 |
1 files changed, 40 insertions, 0 deletions
diff --git a/runtime/mirror/var_handle-inl.h b/runtime/mirror/var_handle-inl.h new file mode 100644 index 0000000000..d3f582d04e --- /dev/null +++ b/runtime/mirror/var_handle-inl.h @@ -0,0 +1,40 @@ +/* + * Copyright (C) 2019 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#ifndef ART_RUNTIME_MIRROR_VAR_HANDLE_INL_H_ +#define ART_RUNTIME_MIRROR_VAR_HANDLE_INL_H_ + +#include "var_handle.h" + +namespace art { +class ArtField; + +namespace mirror { + +template<typename Visitor> +inline void FieldVarHandle::VisitTarget(Visitor&& v) { + ArtField* orig = GetField(); + ArtField* new_value = v(orig); + if (orig != new_value) { + SetField64</*kTransactionActive*/ false>(ArtFieldOffset(), + reinterpret_cast<uintptr_t>(new_value)); + } +} + +} // namespace mirror +} // namespace art + +#endif // ART_RUNTIME_MIRROR_VAR_HANDLE_INL_H_ |