diff options
| author | 2019-05-28 16:39:29 +0100 | |
|---|---|---|
| committer | 2019-05-31 14:15:59 +0000 | |
| commit | 3068d582eff4552ff260d7966fcbdc93e17d0207 (patch) | |
| tree | bc894a414070a06ea2a231fb98607b57b8c3b0cb /runtime/mirror/string.h | |
| parent | 991cd5cc16267b74e390f640eb441102062babb6 (diff) | |
Clean up creating handles from `this`.
Make these member functions static and take an additional
parameter `Handle<.> h_this`. Callers mostly already have
a Handle<> to pass, so we avoid an extra StackHandleScope.
This pattern was already used for some functions.
Test: m test-art-host-gtest
Test: testrunner.py --host --optimizing --interpreter
Change-Id: I4f4478b0526bcb2f3c23305d3b3cc4a65fff9ff5
Diffstat (limited to 'runtime/mirror/string.h')
| -rw-r--r-- | runtime/mirror/string.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/runtime/mirror/string.h b/runtime/mirror/string.h index 116ecd1cab..0e3c500ca5 100644 --- a/runtime/mirror/string.h +++ b/runtime/mirror/string.h @@ -187,7 +187,8 @@ class MANAGED String final : public Object { int32_t CompareTo(ObjPtr<String> other) REQUIRES_SHARED(Locks::mutator_lock_); - ObjPtr<CharArray> ToCharArray(Thread* self) REQUIRES_SHARED(Locks::mutator_lock_) + static ObjPtr<CharArray> ToCharArray(Handle<String> h_this, Thread* self) + REQUIRES_SHARED(Locks::mutator_lock_) REQUIRES(!Roles::uninterruptible_); void GetChars(int32_t start, int32_t end, Handle<CharArray> array, int32_t index) |