diff options
author | 2021-02-15 21:23:00 +0000 | |
---|---|---|
committer | 2021-02-18 16:51:21 +0000 | |
commit | 5de5efef38f52f248d1e1c88fdcf3d211aabe712 (patch) | |
tree | fb991b4dbee4d9afecad141bc75dab14893633a1 /runtime/mirror/dex_cache-inl.h | |
parent | 18af6447e5963265f6e7e61d6630064f66891f94 (diff) |
Remove pointer-size arguments from DexCache.
The DexCache is always allocated at runtime now and thus
it always has runtime pointer-size. Remove the dead code.
Test: m test-art-host-gtest
Change-Id: Ic21dc20649e1fd70f8981602d75b5690065aec20
Diffstat (limited to 'runtime/mirror/dex_cache-inl.h')
-rw-r--r-- | runtime/mirror/dex_cache-inl.h | 39 |
1 files changed, 15 insertions, 24 deletions
diff --git a/runtime/mirror/dex_cache-inl.h b/runtime/mirror/dex_cache-inl.h index 7736f47066..1ca42024f4 100644 --- a/runtime/mirror/dex_cache-inl.h +++ b/runtime/mirror/dex_cache-inl.h @@ -63,12 +63,11 @@ inline T* DexCachePair<T>::GetObjectForIndex(uint32_t idx) { } template <typename T> -inline void NativeDexCachePair<T>::Initialize(std::atomic<NativeDexCachePair<T>>* dex_cache, - PointerSize pointer_size) { +inline void NativeDexCachePair<T>::Initialize(std::atomic<NativeDexCachePair<T>>* dex_cache) { NativeDexCachePair<T> first_elem; first_elem.object = nullptr; first_elem.index = InvalidIndexForSlot(0); - DexCache::SetNativePairPtrSize(dex_cache, 0, first_elem, pointer_size); + DexCache::SetNativePair(dex_cache, 0, first_elem); } inline uint32_t DexCache::ClassSize(PointerSize pointer_size) { @@ -244,17 +243,15 @@ inline uint32_t DexCache::FieldSlotIndex(uint32_t field_idx) { return slot_idx; } -inline ArtField* DexCache::GetResolvedField(uint32_t field_idx, PointerSize ptr_size) { - DCHECK_EQ(Runtime::Current()->GetClassLinker()->GetImagePointerSize(), ptr_size); - auto pair = GetNativePairPtrSize(GetResolvedFields(), FieldSlotIndex(field_idx), ptr_size); +inline ArtField* DexCache::GetResolvedField(uint32_t field_idx) { + auto pair = GetNativePair(GetResolvedFields(), FieldSlotIndex(field_idx)); return pair.GetObjectForIndex(field_idx); } -inline void DexCache::SetResolvedField(uint32_t field_idx, ArtField* field, PointerSize ptr_size) { - DCHECK_EQ(Runtime::Current()->GetClassLinker()->GetImagePointerSize(), ptr_size); +inline void DexCache::SetResolvedField(uint32_t field_idx, ArtField* field) { DCHECK(field != nullptr); FieldDexCachePair pair(field, field_idx); - SetNativePairPtrSize(GetResolvedFields(), FieldSlotIndex(field_idx), pair, ptr_size); + SetNativePair(GetResolvedFields(), FieldSlotIndex(field_idx), pair); } inline uint32_t DexCache::MethodSlotIndex(uint32_t method_idx) { @@ -264,25 +261,20 @@ inline uint32_t DexCache::MethodSlotIndex(uint32_t method_idx) { return slot_idx; } -inline ArtMethod* DexCache::GetResolvedMethod(uint32_t method_idx, PointerSize ptr_size) { - DCHECK_EQ(Runtime::Current()->GetClassLinker()->GetImagePointerSize(), ptr_size); - auto pair = GetNativePairPtrSize(GetResolvedMethods(), MethodSlotIndex(method_idx), ptr_size); +inline ArtMethod* DexCache::GetResolvedMethod(uint32_t method_idx) { + auto pair = GetNativePair(GetResolvedMethods(), MethodSlotIndex(method_idx)); return pair.GetObjectForIndex(method_idx); } -inline void DexCache::SetResolvedMethod(uint32_t method_idx, - ArtMethod* method, - PointerSize ptr_size) { - DCHECK_EQ(Runtime::Current()->GetClassLinker()->GetImagePointerSize(), ptr_size); +inline void DexCache::SetResolvedMethod(uint32_t method_idx, ArtMethod* method) { DCHECK(method != nullptr); MethodDexCachePair pair(method, method_idx); - SetNativePairPtrSize(GetResolvedMethods(), MethodSlotIndex(method_idx), pair, ptr_size); + SetNativePair(GetResolvedMethods(), MethodSlotIndex(method_idx), pair); } template <typename T> -NativeDexCachePair<T> DexCache::GetNativePairPtrSize(std::atomic<NativeDexCachePair<T>>* pair_array, - size_t idx, - PointerSize ptr_size ATTRIBUTE_UNUSED) { +NativeDexCachePair<T> DexCache::GetNativePair(std::atomic<NativeDexCachePair<T>>* pair_array, + size_t idx) { if (kRuntimePointerSize == PointerSize::k64) { auto* array = reinterpret_cast<std::atomic<ConversionPair64>*>(pair_array); ConversionPair64 value = AtomicLoadRelaxed16B(&array[idx]); @@ -296,10 +288,9 @@ NativeDexCachePair<T> DexCache::GetNativePairPtrSize(std::atomic<NativeDexCacheP } template <typename T> -void DexCache::SetNativePairPtrSize(std::atomic<NativeDexCachePair<T>>* pair_array, - size_t idx, - NativeDexCachePair<T> pair, - PointerSize ptr_size ATTRIBUTE_UNUSED) { +void DexCache::SetNativePair(std::atomic<NativeDexCachePair<T>>* pair_array, + size_t idx, + NativeDexCachePair<T> pair) { if (kRuntimePointerSize == PointerSize::k64) { auto* array = reinterpret_cast<std::atomic<ConversionPair64>*>(pair_array); ConversionPair64 v(reinterpret_cast64<uint64_t>(pair.object), pair.index); |