summaryrefslogtreecommitdiff
path: root/runtime/mirror/class_ext.cc
diff options
context:
space:
mode:
author Alex Light <allight@google.com> 2016-12-02 17:27:31 -0800
committer Alex Light <allight@google.com> 2016-12-05 08:57:54 -0800
commit0b772575fcf3b93896a71ceb524329f867899c75 (patch)
tree90630dac067ed92fe1b2169af627c1d1df44c2b9 /runtime/mirror/class_ext.cc
parent0fd9a7d67878d1d88a74895c0d02c556b5de8e72 (diff)
Address comments I missed on a previous CL
I accidentally missed some comments on android-review.googlesource.com/c/305518 when I submitted it. This addresses those comments. Test: mma -j40 test-art-host Change-Id: Icd8ff65dee1730d10489f25e75bddbd455c68413
Diffstat (limited to 'runtime/mirror/class_ext.cc')
-rw-r--r--runtime/mirror/class_ext.cc5
1 files changed, 3 insertions, 2 deletions
diff --git a/runtime/mirror/class_ext.cc b/runtime/mirror/class_ext.cc
index 259bbbe174..7c6a710cef 100644
--- a/runtime/mirror/class_ext.cc
+++ b/runtime/mirror/class_ext.cc
@@ -46,8 +46,9 @@ void ClassExt::SetObsoleteArrays(ObjPtr<PointerArray> methods,
SetFieldObject<false>(obsolete_methods_off, methods.Ptr());
}
-// TODO We really need to be careful how we update this. If we ever in the future make it so that
-// these arrays are written into without all threads being suspended we have a race condition!
+// We really need to be careful how we update this. If we ever in the future make it so that
+// these arrays are written into without all threads being suspended we have a race condition! This
+// race could cause obsolete methods to be missed.
bool ClassExt::ExtendObsoleteArrays(Thread* self, uint32_t increase) {
DCHECK_EQ(GetLockOwnerThreadId(), Thread::Current()->GetThreadId())
<< "Obsolete arrays are set without synchronization!";