diff options
author | 2024-01-05 14:45:44 +0000 | |
---|---|---|
committer | 2024-01-17 12:10:02 +0000 | |
commit | a1e314b375a81f4dc75f149baaadf26798fb5775 (patch) | |
tree | 9edf633d088c14a042add75168ceaa602cbccffd /runtime/gc/reference_queue.cc | |
parent | 0d088da1de83025cd0e078da3a4ec2a721bb8361 (diff) |
Change `DexUseManager.getFilteredDetailedSecondaryDexInfo`.
- Avoid using the word "detailed" because it was overloaded in ART
Service when describing dex info: for primary dex, it means the info
contains CLC, but for secondary dex, it means the info contains file
visibility, while CLC is always there no matter the info is "detailed"
or not. Instead, use the word "checked" for info that contains file
visibility.
- Change the signature to make filtering optional, so that it can be
reused in DumpHelper.
- Remove the filtering on loaders based on file visibility. It not only
added unnecessary complexity in the method itself, but also prevented
DumpHelper from reusing the method. It can also be surprising when the
method is used by others in the future as this behavior is subtle and
not well-documented. This is the only behavior change in this CL. In
real CUJs, this change should have almost no impact because this
method is only used by the file GC and secondary dexopter, both of
which are mostly run during the bg dexopt job, and the job calls
`DexUseManagerLocal.cleanup` at the very begining to prune dex use
info including loaders, making the filtering on loaders unlikely to
have any effect.
Bug: 317081212
Test: atest ArtServiceTests
Change-Id: Ie025c232c13b6b1baaefc4e0eeb486f47123926b
Diffstat (limited to 'runtime/gc/reference_queue.cc')
0 files changed, 0 insertions, 0 deletions