summaryrefslogtreecommitdiff
path: root/runtime/gc/reference_processor.h
diff options
context:
space:
mode:
author Hans Boehm <hboehm@google.com> 2021-08-07 19:44:20 +0000
committer Hans Boehm <hboehm@google.com> 2021-08-07 19:44:20 +0000
commitf955425d11ed4b8f6dc02530f0f5ab69edecd8d2 (patch)
tree9f81ffa70d28a9021209bf508a052023e7495e2a /runtime/gc/reference_processor.h
parent0c3cc6350749a441fd54f8f3f67b7c69775000c8 (diff)
Revert "Handle suspend requests in getReferent()"
This reverts commit 0c3cc6350749a441fd54f8f3f67b7c69775000c8. Reason for revert: Seems to break tests, e.g. https://ci.chromium.org/ui/p/art/builders/ci/host-x86-cms/6824/overview Change-Id: Id75641d28be218055eca07c99ab2e1bfd579fe71
Diffstat (limited to 'runtime/gc/reference_processor.h')
-rw-r--r--runtime/gc/reference_processor.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/runtime/gc/reference_processor.h b/runtime/gc/reference_processor.h
index 8ea7bb1297..54de5cc572 100644
--- a/runtime/gc/reference_processor.h
+++ b/runtime/gc/reference_processor.h
@@ -58,7 +58,7 @@ class ReferenceProcessor {
// GetReferent fast path as an optimization.
void EnableSlowPath() REQUIRES_SHARED(Locks::mutator_lock_);
void BroadcastForSlowPath(Thread* self);
- // Decode the referent, may block and allow suspension if references are being processed.
+ // Decode the referent, may block if references are being processed.
ObjPtr<mirror::Object> GetReferent(Thread* self, ObjPtr<mirror::Reference> reference)
REQUIRES_SHARED(Locks::mutator_lock_) REQUIRES(!Locks::reference_processor_lock_);
// Collects the cleared references and returns a task, to be executed after FinishGC, that will
@@ -89,7 +89,7 @@ class ReferenceProcessor {
// referents.
void StartPreservingReferences(Thread* self) REQUIRES(!Locks::reference_processor_lock_);
void StopPreservingReferences(Thread* self) REQUIRES(!Locks::reference_processor_lock_);
- // Wait until reference processing is done. May temporarily release both required locks.
+ // Wait until reference processing is done.
void WaitUntilDoneProcessingReferences(Thread* self)
REQUIRES_SHARED(Locks::mutator_lock_)
REQUIRES(Locks::reference_processor_lock_);