diff options
author | 2019-04-01 10:57:55 +0100 | |
---|---|---|
committer | 2019-04-02 07:57:27 +0000 | |
commit | dfc0de7696a50a9aeee95dcf74dac036e3334314 (patch) | |
tree | 20a6edd33cca852f8e65ce8d20a85949b566904c /runtime/class_linker_test.cc | |
parent | 9ef308da0ea8d1df2edf65d4957599fafcc56aeb (diff) |
Partially ObjPtr<>-ify Object, fix stale ref in test.
Test: m test-art-host-gtest
Test: testrunner.py --host --optimizing
Bug: 31113334
Change-Id: I0c0bc669c0ab8d99185e662a2fec16f32a42a0a2
Diffstat (limited to 'runtime/class_linker_test.cc')
-rw-r--r-- | runtime/class_linker_test.cc | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/runtime/class_linker_test.cc b/runtime/class_linker_test.cc index a9343e9aec..1a91abe1ed 100644 --- a/runtime/class_linker_test.cc +++ b/runtime/class_linker_test.cc @@ -85,7 +85,7 @@ class ClassLinkerTest : public CommonRuntimeTest { REQUIRES_SHARED(Locks::mutator_lock_) { ASSERT_TRUE(primitive != nullptr); ASSERT_TRUE(primitive->GetClass() != nullptr); - ASSERT_EQ(primitive->GetClass(), primitive->GetClass()->GetClass()); + ASSERT_OBJ_PTR_EQ(primitive->GetClass(), primitive->GetClass()->GetClass()); EXPECT_TRUE(primitive->GetClass()->GetSuperClass() != nullptr); std::string temp; ASSERT_STREQ(descriptor.c_str(), primitive->GetDescriptor(&temp)); @@ -124,8 +124,7 @@ class ClassLinkerTest : public CommonRuntimeTest { REQUIRES_SHARED(Locks::mutator_lock_) { ASSERT_TRUE(JavaLangObject != nullptr); ASSERT_TRUE(JavaLangObject->GetClass() != nullptr); - ASSERT_EQ(JavaLangObject->GetClass(), - JavaLangObject->GetClass()->GetClass()); + ASSERT_OBJ_PTR_EQ(JavaLangObject->GetClass(), JavaLangObject->GetClass()->GetClass()); EXPECT_OBJ_PTR_EQ(JavaLangObject, JavaLangObject->GetClass()->GetSuperClass()); std::string temp; ASSERT_STREQ(JavaLangObject->GetDescriptor(&temp), "Ljava/lang/Object;"); @@ -197,7 +196,7 @@ class ClassLinkerTest : public CommonRuntimeTest { REQUIRES_SHARED(Locks::mutator_lock_) { ASSERT_TRUE(array != nullptr); ASSERT_TRUE(array->GetClass() != nullptr); - ASSERT_EQ(array->GetClass(), array->GetClass()->GetClass()); + ASSERT_OBJ_PTR_EQ(array->GetClass(), array->GetClass()->GetClass()); EXPECT_TRUE(array->GetClass()->GetSuperClass() != nullptr); std::string temp; ASSERT_STREQ(array_descriptor.c_str(), array->GetDescriptor(&temp)); @@ -274,7 +273,7 @@ class ClassLinkerTest : public CommonRuntimeTest { EXPECT_TRUE(klass->GetSuperClass() != nullptr); } EXPECT_TRUE(klass->GetClass() != nullptr); - EXPECT_EQ(klass->GetClass(), klass->GetClass()->GetClass()); + EXPECT_OBJ_PTR_EQ(klass->GetClass(), klass->GetClass()->GetClass()); EXPECT_TRUE(klass->GetDexCache() != nullptr); EXPECT_TRUE(klass->IsLoaded()); EXPECT_TRUE(klass->IsResolved()); @@ -927,7 +926,7 @@ TEST_F(ClassLinkerTest, FindClass) { ObjPtr<mirror::Class> MyClass = class_linker_->FindClass(soa.Self(), "LMyClass;", class_loader); ASSERT_TRUE(MyClass != nullptr); ASSERT_TRUE(MyClass->GetClass() != nullptr); - ASSERT_EQ(MyClass->GetClass(), MyClass->GetClass()->GetClass()); + ASSERT_OBJ_PTR_EQ(MyClass->GetClass(), MyClass->GetClass()->GetClass()); EXPECT_OBJ_PTR_EQ(JavaLangObject.Get(), MyClass->GetClass()->GetSuperClass()); std::string temp; ASSERT_STREQ(MyClass->GetDescriptor(&temp), "LMyClass;"); @@ -955,7 +954,7 @@ TEST_F(ClassLinkerTest, FindClass) { EXPECT_EQ(0U, MyClass->NumStaticFields()); EXPECT_EQ(0U, MyClass->NumDirectInterfaces()); - EXPECT_EQ(JavaLangObject->GetClass()->GetClass(), MyClass->GetClass()->GetClass()); + EXPECT_OBJ_PTR_EQ(JavaLangObject->GetClass()->GetClass(), MyClass->GetClass()->GetClass()); // created by class_linker AssertArrayClass("[C", "C", nullptr); |