summaryrefslogtreecommitdiff
path: root/openjdkjvmti/ti_thread.h
diff options
context:
space:
mode:
author Alex Light <allight@google.com> 2017-10-31 22:28:11 +0000
committer Alex Light <allight@google.com> 2017-10-31 22:28:11 +0000
commite5179ce0ca8becf34ba6e7b2f3988874fe647c26 (patch)
tree6d1bad18374493e2e85f715a575dea65f1725317 /openjdkjvmti/ti_thread.h
parent7585b91bfc77b8e4b821ccfa716fa86e46455275 (diff)
Revert "Prevent races with GC when transferring objects between threads"
This reverts commit 7585b91bfc77b8e4b821ccfa716fa86e46455275. Reason for revert: Seems to be causing fatal error: Checkpoint flag set without pending checkpoint Change-Id: I98ea653e629d73e854907115583afed3ed5ac68e Test: None. Bug: 67838964
Diffstat (limited to 'openjdkjvmti/ti_thread.h')
-rw-r--r--openjdkjvmti/ti_thread.h11
1 files changed, 0 insertions, 11 deletions
diff --git a/openjdkjvmti/ti_thread.h b/openjdkjvmti/ti_thread.h
index 341bffe51e..09b4cabcfc 100644
--- a/openjdkjvmti/ti_thread.h
+++ b/openjdkjvmti/ti_thread.h
@@ -42,7 +42,6 @@ namespace art {
class ArtField;
class ScopedObjectAccessAlreadyRunnable;
class Thread;
-class Closure;
} // namespace art
namespace openjdkjvmti {
@@ -134,16 +133,6 @@ class ThreadUtil {
REQUIRES(!art::Locks::user_code_suspension_lock_,
!art::Locks::thread_suspend_count_lock_);
- // This will request a synchronous checkpoint in such a way as to prevent gc races if a local
- // variable is taken from one thread's stack and placed in the stack of another thread.
- // RequestSynchronousCheckpoint releases the thread_list_lock_ as a part of its execution. This is
- // due to the fact that Thread::Current() needs to go to sleep to allow the targeted thread to
- // execute the checkpoint for us if it is Runnable.
- static bool RequestGCSafeSynchronousCheckpoint(art::Thread* thr, art::Closure* function)
- REQUIRES_SHARED(art::Locks::mutator_lock_)
- RELEASE(art::Locks::thread_list_lock_)
- REQUIRES(!art::Locks::thread_suspend_count_lock_);
-
private:
// We need to make sure only one thread tries to suspend threads at a time so we can get the
// 'suspend-only-once' behavior the spec requires. Internally, ART considers suspension to be a