diff options
| author | 2017-08-17 11:12:06 -0700 | |
|---|---|---|
| committer | 2017-08-21 11:11:30 -0700 | |
| commit | 1d8a9741d2979d09a21942fbf9107d212ce2511b (patch) | |
| tree | d630dccfbe632247f04a0428f8a72766c3b673fe /openjdkjvmti/ti_thread.h | |
| parent | bf9e516f4964ee900d2996abaf60977c1c643aa3 (diff) | |
Fix interaction of VMInit and ThreadStart events.
Real world agents require that one is able to create, and run, new
threads while the VMInit event is still being executed. Further, these
require that ThreadStart events can occur concurrently with the VMInit
event. This CL enables this behavior and adds a test for the
interaction of these two events.
Test: ./test.py --host -j50
Bug: 62821960
Bug: 34415266
Change-Id: I305f1ce3f1df9bf5a7e33027e0724f5fbac5c0f1
Diffstat (limited to 'openjdkjvmti/ti_thread.h')
| -rw-r--r-- | openjdkjvmti/ti_thread.h | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/openjdkjvmti/ti_thread.h b/openjdkjvmti/ti_thread.h index 03c49d7788..a19974aa16 100644 --- a/openjdkjvmti/ti_thread.h +++ b/openjdkjvmti/ti_thread.h @@ -53,9 +53,14 @@ class ThreadUtil { static void Register(EventHandler* event_handler); static void Unregister(); - // To be called when it is safe to cache data. + // To be called when it is safe to cache data. This means that we have at least entered the + // RuntimePhase::kInit but we might or might not have already called VMInit event. static void CacheData(); + // Called just after we have sent the VMInit callback so that ThreadUtil can do final setup. This + // ensures that there are no timing issues between the two callbacks. + static void VMInitEventSent() REQUIRES_SHARED(art::Locks::mutator_lock_); + // Handle a jvmtiEnv going away. static void RemoveEnvironment(jvmtiEnv* env); |