summaryrefslogtreecommitdiff
path: root/libdexfile/dex/proto_reference.h
diff options
context:
space:
mode:
author Vladimir Marko <vmarko@google.com> 2024-05-10 14:44:09 +0200
committer VladimĂ­r Marko <vmarko@google.com> 2024-05-13 12:18:14 +0000
commit8ad286a19ba206224072fb84b0bd599c5d25cdbe (patch)
tree5dc59770fb60d3cafda0d7a5608fe9f84a794e73 /libdexfile/dex/proto_reference.h
parentffc0d1f69841fe4dcc8dca0676fb13466b9b8132 (diff)
Clean up descriptor and member name comparisons.
Add helper functions for these comparisons to keep comments related to ordering in one place. Test: m test-art-host-gtest Test: testrunner.py --host --optimizing Change-Id: I510a1cbbb46a22ddbd39d0530198cd004b476a8d
Diffstat (limited to 'libdexfile/dex/proto_reference.h')
-rw-r--r--libdexfile/dex/proto_reference.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/libdexfile/dex/proto_reference.h b/libdexfile/dex/proto_reference.h
index dc9a447e63..a12091cc46 100644
--- a/libdexfile/dex/proto_reference.h
+++ b/libdexfile/dex/proto_reference.h
@@ -62,7 +62,7 @@ struct ProtoReferenceValueComparator {
// Compare return type first.
const dex::ProtoId& prid1 = lhs.ProtoId();
const dex::ProtoId& prid2 = rhs.ProtoId();
- int return_type_diff = lhs.ReturnType().compare(rhs.ReturnType());
+ int return_type_diff = DexFile::CompareDescriptors(lhs.ReturnType(), rhs.ReturnType());
if (return_type_diff != 0) {
return return_type_diff < 0;
}
@@ -77,7 +77,7 @@ struct ProtoReferenceValueComparator {
std::string_view r_param = rhs.dex_file->GetTypeDescriptorView(
rhs.dex_file->GetTypeId(params2->GetTypeItem(i).type_idx_));
- int param_diff = l_param.compare(r_param);
+ int param_diff = DexFile::CompareDescriptors(l_param, r_param);
if (param_diff != 0) {
return param_diff < 0;
}