diff options
author | 2018-10-11 11:11:13 -0700 | |
---|---|---|
committer | 2018-10-17 12:17:28 -0700 | |
commit | 0de385f9eb5f8c066121ea2d43e8b8eea6a726fa (patch) | |
tree | 918bee18727b0a8de4332db161d457c4241939b4 /libdexfile/dex/dex_instruction_test.cc | |
parent | 21ff4ad92e8d74cfe8d95ec64b177d47084ec374 (diff) |
ART: Refactor for bugprone-argument-comment
Handles libartbase, libdexfile and libprofile.
Bug: 116054210
Test: WITH_TIDY=1 mmma art
Change-Id: Ibeee2446e2978af45402d9ca47c75ffc438de316
Diffstat (limited to 'libdexfile/dex/dex_instruction_test.cc')
-rw-r--r-- | libdexfile/dex/dex_instruction_test.cc | 18 |
1 files changed, 12 insertions, 6 deletions
diff --git a/libdexfile/dex/dex_instruction_test.cc b/libdexfile/dex/dex_instruction_test.cc index 6ce9dbafc8..02400f4a14 100644 --- a/libdexfile/dex/dex_instruction_test.cc +++ b/libdexfile/dex/dex_instruction_test.cc @@ -71,10 +71,13 @@ static void Build4rcc(uint16_t num_args, uint16_t method_idx, uint16_t proto_idx TEST(Instruction, PropertiesOf45cc) { uint16_t instruction[4]; - Build45cc(4u /* num_vregs */, 16u /* method_idx */, 32u /* proto_idx */, - 0xcafe /* arg_regs */, instruction); + Build45cc(/* num_args= */ 4u, + /* method_idx= */ 16u, + /* proto_idx= */ 32u, + /* arg_regs= */ 0xcafe, + instruction); - DexInstructionIterator ins(instruction, /*dex_pc*/ 0u); + DexInstructionIterator ins(instruction, /*dex_pc=*/ 0u); ASSERT_EQ(4u, ins->SizeInCodeUnits()); ASSERT_TRUE(ins->HasVRegA()); @@ -106,10 +109,13 @@ TEST(Instruction, PropertiesOf45cc) { TEST(Instruction, PropertiesOf4rcc) { uint16_t instruction[4]; - Build4rcc(4u /* num_vregs */, 16u /* method_idx */, 32u /* proto_idx */, - 0xcafe /* arg_regs */, instruction); + Build4rcc(/* num_args= */ 4u, + /* method_idx= */ 16u, + /* proto_idx= */ 32u, + /* arg_regs_start= */ 0xcafe, + instruction); - DexInstructionIterator ins(instruction, /*dex_pc*/ 0u); + DexInstructionIterator ins(instruction, /*dex_pc=*/ 0u); ASSERT_EQ(4u, ins->SizeInCodeUnits()); ASSERT_TRUE(ins->HasVRegA()); |