diff options
| author | 2020-05-13 17:08:43 +0000 | |
|---|---|---|
| committer | 2020-05-13 19:34:11 +0000 | |
| commit | 58520dfba31d6eeef75f5babff15e09aa28e5db8 (patch) | |
| tree | eb09e871c318fa9a01923e9afd31f70bdbb5e468 /libartbase/base/utils.h | |
| parent | bc89ed42d6128c27819e5403f6ceca5c18892e23 (diff) | |
Revert "Use MADV_FREE to reclaim pages of freed regions"
This reverts commit 315f1b21a51a67e5d9c9ec3a04f1887931061e10.
Reason for revert: Regression in PSS (b/155678984). Also MPTS test report a low hit ratio (20%), which doesn't justify the change, at least in the current format. A workaround will be to bring back marking pages back and only madv_free first few regions which are expected to be allocated soon. The rest of the regions should probably be reclaimed with MADV_DONTNEED. Also, for a GC happening when the app is in background should probably reclaim all regions with MADV_DONTNEED.
Test: art/test/testrunner/testrunner.py
Bug: 155678984
Bug: 74447417
Bug: 140130889
Change-Id: I3c4bc4648a3b12062957a51ee716742eb9944747
Diffstat (limited to 'libartbase/base/utils.h')
| -rw-r--r-- | libartbase/base/utils.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/libartbase/base/utils.h b/libartbase/base/utils.h index 1fe465c81f..4bcb9151b7 100644 --- a/libartbase/base/utils.h +++ b/libartbase/base/utils.h @@ -42,9 +42,6 @@ static inline uint32_t PointerToLowMemUInt32(const void* p) { // Returns a human-readable size string such as "1MB". std::string PrettySize(int64_t size_in_bytes); -// Returns true if the kernel's version (based on uname) is lower than required. -bool KernelVersionLower(int required_major, int required_minor); - // Splits a string using the given separator character into a vector of // strings. Empty strings will be omitted. void Split(const std::string& s, char separator, std::vector<std::string>* result); |