diff options
| author | 2023-05-16 10:32:54 +0000 | |
|---|---|---|
| committer | 2023-05-22 10:36:39 +0000 | |
| commit | 78f3c72e8948087352788997a70854dee613352c (patch) | |
| tree | 306db3c15bc4b7af149bcf3e07be533e50679b88 /libartbase/base/metrics/metrics_test.cc | |
| parent | dc771261232c2ff702373f396a5a7fe586e2f0a6 (diff) | |
Use C++17's [[maybe_unused]] attribute in ART
Bug: 169680875
Test: mmm art
Change-Id: Ic0cc320891c42b07a2b5520a584d2b62052e7235
Diffstat (limited to 'libartbase/base/metrics/metrics_test.cc')
| -rw-r--r-- | libartbase/base/metrics/metrics_test.cc | 30 |
1 files changed, 15 insertions, 15 deletions
diff --git a/libartbase/base/metrics/metrics_test.cc b/libartbase/base/metrics/metrics_test.cc index 2d69c95b69..61dfddd273 100644 --- a/libartbase/base/metrics/metrics_test.cc +++ b/libartbase/base/metrics/metrics_test.cc @@ -272,13 +272,13 @@ TEST_F(MetricsTest, ResetMetrics) { class NonZeroBackend : public TestBackendBase { public: - void ReportCounter(DatumId counter_type [[maybe_unused]], uint64_t value) override { + void ReportCounter([[maybe_unused]] DatumId counter_type, uint64_t value) override { EXPECT_NE(value, 0u); } - void ReportHistogram(DatumId histogram_type [[maybe_unused]], - int64_t minimum_value [[maybe_unused]], - int64_t maximum_value [[maybe_unused]], + void ReportHistogram([[maybe_unused]] DatumId histogram_type, + [[maybe_unused]] int64_t minimum_value, + [[maybe_unused]] int64_t maximum_value, const std::vector<uint32_t>& buckets) override { bool nonzero = false; for (const auto value : buckets) { @@ -296,13 +296,13 @@ TEST_F(MetricsTest, ResetMetrics) { class ZeroBackend : public TestBackendBase { public: - void ReportCounter(DatumId counter_type [[maybe_unused]], uint64_t value) override { + void ReportCounter([[maybe_unused]] DatumId counter_type, uint64_t value) override { EXPECT_EQ(value, 0u); } - void ReportHistogram(DatumId histogram_type [[maybe_unused]], - int64_t minimum_value [[maybe_unused]], - int64_t maximum_value [[maybe_unused]], + void ReportHistogram([[maybe_unused]] DatumId histogram_type, + [[maybe_unused]] int64_t minimum_value, + [[maybe_unused]] int64_t maximum_value, const std::vector<uint32_t>& buckets) override { for (const auto value : buckets) { EXPECT_EQ(value, 0u); @@ -323,13 +323,13 @@ TEST_F(MetricsTest, KeepEventMetricsResetValueMetricsAfterReporting) { class FirstBackend : public TestBackendBase { public: - void ReportCounter(DatumId counter_type [[maybe_unused]], uint64_t value) override { + void ReportCounter([[maybe_unused]] DatumId counter_type, uint64_t value) override { EXPECT_NE(value, 0u); } - void ReportHistogram(DatumId histogram_type [[maybe_unused]], - int64_t minimum_value [[maybe_unused]], - int64_t maximum_value [[maybe_unused]], + void ReportHistogram([[maybe_unused]] DatumId histogram_type, + [[maybe_unused]] int64_t minimum_value, + [[maybe_unused]] int64_t maximum_value, const std::vector<uint32_t>& buckets) override { EXPECT_NE(buckets[0], 0u) << "Bucket 0 should have a non-zero value"; for (size_t i = 1; i < buckets.size(); i++) { @@ -368,9 +368,9 @@ TEST_F(MetricsTest, KeepEventMetricsResetValueMetricsAfterReporting) { } // All histograms are event metrics. - void ReportHistogram(DatumId histogram_type [[maybe_unused]], - int64_t minimum_value [[maybe_unused]], - int64_t maximum_value [[maybe_unused]], + void ReportHistogram([[maybe_unused]] DatumId histogram_type, + [[maybe_unused]] int64_t minimum_value, + [[maybe_unused]] int64_t maximum_value, const std::vector<uint32_t>& buckets) override { EXPECT_NE(buckets[0], 0u) << "Bucket 0 should have a non-zero value"; for (size_t i = 1; i < buckets.size(); i++) { |