diff options
| author | 2021-10-15 12:11:37 +0100 | |
|---|---|---|
| committer | 2021-10-15 14:52:15 +0000 | |
| commit | 740e1f972ab1401d0afa98f365d9f5fe70a8a895 (patch) | |
| tree | 1e189dd88dddd48e817784a4af6559f5e60e3810 /libartbase/base/file_utils_test.cc | |
| parent | 41e56c2282bad545608d6d9711f9e4a3683354b8 (diff) | |
arm, arm64: Unpoison byte array view class reference before comparison.
Varhandle class reference needs to be unpoisoned before it gets compared
to the byte array view class reference from the boot image returned by
`LoadClassRootForIntrinsic`. This was missing in the CLs that added
varhandle intrinsics for byte array views and resulted in byte array
views handled by the slow path if poisoning is enabled:
- https://r.android.com/1535201 (arm64)
- https://r.android.com/1555075 (arm)
Bug: 71781600
Test: Ran benchmarks provided by https://r.android.com/1420959 with
ART_HEAP_POISONING=true before and after the change, observed improved
run time for byte array views (on sargo, arm64):
before after
-------------------------------------------
GetByteArrayViewInt 9.86 0.074
SetByteArrayViewInt 10.07 0.074
GetByteArrayViewBigEndianInt 10.40 0.077
SetByteArrayViewBigEndianInt 10.07 0.077
Test: art/test.py --target -r -t 712-varhandle-invocations
Test: same with ART_HEAP_POISONING=true
Change-Id: Ie776b44759df642d3227a64b824caa0b21ffd5e6
Diffstat (limited to 'libartbase/base/file_utils_test.cc')
0 files changed, 0 insertions, 0 deletions