summaryrefslogtreecommitdiff
path: root/dexdump
diff options
context:
space:
mode:
author David Sehr <sehr@google.com> 2019-04-03 09:28:21 -0700
committer David Sehr <sehr@google.com> 2019-04-04 15:28:48 +0000
commit4f215d1b1ceba9dfc8d8f3d8644da81302b2cd86 (patch)
tree34ee009a807d394ab7e1bb7f9ab3b1d36e3c7269 /dexdump
parent774232ae5a825ad4a366edc57081bff265e0ac32 (diff)
Rename dexdump2 to dexdump
Complete the migration from dalvik/dexdump to art/dexdump. Bug: 22322814 Test: make checkbuild test-art-host-dexdump Change-Id: I95d5b83d9855b440f2fe4073f1e1d746fe807888
Diffstat (limited to 'dexdump')
-rw-r--r--dexdump/Android.bp51
-rw-r--r--dexdump/dexdump_test.cc3
2 files changed, 27 insertions, 27 deletions
diff --git a/dexdump/Android.bp b/dexdump/Android.bp
index 434cb3553f..10bdf5182b 100644
--- a/dexdump/Android.bp
+++ b/dexdump/Android.bp
@@ -12,9 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-// TODO(ajcbik): rename dexdump2 into dexdump when Dalvik version is removed
-
-
cc_defaults {
name: "dexdump_defaults",
defaults: ["art_defaults"],
@@ -26,33 +23,37 @@ cc_defaults {
}
art_cc_binary {
- name: "dexdump2",
+ name: "dexdump",
defaults: ["dexdump_defaults"],
host_supported: true,
- shared_libs: [
- "libdexfile",
- "libartbase",
- "libbase",
- ],
-}
-
-art_cc_binary {
- name: "dexdumps",
- defaults: [
- "dexdump_defaults",
- "libartbase_static_defaults",
- "libdexfile_static_defaults",
- ],
- host_supported: true,
- device_supported: false,
target: {
- darwin: {
- enabled: false,
- },
windows: {
enabled: true,
- },
- },
+ static_libs: [
+ "libdexfile",
+ "libartbase",
+ "libbase",
+ "libartpalette",
+ "liblog",
+ "libz",
+ "libziparchive",
+ ],
+ },
+ not_windows: {
+ shared_libs: [
+ "libdexfile",
+ "libartbase",
+ "libbase",
+ ],
+ },
+ android: {
+ shared_libs: [
+ "libdexfile",
+ "libartbase",
+ "libbase",
+ ],
+ },
+ }
}
art_cc_test {
diff --git a/dexdump/dexdump_test.cc b/dexdump/dexdump_test.cc
index bb6d4a4b9b..a0f5335409 100644
--- a/dexdump/dexdump_test.cc
+++ b/dexdump/dexdump_test.cc
@@ -39,8 +39,7 @@ class DexDumpTest : public CommonRuntimeTest {
// Runs test with given arguments.
bool Exec(const std::vector<std::string>& args, std::string* error_msg) {
- // TODO(ajcbik): dexdump2 -> dexdump
- std::string file_path = GetTestAndroidRoot() + "/bin/dexdump2";
+ std::string file_path = GetTestAndroidRoot() + "/bin/dexdump";
EXPECT_TRUE(OS::FileExists(file_path.c_str())) << file_path << " should be a valid file path";
std::vector<std::string> exec_argv = { file_path };
exec_argv.insert(exec_argv.end(), args.begin(), args.end());