diff options
| author | 2015-08-12 11:52:22 +0100 | |
|---|---|---|
| committer | 2015-08-27 14:39:28 +0100 | |
| commit | 4ab02352db4051d590b793f34d166a0b5c633c4a (patch) | |
| tree | 33082d241095549c8f6497f1409483399d6ae303 /compiler | |
| parent | 772cc4a2d4f978888d1b1e5a78c1c16a108260ed (diff) | |
Use CodeGenerator::RecordPcInfo instead of SlowPathCode::RecordPcInfo.
Part of a clean-up and refactoring series. SlowPathCode::RecordPcInfo
is currently just a wrapper around CodGenerator::RecordPcInfo.
Change-Id: Iffabef4ef37c365051130bf98a6aa6dc0a0fb254
Signed-off-by: Serban Constantinescu <serban.constantinescu@linaro.org>
Diffstat (limited to 'compiler')
| -rw-r--r-- | compiler/optimizing/code_generator.cc | 6 | ||||
| -rw-r--r-- | compiler/optimizing/code_generator.h | 1 | ||||
| -rw-r--r-- | compiler/optimizing/intrinsics_arm.cc | 2 | ||||
| -rw-r--r-- | compiler/optimizing/intrinsics_arm64.cc | 2 | ||||
| -rw-r--r-- | compiler/optimizing/intrinsics_x86.cc | 2 | ||||
| -rw-r--r-- | compiler/optimizing/intrinsics_x86_64.cc | 2 |
6 files changed, 4 insertions, 11 deletions
diff --git a/compiler/optimizing/code_generator.cc b/compiler/optimizing/code_generator.cc index 503187bd3d..7c60026642 100644 --- a/compiler/optimizing/code_generator.cc +++ b/compiler/optimizing/code_generator.cc @@ -1071,12 +1071,6 @@ void CodeGenerator::ValidateInvokeRuntime(HInstruction* instruction, SlowPathCod << instruction->DebugName() << ((slow_path != nullptr) ? slow_path->GetDescription() : ""); } -void SlowPathCode::RecordPcInfo(CodeGenerator* codegen, - HInstruction* instruction, - uint32_t dex_pc) { - codegen->RecordPcInfo(instruction, dex_pc, this); -} - void SlowPathCode::SaveLiveRegisters(CodeGenerator* codegen, LocationSummary* locations) { RegisterSet* register_set = locations->GetLiveRegisters(); size_t stack_offset = codegen->GetFirstRegisterSlotInSlowPath(); diff --git a/compiler/optimizing/code_generator.h b/compiler/optimizing/code_generator.h index 938369b58c..cdd4675d2f 100644 --- a/compiler/optimizing/code_generator.h +++ b/compiler/optimizing/code_generator.h @@ -81,7 +81,6 @@ class SlowPathCode : public ArenaObject<kArenaAllocSlowPaths> { virtual void SaveLiveRegisters(CodeGenerator* codegen, LocationSummary* locations); virtual void RestoreLiveRegisters(CodeGenerator* codegen, LocationSummary* locations); - void RecordPcInfo(CodeGenerator* codegen, HInstruction* instruction, uint32_t dex_pc); bool IsCoreRegisterSaved(int reg) const { return saved_core_stack_offsets_[reg] != kRegisterNotSaved; diff --git a/compiler/optimizing/intrinsics_arm.cc b/compiler/optimizing/intrinsics_arm.cc index 806fd7a8f4..c84d071786 100644 --- a/compiler/optimizing/intrinsics_arm.cc +++ b/compiler/optimizing/intrinsics_arm.cc @@ -103,7 +103,7 @@ class IntrinsicSlowPathARM : public SlowPathCodeARM { if (invoke_->IsInvokeStaticOrDirect()) { codegen->GenerateStaticOrDirectCall(invoke_->AsInvokeStaticOrDirect(), Location::RegisterLocation(kArtMethodRegister)); - RecordPcInfo(codegen, invoke_, invoke_->GetDexPc()); + codegen->RecordPcInfo(invoke_, invoke_->GetDexPc(), this); } else { UNIMPLEMENTED(FATAL) << "Non-direct intrinsic slow-path not yet implemented"; UNREACHABLE(); diff --git a/compiler/optimizing/intrinsics_arm64.cc b/compiler/optimizing/intrinsics_arm64.cc index a5332ea794..0171d6949d 100644 --- a/compiler/optimizing/intrinsics_arm64.cc +++ b/compiler/optimizing/intrinsics_arm64.cc @@ -112,7 +112,7 @@ class IntrinsicSlowPathARM64 : public SlowPathCodeARM64 { if (invoke_->IsInvokeStaticOrDirect()) { codegen->GenerateStaticOrDirectCall(invoke_->AsInvokeStaticOrDirect(), LocationFrom(kArtMethodRegister)); - RecordPcInfo(codegen, invoke_, invoke_->GetDexPc()); + codegen->RecordPcInfo(invoke_, invoke_->GetDexPc(), this); } else { UNIMPLEMENTED(FATAL) << "Non-direct intrinsic slow-path not yet implemented"; UNREACHABLE(); diff --git a/compiler/optimizing/intrinsics_x86.cc b/compiler/optimizing/intrinsics_x86.cc index b7126b24e3..be076cd3ff 100644 --- a/compiler/optimizing/intrinsics_x86.cc +++ b/compiler/optimizing/intrinsics_x86.cc @@ -141,7 +141,7 @@ class IntrinsicSlowPathX86 : public SlowPathCodeX86 { if (invoke_->IsInvokeStaticOrDirect()) { codegen->GenerateStaticOrDirectCall(invoke_->AsInvokeStaticOrDirect(), Location::RegisterLocation(EAX)); - RecordPcInfo(codegen, invoke_, invoke_->GetDexPc()); + codegen->RecordPcInfo(invoke_, invoke_->GetDexPc(), this); } else { UNIMPLEMENTED(FATAL) << "Non-direct intrinsic slow-path not yet implemented"; UNREACHABLE(); diff --git a/compiler/optimizing/intrinsics_x86_64.cc b/compiler/optimizing/intrinsics_x86_64.cc index 15fbac1c63..1f35b597fe 100644 --- a/compiler/optimizing/intrinsics_x86_64.cc +++ b/compiler/optimizing/intrinsics_x86_64.cc @@ -132,7 +132,7 @@ class IntrinsicSlowPathX86_64 : public SlowPathCodeX86_64 { if (invoke_->IsInvokeStaticOrDirect()) { codegen->GenerateStaticOrDirectCall( invoke_->AsInvokeStaticOrDirect(), Location::RegisterLocation(RDI)); - RecordPcInfo(codegen, invoke_, invoke_->GetDexPc()); + codegen->RecordPcInfo(invoke_, invoke_->GetDexPc(), this); } else { UNIMPLEMENTED(FATAL) << "Non-direct intrinsic slow-path not yet implemented"; UNREACHABLE(); |