diff options
author | 2022-11-04 14:04:17 +0000 | |
---|---|---|
committer | 2022-11-07 07:11:25 +0000 | |
commit | 434d968b4af0bc8af9889170250bee3e08839bea (patch) | |
tree | 6c7e90fdf0d3f2d3b06f148a1537cfd21d37fcb8 /compiler | |
parent | 2952b48a1a060a1a0c614630a955486bf9be6478 (diff) |
Reland "Make compiler/optimizing/ symbols hidden."
This reverts commit 0a51605ddd81635135463dab08b6f7c21b58ffb0.
Reason for revert: Reland after some of the required work
was merged in other CLs.
Also address a TODO from the original CL to mark required
symbols with EXPORT in `intrinsic_objects.h`.
Also mark symbols in new files as HIDDEN.
Bug: 186902856
Test: m test-art-host-gtest
Test: testrunner.py --host --optimizing
Change-Id: I936d448983928af23614ca82c2d0bf9a645e2c52
Diffstat (limited to 'compiler')
194 files changed, 313 insertions, 199 deletions
diff --git a/compiler/optimizing/block_builder.cc b/compiler/optimizing/block_builder.cc index e1f061ae70..703584c537 100644 --- a/compiler/optimizing/block_builder.cc +++ b/compiler/optimizing/block_builder.cc @@ -22,7 +22,7 @@ #include "dex/dex_file_exception_helpers.h" #include "quicken_info.h" -namespace art { +namespace art HIDDEN { HBasicBlockBuilder::HBasicBlockBuilder(HGraph* graph, const DexFile* const dex_file, diff --git a/compiler/optimizing/block_builder.h b/compiler/optimizing/block_builder.h index 42a3f327e7..8668ef8221 100644 --- a/compiler/optimizing/block_builder.h +++ b/compiler/optimizing/block_builder.h @@ -17,13 +17,14 @@ #ifndef ART_COMPILER_OPTIMIZING_BLOCK_BUILDER_H_ #define ART_COMPILER_OPTIMIZING_BLOCK_BUILDER_H_ +#include "base/macros.h" #include "base/scoped_arena_allocator.h" #include "base/scoped_arena_containers.h" #include "dex/code_item_accessors.h" #include "dex/dex_file.h" #include "nodes.h" -namespace art { +namespace art HIDDEN { class HBasicBlockBuilder : public ValueObject { public: diff --git a/compiler/optimizing/block_namer.cc b/compiler/optimizing/block_namer.cc index d30448cd23..029e26b2be 100644 --- a/compiler/optimizing/block_namer.cc +++ b/compiler/optimizing/block_namer.cc @@ -18,7 +18,7 @@ #include "nodes.h" -namespace art { +namespace art HIDDEN { std::ostream& BlockNamer::PrintName(std::ostream& os, HBasicBlock* blk) const { os << "B"; diff --git a/compiler/optimizing/block_namer.h b/compiler/optimizing/block_namer.h index ed396b9bf8..39c5973297 100644 --- a/compiler/optimizing/block_namer.h +++ b/compiler/optimizing/block_namer.h @@ -19,7 +19,9 @@ #include <ostream> -namespace art { +#include "base/macros.h" + +namespace art HIDDEN { class HBasicBlock; struct BlockNamer { diff --git a/compiler/optimizing/bounds_check_elimination.cc b/compiler/optimizing/bounds_check_elimination.cc index 0b11a6fd1b..66a3b8b506 100644 --- a/compiler/optimizing/bounds_check_elimination.cc +++ b/compiler/optimizing/bounds_check_elimination.cc @@ -24,7 +24,7 @@ #include "nodes.h" #include "side_effects_analysis.h" -namespace art { +namespace art HIDDEN { class MonotonicValueRange; diff --git a/compiler/optimizing/bounds_check_elimination.h b/compiler/optimizing/bounds_check_elimination.h index ef08877daa..f210fa9127 100644 --- a/compiler/optimizing/bounds_check_elimination.h +++ b/compiler/optimizing/bounds_check_elimination.h @@ -17,9 +17,10 @@ #ifndef ART_COMPILER_OPTIMIZING_BOUNDS_CHECK_ELIMINATION_H_ #define ART_COMPILER_OPTIMIZING_BOUNDS_CHECK_ELIMINATION_H_ +#include "base/macros.h" #include "optimization.h" -namespace art { +namespace art HIDDEN { class SideEffectsAnalysis; class HInductionVarAnalysis; diff --git a/compiler/optimizing/bounds_check_elimination_test.cc b/compiler/optimizing/bounds_check_elimination_test.cc index 5927d681b2..929a9e7fe7 100644 --- a/compiler/optimizing/bounds_check_elimination_test.cc +++ b/compiler/optimizing/bounds_check_elimination_test.cc @@ -17,6 +17,7 @@ #include "bounds_check_elimination.h" #include "base/arena_allocator.h" +#include "base/macros.h" #include "builder.h" #include "gvn.h" #include "induction_var_analysis.h" @@ -27,7 +28,7 @@ #include "gtest/gtest.h" -namespace art { +namespace art HIDDEN { /** * Fixture class for the BoundsCheckElimination tests. diff --git a/compiler/optimizing/builder.cc b/compiler/optimizing/builder.cc index fbec52d88f..da791a7cf7 100644 --- a/compiler/optimizing/builder.cc +++ b/compiler/optimizing/builder.cc @@ -33,7 +33,7 @@ #include "ssa_builder.h" #include "thread.h" -namespace art { +namespace art HIDDEN { HGraphBuilder::HGraphBuilder(HGraph* graph, const CodeItemDebugInfoAccessor& accessor, diff --git a/compiler/optimizing/builder.h b/compiler/optimizing/builder.h index 2964ad5c9b..85fa8d4123 100644 --- a/compiler/optimizing/builder.h +++ b/compiler/optimizing/builder.h @@ -19,12 +19,13 @@ #include "base/arena_object.h" #include "base/array_ref.h" +#include "base/macros.h" #include "dex/code_item_accessors.h" #include "dex/dex_file-inl.h" #include "dex/dex_file.h" #include "nodes.h" -namespace art { +namespace art HIDDEN { class ArtMethod; class CodeGenerator; diff --git a/compiler/optimizing/cha_guard_optimization.cc b/compiler/optimizing/cha_guard_optimization.cc index d231593792..20a763cf6d 100644 --- a/compiler/optimizing/cha_guard_optimization.cc +++ b/compiler/optimizing/cha_guard_optimization.cc @@ -16,7 +16,7 @@ #include "cha_guard_optimization.h" -namespace art { +namespace art HIDDEN { // Note we can only do CHA guard elimination/motion in a single pass, since // if a guard is not removed, another guard might be removed due to diff --git a/compiler/optimizing/cha_guard_optimization.h b/compiler/optimizing/cha_guard_optimization.h index 440d51a969..5c1fdd90de 100644 --- a/compiler/optimizing/cha_guard_optimization.h +++ b/compiler/optimizing/cha_guard_optimization.h @@ -17,9 +17,10 @@ #ifndef ART_COMPILER_OPTIMIZING_CHA_GUARD_OPTIMIZATION_H_ #define ART_COMPILER_OPTIMIZING_CHA_GUARD_OPTIMIZATION_H_ +#include "base/macros.h" #include "optimization.h" -namespace art { +namespace art HIDDEN { /** * Optimize CHA guards by removing/moving them. diff --git a/compiler/optimizing/code_generator.cc b/compiler/optimizing/code_generator.cc index 1c5912d87e..4d177c2f96 100644 --- a/compiler/optimizing/code_generator.cc +++ b/compiler/optimizing/code_generator.cc @@ -61,7 +61,7 @@ #include "thread-current-inl.h" #include "utils/assembler.h" -namespace art { +namespace art HIDDEN { // Return whether a location is consistent with a type. static bool CheckType(DataType::Type type, Location location) { diff --git a/compiler/optimizing/code_generator.h b/compiler/optimizing/code_generator.h index 578a3417ba..ee80357791 100644 --- a/compiler/optimizing/code_generator.h +++ b/compiler/optimizing/code_generator.h @@ -26,6 +26,7 @@ #include "base/bit_utils.h" #include "base/enums.h" #include "base/globals.h" +#include "base/macros.h" #include "base/memory_region.h" #include "class_root.h" #include "dex/string_reference.h" @@ -41,7 +42,7 @@ #include "utils/assembler.h" #include "utils/label.h" -namespace art { +namespace art HIDDEN { // Binary encoding of 2^32 for type double. static int64_t constexpr k2Pow32EncodingForDouble = INT64_C(0x41F0000000000000); diff --git a/compiler/optimizing/code_generator_arm64.cc b/compiler/optimizing/code_generator_arm64.cc index 72ca927897..40928585f6 100644 --- a/compiler/optimizing/code_generator_arm64.cc +++ b/compiler/optimizing/code_generator_arm64.cc @@ -57,7 +57,7 @@ using vixl::EmissionCheckScope; #error "ARM64 Codegen VIXL macro-assembler macro already defined." #endif -namespace art { +namespace art HIDDEN { template<class MirrorType> class GcRoot; diff --git a/compiler/optimizing/code_generator_arm64.h b/compiler/optimizing/code_generator_arm64.h index 66e8471483..434263104f 100644 --- a/compiler/optimizing/code_generator_arm64.h +++ b/compiler/optimizing/code_generator_arm64.h @@ -18,6 +18,7 @@ #define ART_COMPILER_OPTIMIZING_CODE_GENERATOR_ARM64_H_ #include "base/bit_field.h" +#include "base/macros.h" #include "class_root.h" #include "code_generator.h" #include "common_arm64.h" @@ -36,7 +37,7 @@ #include "aarch64/macro-assembler-aarch64.h" #pragma GCC diagnostic pop -namespace art { +namespace art HIDDEN { namespace linker { class Arm64RelativePatcherTest; diff --git a/compiler/optimizing/code_generator_arm_vixl.cc b/compiler/optimizing/code_generator_arm_vixl.cc index 03a9977a11..d9bb63723f 100644 --- a/compiler/optimizing/code_generator_arm_vixl.cc +++ b/compiler/optimizing/code_generator_arm_vixl.cc @@ -45,7 +45,7 @@ #include "utils/assembler.h" #include "utils/stack_checks.h" -namespace art { +namespace art HIDDEN { namespace arm { namespace vixl32 = vixl::aarch32; diff --git a/compiler/optimizing/code_generator_arm_vixl.h b/compiler/optimizing/code_generator_arm_vixl.h index e5b31cf9d8..20fb7708fb 100644 --- a/compiler/optimizing/code_generator_arm_vixl.h +++ b/compiler/optimizing/code_generator_arm_vixl.h @@ -18,6 +18,7 @@ #define ART_COMPILER_OPTIMIZING_CODE_GENERATOR_ARM_VIXL_H_ #include "base/enums.h" +#include "base/macros.h" #include "class_root.h" #include "code_generator.h" #include "common_arm.h" @@ -36,7 +37,7 @@ #include "aarch32/macro-assembler-aarch32.h" #pragma GCC diagnostic pop -namespace art { +namespace art HIDDEN { namespace linker { class Thumb2RelativePatcherTest; diff --git a/compiler/optimizing/code_generator_utils.cc b/compiler/optimizing/code_generator_utils.cc index abec26464a..99805928e4 100644 --- a/compiler/optimizing/code_generator_utils.cc +++ b/compiler/optimizing/code_generator_utils.cc @@ -20,7 +20,7 @@ #include "nodes.h" -namespace art { +namespace art HIDDEN { void CalculateMagicAndShiftForDivRem(int64_t divisor, bool is_long, int64_t* magic, int* shift) { diff --git a/compiler/optimizing/code_generator_utils.h b/compiler/optimizing/code_generator_utils.h index 64665adc15..9d9ab2b118 100644 --- a/compiler/optimizing/code_generator_utils.h +++ b/compiler/optimizing/code_generator_utils.h @@ -21,7 +21,9 @@ #include <cstdlib> #include <limits> -namespace art { +#include "base/macros.h" + +namespace art HIDDEN { class HInstruction; diff --git a/compiler/optimizing/code_generator_vector_arm64_neon.cc b/compiler/optimizing/code_generator_vector_arm64_neon.cc index 0fe9898635..c70c8f522f 100644 --- a/compiler/optimizing/code_generator_vector_arm64_neon.cc +++ b/compiler/optimizing/code_generator_vector_arm64_neon.cc @@ -23,7 +23,7 @@ using namespace vixl::aarch64; // NOLINT(build/namespaces) -namespace art { +namespace art HIDDEN { namespace arm64 { using helpers::DRegisterFrom; diff --git a/compiler/optimizing/code_generator_vector_arm64_sve.cc b/compiler/optimizing/code_generator_vector_arm64_sve.cc index 2d4921f27c..87b6d5772b 100644 --- a/compiler/optimizing/code_generator_vector_arm64_sve.cc +++ b/compiler/optimizing/code_generator_vector_arm64_sve.cc @@ -23,7 +23,7 @@ using namespace vixl::aarch64; // NOLINT(build/namespaces) -namespace art { +namespace art HIDDEN { namespace arm64 { using helpers::DRegisterFrom; diff --git a/compiler/optimizing/code_generator_vector_arm_vixl.cc b/compiler/optimizing/code_generator_vector_arm_vixl.cc index c46f9b7986..1359d89ace 100644 --- a/compiler/optimizing/code_generator_vector_arm_vixl.cc +++ b/compiler/optimizing/code_generator_vector_arm_vixl.cc @@ -20,7 +20,7 @@ namespace vixl32 = vixl::aarch32; using namespace vixl32; // NOLINT(build/namespaces) -namespace art { +namespace art HIDDEN { namespace arm { using helpers::DRegisterFrom; diff --git a/compiler/optimizing/code_generator_vector_x86.cc b/compiler/optimizing/code_generator_vector_x86.cc index 9c837dd986..0e576043fd 100644 --- a/compiler/optimizing/code_generator_vector_x86.cc +++ b/compiler/optimizing/code_generator_vector_x86.cc @@ -19,7 +19,7 @@ #include "mirror/array-inl.h" #include "mirror/string.h" -namespace art { +namespace art HIDDEN { namespace x86 { // NOLINT on __ macro to suppress wrong warning/fix (misc-macro-parentheses) from clang-tidy. diff --git a/compiler/optimizing/code_generator_vector_x86_64.cc b/compiler/optimizing/code_generator_vector_x86_64.cc index 330bf76a4a..10b84d6072 100644 --- a/compiler/optimizing/code_generator_vector_x86_64.cc +++ b/compiler/optimizing/code_generator_vector_x86_64.cc @@ -19,7 +19,7 @@ #include "mirror/array-inl.h" #include "mirror/string.h" -namespace art { +namespace art HIDDEN { namespace x86_64 { // NOLINT on __ macro to suppress wrong warning/fix (misc-macro-parentheses) from clang-tidy. diff --git a/compiler/optimizing/code_generator_x86.cc b/compiler/optimizing/code_generator_x86.cc index 5cc7270a53..254e20a07a 100644 --- a/compiler/optimizing/code_generator_x86.cc +++ b/compiler/optimizing/code_generator_x86.cc @@ -42,7 +42,7 @@ #include "utils/x86/assembler_x86.h" #include "utils/x86/managed_register_x86.h" -namespace art { +namespace art HIDDEN { template<class MirrorType> class GcRoot; diff --git a/compiler/optimizing/code_generator_x86.h b/compiler/optimizing/code_generator_x86.h index 75c5cebb5e..02b967fdd4 100644 --- a/compiler/optimizing/code_generator_x86.h +++ b/compiler/optimizing/code_generator_x86.h @@ -19,6 +19,7 @@ #include "arch/x86/instruction_set_features_x86.h" #include "base/enums.h" +#include "base/macros.h" #include "code_generator.h" #include "dex/dex_file_types.h" #include "driver/compiler_options.h" @@ -26,7 +27,7 @@ #include "parallel_move_resolver.h" #include "utils/x86/assembler_x86.h" -namespace art { +namespace art HIDDEN { namespace x86 { // Use a local definition to prevent copying mistakes. diff --git a/compiler/optimizing/code_generator_x86_64.cc b/compiler/optimizing/code_generator_x86_64.cc index 33c9ae4867..ad2509f56a 100644 --- a/compiler/optimizing/code_generator_x86_64.cc +++ b/compiler/optimizing/code_generator_x86_64.cc @@ -44,7 +44,7 @@ #include "utils/x86_64/constants_x86_64.h" #include "utils/x86_64/managed_register_x86_64.h" -namespace art { +namespace art HIDDEN { template<class MirrorType> class GcRoot; diff --git a/compiler/optimizing/code_generator_x86_64.h b/compiler/optimizing/code_generator_x86_64.h index 39a72d8211..ffc2641dbc 100644 --- a/compiler/optimizing/code_generator_x86_64.h +++ b/compiler/optimizing/code_generator_x86_64.h @@ -18,13 +18,14 @@ #define ART_COMPILER_OPTIMIZING_CODE_GENERATOR_X86_64_H_ #include "arch/x86_64/instruction_set_features_x86_64.h" +#include "base/macros.h" #include "code_generator.h" #include "driver/compiler_options.h" #include "nodes.h" #include "parallel_move_resolver.h" #include "utils/x86_64/assembler_x86_64.h" -namespace art { +namespace art HIDDEN { namespace x86_64 { // Use a local definition to prevent copying mistakes. diff --git a/compiler/optimizing/code_sinking.cc b/compiler/optimizing/code_sinking.cc index 930675b401..42679337b7 100644 --- a/compiler/optimizing/code_sinking.cc +++ b/compiler/optimizing/code_sinking.cc @@ -25,7 +25,7 @@ #include "common_dominator.h" #include "nodes.h" -namespace art { +namespace art HIDDEN { bool CodeSinking::Run() { HBasicBlock* exit = graph_->GetExitBlock(); diff --git a/compiler/optimizing/code_sinking.h b/compiler/optimizing/code_sinking.h index 8eb3a520c3..14f62f2417 100644 --- a/compiler/optimizing/code_sinking.h +++ b/compiler/optimizing/code_sinking.h @@ -17,10 +17,11 @@ #ifndef ART_COMPILER_OPTIMIZING_CODE_SINKING_H_ #define ART_COMPILER_OPTIMIZING_CODE_SINKING_H_ +#include "base/macros.h" #include "nodes.h" #include "optimization.h" -namespace art { +namespace art HIDDEN { /** * Optimization pass to move instructions into uncommon branches, diff --git a/compiler/optimizing/codegen_test.cc b/compiler/optimizing/codegen_test.cc index c0441b07ed..9f1f62b203 100644 --- a/compiler/optimizing/codegen_test.cc +++ b/compiler/optimizing/codegen_test.cc @@ -33,7 +33,7 @@ #include "gtest/gtest.h" -namespace art { +namespace art HIDDEN { // Return all combinations of ISA and code generator that are executable on // hardware, or on simulator, and that we'd like to test. diff --git a/compiler/optimizing/codegen_test_utils.h b/compiler/optimizing/codegen_test_utils.h index 8e93f4d55a..88551d8e90 100644 --- a/compiler/optimizing/codegen_test_utils.h +++ b/compiler/optimizing/codegen_test_utils.h @@ -20,6 +20,7 @@ #include "arch/arm/registers_arm.h" #include "arch/instruction_set.h" #include "arch/x86/registers_x86.h" +#include "base/macros.h" #include "code_simulator.h" #include "code_simulator_container.h" #include "common_compiler_test.h" @@ -43,7 +44,7 @@ #include "code_generator_x86_64.h" #endif -namespace art { +namespace art HIDDEN { using CreateCodegenFn = CodeGenerator* (*)(HGraph*, const CompilerOptions&); diff --git a/compiler/optimizing/common_arm.h b/compiler/optimizing/common_arm.h index 320915ee57..5f71cb906c 100644 --- a/compiler/optimizing/common_arm.h +++ b/compiler/optimizing/common_arm.h @@ -17,6 +17,7 @@ #ifndef ART_COMPILER_OPTIMIZING_COMMON_ARM_H_ #define ART_COMPILER_OPTIMIZING_COMMON_ARM_H_ +#include "base/macros.h" #include "instruction_simplifier_shared.h" #include "locations.h" #include "nodes.h" @@ -28,7 +29,7 @@ #include "aarch32/macro-assembler-aarch32.h" #pragma GCC diagnostic pop -namespace art { +namespace art HIDDEN { using helpers::HasShifterOperand; diff --git a/compiler/optimizing/common_arm64.h b/compiler/optimizing/common_arm64.h index 81c6561318..18751c4efe 100644 --- a/compiler/optimizing/common_arm64.h +++ b/compiler/optimizing/common_arm64.h @@ -17,6 +17,7 @@ #ifndef ART_COMPILER_OPTIMIZING_COMMON_ARM64_H_ #define ART_COMPILER_OPTIMIZING_COMMON_ARM64_H_ +#include "base/macros.h" #include "code_generator.h" #include "instruction_simplifier_shared.h" #include "locations.h" @@ -31,7 +32,7 @@ #include "aarch64/simulator-aarch64.h" #pragma GCC diagnostic pop -namespace art { +namespace art HIDDEN { using helpers::CanFitInShifterOperand; using helpers::HasShifterOperand; diff --git a/compiler/optimizing/common_dominator.h b/compiler/optimizing/common_dominator.h index 9f012cfbb2..f01270ee4a 100644 --- a/compiler/optimizing/common_dominator.h +++ b/compiler/optimizing/common_dominator.h @@ -17,9 +17,10 @@ #ifndef ART_COMPILER_OPTIMIZING_COMMON_DOMINATOR_H_ #define ART_COMPILER_OPTIMIZING_COMMON_DOMINATOR_H_ +#include "base/macros.h" #include "nodes.h" -namespace art { +namespace art HIDDEN { // Helper class for finding common dominators of two or more blocks in a graph. // The domination information of a graph must not be modified while there is diff --git a/compiler/optimizing/constant_folding.cc b/compiler/optimizing/constant_folding.cc index 7fa2132953..489b62df0a 100644 --- a/compiler/optimizing/constant_folding.cc +++ b/compiler/optimizing/constant_folding.cc @@ -21,7 +21,7 @@ #include "optimizing/data_type.h" #include "optimizing/nodes.h" -namespace art { +namespace art HIDDEN { // This visitor tries to simplify instructions that can be evaluated // as constants. diff --git a/compiler/optimizing/constant_folding.h b/compiler/optimizing/constant_folding.h index 07388d2e8c..1a5e9044b8 100644 --- a/compiler/optimizing/constant_folding.h +++ b/compiler/optimizing/constant_folding.h @@ -17,11 +17,12 @@ #ifndef ART_COMPILER_OPTIMIZING_CONSTANT_FOLDING_H_ #define ART_COMPILER_OPTIMIZING_CONSTANT_FOLDING_H_ +#include "base/macros.h" #include "nodes.h" #include "optimization.h" #include "optimizing/optimizing_compiler_stats.h" -namespace art { +namespace art HIDDEN { /** * Optimization pass performing a simple constant-expression diff --git a/compiler/optimizing/constant_folding_test.cc b/compiler/optimizing/constant_folding_test.cc index 3bcdc1ce40..7c3dae21d8 100644 --- a/compiler/optimizing/constant_folding_test.cc +++ b/compiler/optimizing/constant_folding_test.cc @@ -17,6 +17,8 @@ #include <functional> #include "constant_folding.h" + +#include "base/macros.h" #include "dead_code_elimination.h" #include "driver/compiler_options.h" #include "graph_checker.h" @@ -25,7 +27,7 @@ #include "gtest/gtest.h" -namespace art { +namespace art HIDDEN { /** * Fixture class for the constant folding and dce tests. diff --git a/compiler/optimizing/constructor_fence_redundancy_elimination.cc b/compiler/optimizing/constructor_fence_redundancy_elimination.cc index 3a1a9e023d..e744797fa9 100644 --- a/compiler/optimizing/constructor_fence_redundancy_elimination.cc +++ b/compiler/optimizing/constructor_fence_redundancy_elimination.cc @@ -20,7 +20,7 @@ #include "base/scoped_arena_allocator.h" #include "base/scoped_arena_containers.h" -namespace art { +namespace art HIDDEN { static constexpr bool kCfreLogFenceInputCount = false; diff --git a/compiler/optimizing/constructor_fence_redundancy_elimination.h b/compiler/optimizing/constructor_fence_redundancy_elimination.h index 014b342258..e04b986171 100644 --- a/compiler/optimizing/constructor_fence_redundancy_elimination.h +++ b/compiler/optimizing/constructor_fence_redundancy_elimination.h @@ -17,9 +17,10 @@ #ifndef ART_COMPILER_OPTIMIZING_CONSTRUCTOR_FENCE_REDUNDANCY_ELIMINATION_H_ #define ART_COMPILER_OPTIMIZING_CONSTRUCTOR_FENCE_REDUNDANCY_ELIMINATION_H_ +#include "base/macros.h" #include "optimization.h" -namespace art { +namespace art HIDDEN { /* * Constructor Fence Redundancy Elimination (CFRE). diff --git a/compiler/optimizing/critical_native_abi_fixup_arm.cc b/compiler/optimizing/critical_native_abi_fixup_arm.cc index 23730530d1..03fb26bf1e 100644 --- a/compiler/optimizing/critical_native_abi_fixup_arm.cc +++ b/compiler/optimizing/critical_native_abi_fixup_arm.cc @@ -23,7 +23,7 @@ #include "scoped_thread_state_change-inl.h" #include "well_known_classes.h" -namespace art { +namespace art HIDDEN { namespace arm { // Fix up FP arguments passed in core registers for call to @CriticalNative by inserting fake calls diff --git a/compiler/optimizing/critical_native_abi_fixup_arm.h b/compiler/optimizing/critical_native_abi_fixup_arm.h index faa3c7a5fe..c2068f5e2d 100644 --- a/compiler/optimizing/critical_native_abi_fixup_arm.h +++ b/compiler/optimizing/critical_native_abi_fixup_arm.h @@ -17,10 +17,11 @@ #ifndef ART_COMPILER_OPTIMIZING_CRITICAL_NATIVE_ABI_FIXUP_ARM_H_ #define ART_COMPILER_OPTIMIZING_CRITICAL_NATIVE_ABI_FIXUP_ARM_H_ +#include "base/macros.h" #include "nodes.h" #include "optimization.h" -namespace art { +namespace art HIDDEN { namespace arm { class CriticalNativeAbiFixupArm : public HOptimization { diff --git a/compiler/optimizing/data_type-inl.h b/compiler/optimizing/data_type-inl.h index 1b33b775da..bbfe90451b 100644 --- a/compiler/optimizing/data_type-inl.h +++ b/compiler/optimizing/data_type-inl.h @@ -20,7 +20,7 @@ #include "data_type.h" #include "dex/primitive.h" -namespace art { +namespace art HIDDEN { // Note: Not declared in data_type.h to avoid pulling in "primitive.h". constexpr DataType::Type DataTypeFromPrimitive(Primitive::Type type) { diff --git a/compiler/optimizing/data_type.cc b/compiler/optimizing/data_type.cc index cb354f46cc..183cf2c622 100644 --- a/compiler/optimizing/data_type.cc +++ b/compiler/optimizing/data_type.cc @@ -16,7 +16,7 @@ #include "data_type.h" -namespace art { +namespace art HIDDEN { static const char* kTypeNames[] = { "Reference", diff --git a/compiler/optimizing/data_type.h b/compiler/optimizing/data_type.h index ec6ca7accb..b6d9519150 100644 --- a/compiler/optimizing/data_type.h +++ b/compiler/optimizing/data_type.h @@ -22,8 +22,9 @@ #include <android-base/logging.h> #include "base/bit_utils.h" +#include "base/macros.h" -namespace art { +namespace art HIDDEN { class DataType { public: diff --git a/compiler/optimizing/data_type_test.cc b/compiler/optimizing/data_type_test.cc index 8fea22bce8..f6f614d8c4 100644 --- a/compiler/optimizing/data_type_test.cc +++ b/compiler/optimizing/data_type_test.cc @@ -22,7 +22,7 @@ #include "base/macros.h" #include "dex/primitive.h" -namespace art { +namespace art HIDDEN { template <DataType::Type data_type, Primitive::Type primitive_type> static void CheckConversion() { diff --git a/compiler/optimizing/dead_code_elimination.cc b/compiler/optimizing/dead_code_elimination.cc index ee868db759..909ff838f2 100644 --- a/compiler/optimizing/dead_code_elimination.cc +++ b/compiler/optimizing/dead_code_elimination.cc @@ -25,7 +25,7 @@ #include "optimizing/nodes.h" #include "ssa_phi_elimination.h" -namespace art { +namespace art HIDDEN { static void MarkReachableBlocks(HGraph* graph, ArenaBitVector* visited) { // Use local allocator for allocating memory. diff --git a/compiler/optimizing/dead_code_elimination.h b/compiler/optimizing/dead_code_elimination.h index 799721acf2..a3e993c1d7 100644 --- a/compiler/optimizing/dead_code_elimination.h +++ b/compiler/optimizing/dead_code_elimination.h @@ -17,11 +17,12 @@ #ifndef ART_COMPILER_OPTIMIZING_DEAD_CODE_ELIMINATION_H_ #define ART_COMPILER_OPTIMIZING_DEAD_CODE_ELIMINATION_H_ +#include "base/macros.h" #include "nodes.h" #include "optimization.h" #include "optimizing_compiler_stats.h" -namespace art { +namespace art HIDDEN { /** * Optimization pass performing dead code elimination (removal of diff --git a/compiler/optimizing/dead_code_elimination_test.cc b/compiler/optimizing/dead_code_elimination_test.cc index f5cd4dc27a..fcf4ca39f2 100644 --- a/compiler/optimizing/dead_code_elimination_test.cc +++ b/compiler/optimizing/dead_code_elimination_test.cc @@ -16,6 +16,7 @@ #include "dead_code_elimination.h" +#include "base/macros.h" #include "driver/compiler_options.h" #include "graph_checker.h" #include "optimizing_unit_test.h" @@ -23,7 +24,7 @@ #include "gtest/gtest.h" -namespace art { +namespace art HIDDEN { class DeadCodeEliminationTest : public OptimizingUnitTest { protected: diff --git a/compiler/optimizing/dominator_test.cc b/compiler/optimizing/dominator_test.cc index 1d72ba116e..d3b8cb1cf8 100644 --- a/compiler/optimizing/dominator_test.cc +++ b/compiler/optimizing/dominator_test.cc @@ -15,6 +15,7 @@ */ #include "base/arena_allocator.h" +#include "base/macros.h" #include "builder.h" #include "dex/dex_instruction.h" #include "nodes.h" @@ -22,7 +23,7 @@ #include "gtest/gtest.h" -namespace art { +namespace art HIDDEN { class OptimizerTest : public OptimizingUnitTest { protected: diff --git a/compiler/optimizing/escape.cc b/compiler/optimizing/escape.cc index 617833c697..cebe94fd0d 100644 --- a/compiler/optimizing/escape.cc +++ b/compiler/optimizing/escape.cc @@ -18,7 +18,7 @@ #include "nodes.h" -namespace art { +namespace art HIDDEN { void VisitEscapes(HInstruction* reference, EscapeVisitor& escape_visitor) { // References not allocated in the method are intrinsically escaped. diff --git a/compiler/optimizing/escape.h b/compiler/optimizing/escape.h index 5402cb1763..3b284fbf43 100644 --- a/compiler/optimizing/escape.h +++ b/compiler/optimizing/escape.h @@ -17,7 +17,9 @@ #ifndef ART_COMPILER_OPTIMIZING_ESCAPE_H_ #define ART_COMPILER_OPTIMIZING_ESCAPE_H_ -namespace art { +#include "base/macros.h" + +namespace art HIDDEN { class HInstruction; diff --git a/compiler/optimizing/execution_subgraph.cc b/compiler/optimizing/execution_subgraph.cc index 66fdfcda5b..06aabbe040 100644 --- a/compiler/optimizing/execution_subgraph.cc +++ b/compiler/optimizing/execution_subgraph.cc @@ -26,7 +26,7 @@ #include "base/scoped_arena_allocator.h" #include "nodes.h" -namespace art { +namespace art HIDDEN { ExecutionSubgraph::ExecutionSubgraph(HGraph* graph, ScopedArenaAllocator* allocator) : graph_(graph), diff --git a/compiler/optimizing/execution_subgraph.h b/compiler/optimizing/execution_subgraph.h index 7d2a66077d..5ddf17de60 100644 --- a/compiler/optimizing/execution_subgraph.h +++ b/compiler/optimizing/execution_subgraph.h @@ -27,6 +27,7 @@ #include "base/bit_vector-inl.h" #include "base/globals.h" #include "base/iteration_range.h" +#include "base/macros.h" #include "base/mutex.h" #include "base/scoped_arena_allocator.h" #include "base/scoped_arena_containers.h" @@ -34,7 +35,7 @@ #include "base/transform_iterator.h" #include "nodes.h" -namespace art { +namespace art HIDDEN { // Helper for transforming blocks to block_ids. class BlockToBlockIdTransformer { diff --git a/compiler/optimizing/execution_subgraph_test.cc b/compiler/optimizing/execution_subgraph_test.cc index 74c243b5b4..921ef056ba 100644 --- a/compiler/optimizing/execution_subgraph_test.cc +++ b/compiler/optimizing/execution_subgraph_test.cc @@ -37,7 +37,7 @@ #include "optimizing_unit_test.h" #include "scoped_thread_state_change.h" -namespace art { +namespace art HIDDEN { using BlockSet = std::unordered_set<const HBasicBlock*>; diff --git a/compiler/optimizing/execution_subgraph_test.h b/compiler/optimizing/execution_subgraph_test.h index 13cb2bc7c5..cee105a045 100644 --- a/compiler/optimizing/execution_subgraph_test.h +++ b/compiler/optimizing/execution_subgraph_test.h @@ -19,7 +19,9 @@ #include "android-base/macros.h" -namespace art { +#include "base/macros.h" + +namespace art HIDDEN { class HGraph; class ExecutionSubgraph; diff --git a/compiler/optimizing/find_loops_test.cc b/compiler/optimizing/find_loops_test.cc index 75b8e9609e..8d8c3a1838 100644 --- a/compiler/optimizing/find_loops_test.cc +++ b/compiler/optimizing/find_loops_test.cc @@ -15,6 +15,7 @@ */ #include "base/arena_allocator.h" +#include "base/macros.h" #include "builder.h" #include "dex/dex_file.h" #include "dex/dex_instruction.h" @@ -25,7 +26,7 @@ #include "gtest/gtest.h" -namespace art { +namespace art HIDDEN { class FindLoopsTest : public OptimizingUnitTest {}; diff --git a/compiler/optimizing/graph_checker.cc b/compiler/optimizing/graph_checker.cc index 10711510f2..e4203fe492 100644 --- a/compiler/optimizing/graph_checker.cc +++ b/compiler/optimizing/graph_checker.cc @@ -32,7 +32,7 @@ #include "scoped_thread_state_change-inl.h" #include "subtype_check.h" -namespace art { +namespace art HIDDEN { using android::base::StringPrintf; diff --git a/compiler/optimizing/graph_checker.h b/compiler/optimizing/graph_checker.h index 04c8d2103c..c3cdba5d42 100644 --- a/compiler/optimizing/graph_checker.h +++ b/compiler/optimizing/graph_checker.h @@ -21,10 +21,11 @@ #include "base/arena_bit_vector.h" #include "base/bit_vector-inl.h" +#include "base/macros.h" #include "base/scoped_arena_allocator.h" #include "nodes.h" -namespace art { +namespace art HIDDEN { class CodeGenerator; diff --git a/compiler/optimizing/graph_checker_test.cc b/compiler/optimizing/graph_checker_test.cc index 08bfa5d80f..9a2fc890f5 100644 --- a/compiler/optimizing/graph_checker_test.cc +++ b/compiler/optimizing/graph_checker_test.cc @@ -14,10 +14,11 @@ * limitations under the License. */ +#include "base/macros.h" #include "graph_checker.h" #include "optimizing_unit_test.h" -namespace art { +namespace art HIDDEN { class GraphCheckerTest : public OptimizingUnitTest { protected: diff --git a/compiler/optimizing/graph_test.cc b/compiler/optimizing/graph_test.cc index 29af808731..b5d712736f 100644 --- a/compiler/optimizing/graph_test.cc +++ b/compiler/optimizing/graph_test.cc @@ -15,6 +15,7 @@ */ #include "base/arena_allocator.h" +#include "base/macros.h" #include "builder.h" #include "nodes.h" #include "optimizing_unit_test.h" @@ -22,7 +23,7 @@ #include "gtest/gtest.h" -namespace art { +namespace art HIDDEN { class GraphTest : public OptimizingUnitTest { protected: diff --git a/compiler/optimizing/graph_visualizer.cc b/compiler/optimizing/graph_visualizer.cc index 4a6ee13005..e1199dfb72 100644 --- a/compiler/optimizing/graph_visualizer.cc +++ b/compiler/optimizing/graph_visualizer.cc @@ -43,7 +43,7 @@ #include "ssa_liveness_analysis.h" #include "utils/assembler.h" -namespace art { +namespace art HIDDEN { // Unique pass-name to identify that the dump is for printing to log. constexpr const char* kDebugDumpName = "debug"; diff --git a/compiler/optimizing/graph_visualizer.h b/compiler/optimizing/graph_visualizer.h index 3429c11cbd..9878917739 100644 --- a/compiler/optimizing/graph_visualizer.h +++ b/compiler/optimizing/graph_visualizer.h @@ -22,10 +22,11 @@ #include "arch/instruction_set.h" #include "base/arena_containers.h" +#include "base/macros.h" #include "base/value_object.h" #include "block_namer.h" -namespace art { +namespace art HIDDEN { class CodeGenerator; class DexCompilationUnit; diff --git a/compiler/optimizing/gvn.cc b/compiler/optimizing/gvn.cc index c7cd223b51..a6ca057cfc 100644 --- a/compiler/optimizing/gvn.cc +++ b/compiler/optimizing/gvn.cc @@ -23,7 +23,7 @@ #include "base/utils.h" #include "side_effects_analysis.h" -namespace art { +namespace art HIDDEN { /** * A ValueSet holds instructions that can replace other instructions. It is updated diff --git a/compiler/optimizing/gvn.h b/compiler/optimizing/gvn.h index bbf2265e98..df4e3a8dbf 100644 --- a/compiler/optimizing/gvn.h +++ b/compiler/optimizing/gvn.h @@ -17,10 +17,11 @@ #ifndef ART_COMPILER_OPTIMIZING_GVN_H_ #define ART_COMPILER_OPTIMIZING_GVN_H_ +#include "base/macros.h" #include "nodes.h" #include "optimization.h" -namespace art { +namespace art HIDDEN { class SideEffectsAnalysis; diff --git a/compiler/optimizing/gvn_test.cc b/compiler/optimizing/gvn_test.cc index 3bf4cc35ba..1eb6307cb1 100644 --- a/compiler/optimizing/gvn_test.cc +++ b/compiler/optimizing/gvn_test.cc @@ -17,12 +17,13 @@ #include "gvn.h" #include "base/arena_allocator.h" +#include "base/macros.h" #include "builder.h" #include "nodes.h" #include "optimizing_unit_test.h" #include "side_effects_analysis.h" -namespace art { +namespace art HIDDEN { class GVNTest : public OptimizingUnitTest {}; diff --git a/compiler/optimizing/induction_var_analysis.cc b/compiler/optimizing/induction_var_analysis.cc index 3b5a2f1f9d..5b5cd2e3b8 100644 --- a/compiler/optimizing/induction_var_analysis.cc +++ b/compiler/optimizing/induction_var_analysis.cc @@ -18,7 +18,7 @@ #include "induction_var_range.h" -namespace art { +namespace art HIDDEN { /** * Returns true if the from/to types denote a narrowing, integral conversion (precision loss). diff --git a/compiler/optimizing/induction_var_analysis.h b/compiler/optimizing/induction_var_analysis.h index 09417722da..124c3b4e64 100644 --- a/compiler/optimizing/induction_var_analysis.h +++ b/compiler/optimizing/induction_var_analysis.h @@ -21,11 +21,12 @@ #include "base/arena_containers.h" #include "base/array_ref.h" +#include "base/macros.h" #include "base/scoped_arena_containers.h" #include "nodes.h" #include "optimization.h" -namespace art { +namespace art HIDDEN { /** * Induction variable analysis. This class does not have a direct public API. diff --git a/compiler/optimizing/induction_var_analysis_test.cc b/compiler/optimizing/induction_var_analysis_test.cc index 4c11ad4643..80c15371dc 100644 --- a/compiler/optimizing/induction_var_analysis_test.cc +++ b/compiler/optimizing/induction_var_analysis_test.cc @@ -17,12 +17,13 @@ #include <regex> #include "base/arena_allocator.h" +#include "base/macros.h" #include "builder.h" #include "induction_var_analysis.h" #include "nodes.h" #include "optimizing_unit_test.h" -namespace art { +namespace art HIDDEN { /** * Fixture class for the InductionVarAnalysis tests. diff --git a/compiler/optimizing/induction_var_range.cc b/compiler/optimizing/induction_var_range.cc index 7f85483894..9b78699ead 100644 --- a/compiler/optimizing/induction_var_range.cc +++ b/compiler/optimizing/induction_var_range.cc @@ -19,7 +19,7 @@ #include <limits> #include "optimizing/nodes.h" -namespace art { +namespace art HIDDEN { /** Returns true if 64-bit constant fits in 32-bit constant. */ static bool CanLongValueFitIntoInt(int64_t c) { diff --git a/compiler/optimizing/induction_var_range.h b/compiler/optimizing/induction_var_range.h index 6555bc2206..3e1212bec8 100644 --- a/compiler/optimizing/induction_var_range.h +++ b/compiler/optimizing/induction_var_range.h @@ -17,9 +17,10 @@ #ifndef ART_COMPILER_OPTIMIZING_INDUCTION_VAR_RANGE_H_ #define ART_COMPILER_OPTIMIZING_INDUCTION_VAR_RANGE_H_ +#include "base/macros.h" #include "induction_var_analysis.h" -namespace art { +namespace art HIDDEN { /** * This class implements range analysis on expressions within loops. It takes the results diff --git a/compiler/optimizing/induction_var_range_test.cc b/compiler/optimizing/induction_var_range_test.cc index a83246cf13..d879897959 100644 --- a/compiler/optimizing/induction_var_range_test.cc +++ b/compiler/optimizing/induction_var_range_test.cc @@ -17,12 +17,13 @@ #include "induction_var_range.h" #include "base/arena_allocator.h" +#include "base/macros.h" #include "builder.h" #include "induction_var_analysis.h" #include "nodes.h" #include "optimizing_unit_test.h" -namespace art { +namespace art HIDDEN { using Value = InductionVarRange::Value; diff --git a/compiler/optimizing/inliner.cc b/compiler/optimizing/inliner.cc index fe398b045d..e8b9b583ba 100644 --- a/compiler/optimizing/inliner.cc +++ b/compiler/optimizing/inliner.cc @@ -46,7 +46,7 @@ #include "thread.h" #include "verifier/verifier_compiler_binding.h" -namespace art { +namespace art HIDDEN { // Instruction limit to control memory. static constexpr size_t kMaximumNumberOfTotalInstructions = 1024; diff --git a/compiler/optimizing/inliner.h b/compiler/optimizing/inliner.h index 0c36a8aa6d..af067dae73 100644 --- a/compiler/optimizing/inliner.h +++ b/compiler/optimizing/inliner.h @@ -17,13 +17,14 @@ #ifndef ART_COMPILER_OPTIMIZING_INLINER_H_ #define ART_COMPILER_OPTIMIZING_INLINER_H_ +#include "base/macros.h" #include "dex/dex_file_types.h" #include "dex/invoke_type.h" #include "jit/profiling_info.h" #include "optimization.h" #include "profile/profile_compilation_info.h" -namespace art { +namespace art HIDDEN { class CodeGenerator; class DexCompilationUnit; diff --git a/compiler/optimizing/instruction_builder.cc b/compiler/optimizing/instruction_builder.cc index b80e509258..b7c4ba9e05 100644 --- a/compiler/optimizing/instruction_builder.cc +++ b/compiler/optimizing/instruction_builder.cc @@ -42,7 +42,7 @@ #include "ssa_builder.h" #include "well_known_classes.h" -namespace art { +namespace art HIDDEN { namespace { diff --git a/compiler/optimizing/instruction_builder.h b/compiler/optimizing/instruction_builder.h index 817fbaa9e8..3d65d8fb54 100644 --- a/compiler/optimizing/instruction_builder.h +++ b/compiler/optimizing/instruction_builder.h @@ -18,6 +18,7 @@ #define ART_COMPILER_OPTIMIZING_INSTRUCTION_BUILDER_H_ #include "base/array_ref.h" +#include "base/macros.h" #include "base/scoped_arena_allocator.h" #include "base/scoped_arena_containers.h" #include "data_type.h" @@ -27,7 +28,7 @@ #include "handle.h" #include "nodes.h" -namespace art { +namespace art HIDDEN { class ArenaBitVector; class ArtField; diff --git a/compiler/optimizing/instruction_simplifier.cc b/compiler/optimizing/instruction_simplifier.cc index 7d78d7544d..ac212e07fe 100644 --- a/compiler/optimizing/instruction_simplifier.cc +++ b/compiler/optimizing/instruction_simplifier.cc @@ -31,7 +31,7 @@ #include "sharpening.h" #include "string_builder_append.h" -namespace art { +namespace art HIDDEN { // Whether to run an exhaustive test of individual HInstructions cloning when each instruction // is replaced with its copy if it is clonable. diff --git a/compiler/optimizing/instruction_simplifier.h b/compiler/optimizing/instruction_simplifier.h index feea771096..98ebaafebc 100644 --- a/compiler/optimizing/instruction_simplifier.h +++ b/compiler/optimizing/instruction_simplifier.h @@ -17,11 +17,12 @@ #ifndef ART_COMPILER_OPTIMIZING_INSTRUCTION_SIMPLIFIER_H_ #define ART_COMPILER_OPTIMIZING_INSTRUCTION_SIMPLIFIER_H_ +#include "base/macros.h" #include "nodes.h" #include "optimization.h" #include "optimizing_compiler_stats.h" -namespace art { +namespace art HIDDEN { class CodeGenerator; diff --git a/compiler/optimizing/instruction_simplifier_arm.cc b/compiler/optimizing/instruction_simplifier_arm.cc index 1371ea7781..88895b68a3 100644 --- a/compiler/optimizing/instruction_simplifier_arm.cc +++ b/compiler/optimizing/instruction_simplifier_arm.cc @@ -23,7 +23,7 @@ #include "mirror/string.h" #include "nodes.h" -namespace art { +namespace art HIDDEN { using helpers::CanFitInShifterOperand; using helpers::HasShifterOperand; diff --git a/compiler/optimizing/instruction_simplifier_arm.h b/compiler/optimizing/instruction_simplifier_arm.h index fca9341d59..0517e4f49e 100644 --- a/compiler/optimizing/instruction_simplifier_arm.h +++ b/compiler/optimizing/instruction_simplifier_arm.h @@ -17,10 +17,11 @@ #ifndef ART_COMPILER_OPTIMIZING_INSTRUCTION_SIMPLIFIER_ARM_H_ #define ART_COMPILER_OPTIMIZING_INSTRUCTION_SIMPLIFIER_ARM_H_ +#include "base/macros.h" #include "nodes.h" #include "optimization.h" -namespace art { +namespace art HIDDEN { namespace arm { class InstructionSimplifierArm : public HOptimization { diff --git a/compiler/optimizing/instruction_simplifier_arm64.cc b/compiler/optimizing/instruction_simplifier_arm64.cc index a6ec02012c..bed7ff7d55 100644 --- a/compiler/optimizing/instruction_simplifier_arm64.cc +++ b/compiler/optimizing/instruction_simplifier_arm64.cc @@ -21,7 +21,7 @@ #include "mirror/array-inl.h" #include "mirror/string.h" -namespace art { +namespace art HIDDEN { using helpers::CanFitInShifterOperand; using helpers::HasShifterOperand; diff --git a/compiler/optimizing/instruction_simplifier_arm64.h b/compiler/optimizing/instruction_simplifier_arm64.h index 8d93c01ebf..374638ab9e 100644 --- a/compiler/optimizing/instruction_simplifier_arm64.h +++ b/compiler/optimizing/instruction_simplifier_arm64.h @@ -17,10 +17,11 @@ #ifndef ART_COMPILER_OPTIMIZING_INSTRUCTION_SIMPLIFIER_ARM64_H_ #define ART_COMPILER_OPTIMIZING_INSTRUCTION_SIMPLIFIER_ARM64_H_ +#include "base/macros.h" #include "nodes.h" #include "optimization.h" -namespace art { +namespace art HIDDEN { namespace arm64 { class InstructionSimplifierArm64 : public HOptimization { diff --git a/compiler/optimizing/instruction_simplifier_shared.cc b/compiler/optimizing/instruction_simplifier_shared.cc index fb8b01b75a..34daae21ee 100644 --- a/compiler/optimizing/instruction_simplifier_shared.cc +++ b/compiler/optimizing/instruction_simplifier_shared.cc @@ -18,7 +18,7 @@ #include "mirror/array-inl.h" -namespace art { +namespace art HIDDEN { namespace { diff --git a/compiler/optimizing/instruction_simplifier_shared.h b/compiler/optimizing/instruction_simplifier_shared.h index 876ed21a22..ddc3a867b8 100644 --- a/compiler/optimizing/instruction_simplifier_shared.h +++ b/compiler/optimizing/instruction_simplifier_shared.h @@ -17,9 +17,10 @@ #ifndef ART_COMPILER_OPTIMIZING_INSTRUCTION_SIMPLIFIER_SHARED_H_ #define ART_COMPILER_OPTIMIZING_INSTRUCTION_SIMPLIFIER_SHARED_H_ +#include "base/macros.h" #include "nodes.h" -namespace art { +namespace art HIDDEN { namespace helpers { diff --git a/compiler/optimizing/instruction_simplifier_test.cc b/compiler/optimizing/instruction_simplifier_test.cc index c7c5b12e25..d3609537fd 100644 --- a/compiler/optimizing/instruction_simplifier_test.cc +++ b/compiler/optimizing/instruction_simplifier_test.cc @@ -26,7 +26,7 @@ #include "optimizing/data_type.h" #include "optimizing_unit_test.h" -namespace art { +namespace art HIDDEN { namespace mirror { class ClassExt; diff --git a/compiler/optimizing/instruction_simplifier_x86.cc b/compiler/optimizing/instruction_simplifier_x86.cc index 2d8f94a85b..805dd49644 100644 --- a/compiler/optimizing/instruction_simplifier_x86.cc +++ b/compiler/optimizing/instruction_simplifier_x86.cc @@ -17,7 +17,7 @@ #include "instruction_simplifier_x86_shared.h" #include "code_generator_x86.h" -namespace art { +namespace art HIDDEN { namespace x86 { diff --git a/compiler/optimizing/instruction_simplifier_x86.h b/compiler/optimizing/instruction_simplifier_x86.h index 6f10006db2..25ebe203b8 100644 --- a/compiler/optimizing/instruction_simplifier_x86.h +++ b/compiler/optimizing/instruction_simplifier_x86.h @@ -16,10 +16,11 @@ #ifndef ART_COMPILER_OPTIMIZING_INSTRUCTION_SIMPLIFIER_X86_H_ #define ART_COMPILER_OPTIMIZING_INSTRUCTION_SIMPLIFIER_X86_H_ +#include "base/macros.h" #include "nodes.h" #include "optimization.h" -namespace art { +namespace art HIDDEN { class CodeGenerator; namespace x86 { diff --git a/compiler/optimizing/instruction_simplifier_x86_64.cc b/compiler/optimizing/instruction_simplifier_x86_64.cc index 56c6b414d7..b783918879 100644 --- a/compiler/optimizing/instruction_simplifier_x86_64.cc +++ b/compiler/optimizing/instruction_simplifier_x86_64.cc @@ -17,7 +17,7 @@ #include "instruction_simplifier_x86_shared.h" #include "code_generator_x86_64.h" -namespace art { +namespace art HIDDEN { namespace x86_64 { diff --git a/compiler/optimizing/instruction_simplifier_x86_64.h b/compiler/optimizing/instruction_simplifier_x86_64.h index 6cae24d11a..1654dc4774 100644 --- a/compiler/optimizing/instruction_simplifier_x86_64.h +++ b/compiler/optimizing/instruction_simplifier_x86_64.h @@ -16,10 +16,11 @@ #ifndef ART_COMPILER_OPTIMIZING_INSTRUCTION_SIMPLIFIER_X86_64_H_ #define ART_COMPILER_OPTIMIZING_INSTRUCTION_SIMPLIFIER_X86_64_H_ +#include "base/macros.h" #include "nodes.h" #include "optimization.h" -namespace art { +namespace art HIDDEN { class CodeGenerator; diff --git a/compiler/optimizing/instruction_simplifier_x86_shared.cc b/compiler/optimizing/instruction_simplifier_x86_shared.cc index 2805abb2bb..74c5ca2466 100644 --- a/compiler/optimizing/instruction_simplifier_x86_shared.cc +++ b/compiler/optimizing/instruction_simplifier_x86_shared.cc @@ -14,9 +14,10 @@ */ #include "instruction_simplifier_x86_shared.h" + #include "nodes_x86.h" -namespace art { +namespace art HIDDEN { bool TryCombineAndNot(HAnd* instruction) { DataType::Type type = instruction->GetType(); diff --git a/compiler/optimizing/instruction_simplifier_x86_shared.h b/compiler/optimizing/instruction_simplifier_x86_shared.h index 7f94d7ea4c..1a44d0fdb5 100644 --- a/compiler/optimizing/instruction_simplifier_x86_shared.h +++ b/compiler/optimizing/instruction_simplifier_x86_shared.h @@ -16,13 +16,16 @@ #ifndef ART_COMPILER_OPTIMIZING_INSTRUCTION_SIMPLIFIER_X86_SHARED_H_ #define ART_COMPILER_OPTIMIZING_INSTRUCTION_SIMPLIFIER_X86_SHARED_H_ +#include "base/macros.h" #include "nodes.h" -namespace art { +namespace art HIDDEN { + bool TryCombineAndNot(HAnd* instruction); bool TryGenerateResetLeastSetBit(HAnd* instruction); bool TryGenerateMaskUptoLeastSetBit(HXor* instruction); bool AreLeastSetBitInputs(HInstruction* to_test, HInstruction* other); + } // namespace art #endif // ART_COMPILER_OPTIMIZING_INSTRUCTION_SIMPLIFIER_X86_SHARED_H_ diff --git a/compiler/optimizing/intrinsic_objects.cc b/compiler/optimizing/intrinsic_objects.cc index 5f6f562161..7e542117a9 100644 --- a/compiler/optimizing/intrinsic_objects.cc +++ b/compiler/optimizing/intrinsic_objects.cc @@ -22,7 +22,7 @@ #include "image.h" #include "obj_ptr-inl.h" -namespace art { +namespace art HIDDEN { static constexpr size_t kIntrinsicObjectsOffset = enum_cast<size_t>(ImageHeader::kIntrinsicObjectsStart); diff --git a/compiler/optimizing/intrinsic_objects.h b/compiler/optimizing/intrinsic_objects.h index ed764bd4b2..d750f2934b 100644 --- a/compiler/optimizing/intrinsic_objects.h +++ b/compiler/optimizing/intrinsic_objects.h @@ -19,9 +19,10 @@ #include "base/bit_field.h" #include "base/bit_utils.h" +#include "base/macros.h" #include "base/mutex.h" -namespace art { +namespace art HIDDEN { class ClassLinker; template <class MirrorType> class ObjPtr; @@ -56,15 +57,15 @@ class IntrinsicObjects { } // Functions for retrieving data for Integer.valueOf(). - static ObjPtr<mirror::ObjectArray<mirror::Object>> LookupIntegerCache( + EXPORT static ObjPtr<mirror::ObjectArray<mirror::Object>> LookupIntegerCache( Thread* self, ClassLinker* class_linker) REQUIRES_SHARED(Locks::mutator_lock_); - static ObjPtr<mirror::ObjectArray<mirror::Object>> GetIntegerValueOfCache( + EXPORT static ObjPtr<mirror::ObjectArray<mirror::Object>> GetIntegerValueOfCache( ObjPtr<mirror::ObjectArray<mirror::Object>> boot_image_live_objects) REQUIRES_SHARED(Locks::mutator_lock_); - static ObjPtr<mirror::Object> GetIntegerValueOfObject( + EXPORT static ObjPtr<mirror::Object> GetIntegerValueOfObject( ObjPtr<mirror::ObjectArray<mirror::Object>> boot_image_live_objects, uint32_t index) REQUIRES_SHARED(Locks::mutator_lock_); - static MemberOffset GetIntegerValueOfArrayDataOffset( + EXPORT static MemberOffset GetIntegerValueOfArrayDataOffset( ObjPtr<mirror::ObjectArray<mirror::Object>> boot_image_live_objects) REQUIRES_SHARED(Locks::mutator_lock_); diff --git a/compiler/optimizing/intrinsics.cc b/compiler/optimizing/intrinsics.cc index 0feb92d734..aa5e4f3e22 100644 --- a/compiler/optimizing/intrinsics.cc +++ b/compiler/optimizing/intrinsics.cc @@ -32,7 +32,7 @@ #include "scoped_thread_state_change-inl.h" #include "thread-current-inl.h" -namespace art { +namespace art HIDDEN { std::ostream& operator<<(std::ostream& os, const Intrinsics& intrinsic) { switch (intrinsic) { diff --git a/compiler/optimizing/intrinsics.h b/compiler/optimizing/intrinsics.h index 5109882295..893cd04411 100644 --- a/compiler/optimizing/intrinsics.h +++ b/compiler/optimizing/intrinsics.h @@ -17,12 +17,13 @@ #ifndef ART_COMPILER_OPTIMIZING_INTRINSICS_H_ #define ART_COMPILER_OPTIMIZING_INTRINSICS_H_ +#include "base/macros.h" #include "code_generator.h" #include "nodes.h" #include "optimization.h" #include "parallel_move_resolver.h" -namespace art { +namespace art HIDDEN { class DexFile; diff --git a/compiler/optimizing/intrinsics_arm64.cc b/compiler/optimizing/intrinsics_arm64.cc index 0ce082b12b..f61d3ba69c 100644 --- a/compiler/optimizing/intrinsics_arm64.cc +++ b/compiler/optimizing/intrinsics_arm64.cc @@ -46,7 +46,7 @@ using namespace vixl::aarch64; // NOLINT(build/namespaces) #include "aarch64/macro-assembler-aarch64.h" #pragma GCC diagnostic pop -namespace art { +namespace art HIDDEN { namespace arm64 { diff --git a/compiler/optimizing/intrinsics_arm64.h b/compiler/optimizing/intrinsics_arm64.h index 9c46efddec..a0ccf87f7b 100644 --- a/compiler/optimizing/intrinsics_arm64.h +++ b/compiler/optimizing/intrinsics_arm64.h @@ -17,6 +17,7 @@ #ifndef ART_COMPILER_OPTIMIZING_INTRINSICS_ARM64_H_ #define ART_COMPILER_OPTIMIZING_INTRINSICS_ARM64_H_ +#include "base/macros.h" #include "intrinsics.h" namespace vixl { @@ -27,7 +28,7 @@ class MacroAssembler; } // namespace aarch64 } // namespace vixl -namespace art { +namespace art HIDDEN { class ArenaAllocator; class HInvokeStaticOrDirect; diff --git a/compiler/optimizing/intrinsics_arm_vixl.cc b/compiler/optimizing/intrinsics_arm_vixl.cc index da47fa6cf0..645c774a81 100644 --- a/compiler/optimizing/intrinsics_arm_vixl.cc +++ b/compiler/optimizing/intrinsics_arm_vixl.cc @@ -34,7 +34,7 @@ #include "aarch32/constants-aarch32.h" -namespace art { +namespace art HIDDEN { namespace arm { #define __ assembler->GetVIXLAssembler()-> diff --git a/compiler/optimizing/intrinsics_arm_vixl.h b/compiler/optimizing/intrinsics_arm_vixl.h index 3103cec8f0..54475bcc7e 100644 --- a/compiler/optimizing/intrinsics_arm_vixl.h +++ b/compiler/optimizing/intrinsics_arm_vixl.h @@ -17,10 +17,11 @@ #ifndef ART_COMPILER_OPTIMIZING_INTRINSICS_ARM_VIXL_H_ #define ART_COMPILER_OPTIMIZING_INTRINSICS_ARM_VIXL_H_ +#include "base/macros.h" #include "intrinsics.h" #include "utils/arm/assembler_arm_vixl.h" -namespace art { +namespace art HIDDEN { namespace arm { diff --git a/compiler/optimizing/intrinsics_utils.h b/compiler/optimizing/intrinsics_utils.h index 19f5e332a8..13cabdafed 100644 --- a/compiler/optimizing/intrinsics_utils.h +++ b/compiler/optimizing/intrinsics_utils.h @@ -29,7 +29,7 @@ #include "utils/assembler.h" #include "utils/label.h" -namespace art { +namespace art HIDDEN { // Default slow-path for fallback (calling the managed code to handle the intrinsic) in an // intrinsified call. This will copy the arguments into the positions for a regular call. diff --git a/compiler/optimizing/intrinsics_x86.cc b/compiler/optimizing/intrinsics_x86.cc index 0f6eb8638a..88c125d4a9 100644 --- a/compiler/optimizing/intrinsics_x86.cc +++ b/compiler/optimizing/intrinsics_x86.cc @@ -38,7 +38,7 @@ #include "utils/x86/assembler_x86.h" #include "utils/x86/constants_x86.h" -namespace art { +namespace art HIDDEN { namespace x86 { diff --git a/compiler/optimizing/intrinsics_x86.h b/compiler/optimizing/intrinsics_x86.h index ae150dad43..77c236d244 100644 --- a/compiler/optimizing/intrinsics_x86.h +++ b/compiler/optimizing/intrinsics_x86.h @@ -17,9 +17,10 @@ #ifndef ART_COMPILER_OPTIMIZING_INTRINSICS_X86_H_ #define ART_COMPILER_OPTIMIZING_INTRINSICS_X86_H_ +#include "base/macros.h" #include "intrinsics.h" -namespace art { +namespace art HIDDEN { class ArenaAllocator; class HInvokeStaticOrDirect; diff --git a/compiler/optimizing/intrinsics_x86_64.cc b/compiler/optimizing/intrinsics_x86_64.cc index 9921d907d5..98702e64b9 100644 --- a/compiler/optimizing/intrinsics_x86_64.cc +++ b/compiler/optimizing/intrinsics_x86_64.cc @@ -36,7 +36,7 @@ #include "utils/x86_64/assembler_x86_64.h" #include "utils/x86_64/constants_x86_64.h" -namespace art { +namespace art HIDDEN { namespace x86_64 { diff --git a/compiler/optimizing/intrinsics_x86_64.h b/compiler/optimizing/intrinsics_x86_64.h index 199cfede1a..59fe815a94 100644 --- a/compiler/optimizing/intrinsics_x86_64.h +++ b/compiler/optimizing/intrinsics_x86_64.h @@ -17,9 +17,10 @@ #ifndef ART_COMPILER_OPTIMIZING_INTRINSICS_X86_64_H_ #define ART_COMPILER_OPTIMIZING_INTRINSICS_X86_64_H_ +#include "base/macros.h" #include "intrinsics.h" -namespace art { +namespace art HIDDEN { class ArenaAllocator; class HInvokeStaticOrDirect; diff --git a/compiler/optimizing/licm.cc b/compiler/optimizing/licm.cc index 0edb23b857..0c791b640d 100644 --- a/compiler/optimizing/licm.cc +++ b/compiler/optimizing/licm.cc @@ -18,7 +18,7 @@ #include "side_effects_analysis.h" -namespace art { +namespace art HIDDEN { static bool IsPhiOf(HInstruction* instruction, HBasicBlock* block) { return instruction->IsPhi() && instruction->GetBlock() == block; diff --git a/compiler/optimizing/licm.h b/compiler/optimizing/licm.h index 9cafddb05a..1a86b6eb9f 100644 --- a/compiler/optimizing/licm.h +++ b/compiler/optimizing/licm.h @@ -17,10 +17,11 @@ #ifndef ART_COMPILER_OPTIMIZING_LICM_H_ #define ART_COMPILER_OPTIMIZING_LICM_H_ +#include "base/macros.h" #include "nodes.h" #include "optimization.h" -namespace art { +namespace art HIDDEN { class SideEffectsAnalysis; diff --git a/compiler/optimizing/licm_test.cc b/compiler/optimizing/licm_test.cc index adc3cabe87..f8481099f4 100644 --- a/compiler/optimizing/licm_test.cc +++ b/compiler/optimizing/licm_test.cc @@ -17,12 +17,13 @@ #include "licm.h" #include "base/arena_allocator.h" +#include "base/macros.h" #include "builder.h" #include "nodes.h" #include "optimizing_unit_test.h" #include "side_effects_analysis.h" -namespace art { +namespace art HIDDEN { /** * Fixture class for the LICM tests. diff --git a/compiler/optimizing/linear_order.cc b/compiler/optimizing/linear_order.cc index 58e00a810d..25ca866b2c 100644 --- a/compiler/optimizing/linear_order.cc +++ b/compiler/optimizing/linear_order.cc @@ -19,7 +19,7 @@ #include "base/scoped_arena_allocator.h" #include "base/scoped_arena_containers.h" -namespace art { +namespace art HIDDEN { static bool InSameLoop(HLoopInformation* first_loop, HLoopInformation* second_loop) { return first_loop == second_loop; diff --git a/compiler/optimizing/linear_order.h b/compiler/optimizing/linear_order.h index 151db001e1..75e75048a3 100644 --- a/compiler/optimizing/linear_order.h +++ b/compiler/optimizing/linear_order.h @@ -19,9 +19,10 @@ #include <type_traits> +#include "base/macros.h" #include "nodes.h" -namespace art { +namespace art HIDDEN { void LinearizeGraphInternal(const HGraph* graph, ArrayRef<HBasicBlock*> linear_order); diff --git a/compiler/optimizing/linearize_test.cc b/compiler/optimizing/linearize_test.cc index d56ae11ca9..b39bac5acf 100644 --- a/compiler/optimizing/linearize_test.cc +++ b/compiler/optimizing/linearize_test.cc @@ -17,6 +17,7 @@ #include <fstream> #include "base/arena_allocator.h" +#include "base/macros.h" #include "builder.h" #include "code_generator.h" #include "dex/dex_file.h" @@ -28,7 +29,7 @@ #include "pretty_printer.h" #include "ssa_liveness_analysis.h" -namespace art { +namespace art HIDDEN { class LinearizeTest : public OptimizingUnitTest { protected: diff --git a/compiler/optimizing/live_interval_test.cc b/compiler/optimizing/live_interval_test.cc index c60386d7b7..b5d1336d4a 100644 --- a/compiler/optimizing/live_interval_test.cc +++ b/compiler/optimizing/live_interval_test.cc @@ -15,12 +15,13 @@ */ #include "base/arena_allocator.h" +#include "base/macros.h" #include "optimizing_unit_test.h" #include "ssa_liveness_analysis.h" #include "gtest/gtest.h" -namespace art { +namespace art HIDDEN { TEST(LiveInterval, GetStart) { ArenaPoolAndAllocator pool; diff --git a/compiler/optimizing/live_ranges_test.cc b/compiler/optimizing/live_ranges_test.cc index bb8a4dc08e..4f52fdb7f3 100644 --- a/compiler/optimizing/live_ranges_test.cc +++ b/compiler/optimizing/live_ranges_test.cc @@ -15,6 +15,7 @@ */ #include "base/arena_allocator.h" +#include "base/macros.h" #include "builder.h" #include "code_generator.h" #include "dex/dex_file.h" @@ -25,7 +26,7 @@ #include "prepare_for_register_allocation.h" #include "ssa_liveness_analysis.h" -namespace art { +namespace art HIDDEN { class LiveRangesTest : public OptimizingUnitTest { protected: diff --git a/compiler/optimizing/liveness_test.cc b/compiler/optimizing/liveness_test.cc index ba3787e9be..a2763731b4 100644 --- a/compiler/optimizing/liveness_test.cc +++ b/compiler/optimizing/liveness_test.cc @@ -15,6 +15,7 @@ */ #include "base/arena_allocator.h" +#include "base/macros.h" #include "builder.h" #include "code_generator.h" #include "dex/dex_file.h" @@ -25,7 +26,7 @@ #include "prepare_for_register_allocation.h" #include "ssa_liveness_analysis.h" -namespace art { +namespace art HIDDEN { class LivenessTest : public OptimizingUnitTest { protected: diff --git a/compiler/optimizing/load_store_analysis.cc b/compiler/optimizing/load_store_analysis.cc index 5e4cffab84..f1c50ac03c 100644 --- a/compiler/optimizing/load_store_analysis.cc +++ b/compiler/optimizing/load_store_analysis.cc @@ -19,7 +19,7 @@ #include "base/scoped_arena_allocator.h" #include "optimizing/escape.h" -namespace art { +namespace art HIDDEN { // A cap for the number of heap locations to prevent pathological time/space consumption. // The number of heap locations for most of the methods stays below this threshold. diff --git a/compiler/optimizing/load_store_analysis.h b/compiler/optimizing/load_store_analysis.h index b12e70b194..c0799dbe9e 100644 --- a/compiler/optimizing/load_store_analysis.h +++ b/compiler/optimizing/load_store_analysis.h @@ -20,6 +20,7 @@ #include "base/arena_allocator.h" #include "base/arena_bit_vector.h" #include "base/bit_vector-inl.h" +#include "base/macros.h" #include "base/scoped_arena_allocator.h" #include "base/scoped_arena_containers.h" #include "base/stl_util.h" @@ -28,7 +29,7 @@ #include "nodes.h" #include "optimizing/optimizing_compiler_stats.h" -namespace art { +namespace art HIDDEN { enum class LoadStoreAnalysisType { kBasic, diff --git a/compiler/optimizing/load_store_analysis_test.cc b/compiler/optimizing/load_store_analysis_test.cc index 3c26c8d6ce..7930c0d23c 100644 --- a/compiler/optimizing/load_store_analysis_test.cc +++ b/compiler/optimizing/load_store_analysis_test.cc @@ -14,6 +14,7 @@ * limitations under the License. */ +#include "base/macros.h" #include "load_store_analysis.h" #include <array> @@ -36,7 +37,7 @@ #include "optimizing_unit_test.h" #include "scoped_thread_state_change.h" -namespace art { +namespace art HIDDEN { class LoadStoreAnalysisTest : public CommonCompilerTest, public OptimizingUnitTestHelper { public: diff --git a/compiler/optimizing/load_store_elimination.cc b/compiler/optimizing/load_store_elimination.cc index 2ee836a9bd..b385e035d3 100644 --- a/compiler/optimizing/load_store_elimination.cc +++ b/compiler/optimizing/load_store_elimination.cc @@ -319,7 +319,7 @@ * a hash map to the HeapLocationCollector. */ -namespace art { +namespace art HIDDEN { #define LSE_VLOG \ if (::art::LoadStoreElimination::kVerboseLoggingMode && VLOG_IS_ON(compiler)) LOG(INFO) diff --git a/compiler/optimizing/load_store_elimination.h b/compiler/optimizing/load_store_elimination.h index 6ad2eb2c51..42de803ebd 100644 --- a/compiler/optimizing/load_store_elimination.h +++ b/compiler/optimizing/load_store_elimination.h @@ -17,9 +17,10 @@ #ifndef ART_COMPILER_OPTIMIZING_LOAD_STORE_ELIMINATION_H_ #define ART_COMPILER_OPTIMIZING_LOAD_STORE_ELIMINATION_H_ +#include "base/macros.h" #include "optimization.h" -namespace art { +namespace art HIDDEN { class SideEffectsAnalysis; diff --git a/compiler/optimizing/load_store_elimination_test.cc b/compiler/optimizing/load_store_elimination_test.cc index 02dc939878..d19b079991 100644 --- a/compiler/optimizing/load_store_elimination_test.cc +++ b/compiler/optimizing/load_store_elimination_test.cc @@ -36,7 +36,7 @@ #include "optimizing_unit_test.h" #include "scoped_thread_state_change.h" -namespace art { +namespace art HIDDEN { #define CHECK_SUBROUTINE_FAILURE() \ do { \ diff --git a/compiler/optimizing/locations.cc b/compiler/optimizing/locations.cc index 5879c6fa07..595064f8e5 100644 --- a/compiler/optimizing/locations.cc +++ b/compiler/optimizing/locations.cc @@ -21,7 +21,7 @@ #include "code_generator.h" #include "nodes.h" -namespace art { +namespace art HIDDEN { // Verify that Location is trivially copyable. static_assert(std::is_trivially_copyable<Location>::value, "Location should be trivially copyable"); diff --git a/compiler/optimizing/locations.h b/compiler/optimizing/locations.h index acaea71a49..dc87284a7a 100644 --- a/compiler/optimizing/locations.h +++ b/compiler/optimizing/locations.h @@ -22,9 +22,10 @@ #include "base/bit_field.h" #include "base/bit_utils.h" #include "base/bit_vector.h" +#include "base/macros.h" #include "base/value_object.h" -namespace art { +namespace art HIDDEN { class HConstant; class HInstruction; diff --git a/compiler/optimizing/loop_analysis.cc b/compiler/optimizing/loop_analysis.cc index 76bd8493b2..95e81533da 100644 --- a/compiler/optimizing/loop_analysis.cc +++ b/compiler/optimizing/loop_analysis.cc @@ -20,7 +20,7 @@ #include "code_generator.h" #include "induction_var_range.h" -namespace art { +namespace art HIDDEN { void LoopAnalysis::CalculateLoopBasicProperties(HLoopInformation* loop_info, LoopAnalysisInfo* analysis_results, diff --git a/compiler/optimizing/loop_analysis.h b/compiler/optimizing/loop_analysis.h index fbf1516f64..cec00fecf4 100644 --- a/compiler/optimizing/loop_analysis.h +++ b/compiler/optimizing/loop_analysis.h @@ -17,9 +17,10 @@ #ifndef ART_COMPILER_OPTIMIZING_LOOP_ANALYSIS_H_ #define ART_COMPILER_OPTIMIZING_LOOP_ANALYSIS_H_ +#include "base/macros.h" #include "nodes.h" -namespace art { +namespace art HIDDEN { class CodeGenerator; class InductionVarRange; diff --git a/compiler/optimizing/loop_optimization.cc b/compiler/optimizing/loop_optimization.cc index 604d3d2522..001649cb9f 100644 --- a/compiler/optimizing/loop_optimization.cc +++ b/compiler/optimizing/loop_optimization.cc @@ -27,7 +27,7 @@ #include "mirror/array-inl.h" #include "mirror/string.h" -namespace art { +namespace art HIDDEN { // Enables vectorization (SIMDization) in the loop optimizer. static constexpr bool kEnableVectorization = true; diff --git a/compiler/optimizing/loop_optimization.h b/compiler/optimizing/loop_optimization.h index 0535c74e91..6dd778ba74 100644 --- a/compiler/optimizing/loop_optimization.h +++ b/compiler/optimizing/loop_optimization.h @@ -17,6 +17,7 @@ #ifndef ART_COMPILER_OPTIMIZING_LOOP_OPTIMIZATION_H_ #define ART_COMPILER_OPTIMIZING_LOOP_OPTIMIZATION_H_ +#include "base/macros.h" #include "base/scoped_arena_allocator.h" #include "base/scoped_arena_containers.h" #include "induction_var_range.h" @@ -25,7 +26,7 @@ #include "optimization.h" #include "superblock_cloner.h" -namespace art { +namespace art HIDDEN { class CompilerOptions; class ArchNoOptsLoopHelper; diff --git a/compiler/optimizing/loop_optimization_test.cc b/compiler/optimizing/loop_optimization_test.cc index bda25283f5..71c69886f6 100644 --- a/compiler/optimizing/loop_optimization_test.cc +++ b/compiler/optimizing/loop_optimization_test.cc @@ -14,12 +14,13 @@ * limitations under the License. */ +#include "base/macros.h" #include "code_generator.h" #include "driver/compiler_options.h" #include "loop_optimization.h" #include "optimizing_unit_test.h" -namespace art { +namespace art HIDDEN { /** * Fixture class for the loop optimization tests. These unit tests focus diff --git a/compiler/optimizing/nodes.cc b/compiler/optimizing/nodes.cc index 8c88c503a3..d40ce7a717 100644 --- a/compiler/optimizing/nodes.cc +++ b/compiler/optimizing/nodes.cc @@ -40,7 +40,7 @@ #include "scoped_thread_state_change-inl.h" #include "ssa_builder.h" -namespace art { +namespace art HIDDEN { // Enable floating-point static evaluation during constant folding // only if all floating-point operations and constants evaluate in the diff --git a/compiler/optimizing/nodes.h b/compiler/optimizing/nodes.h index 278d232b23..17ede39d1e 100644 --- a/compiler/optimizing/nodes.h +++ b/compiler/optimizing/nodes.h @@ -29,6 +29,7 @@ #include "base/array_ref.h" #include "base/intrusive_forward_list.h" #include "base/iteration_range.h" +#include "base/macros.h" #include "base/mutex.h" #include "base/quasi_atomic.h" #include "base/stl_util.h" @@ -51,7 +52,7 @@ #include "mirror/method_type.h" #include "offsets.h" -namespace art { +namespace art HIDDEN { class ArenaStack; class CodeGenerator; @@ -8456,7 +8457,7 @@ class HIntermediateAddress final : public HExpression<2> { #include "nodes_x86.h" #endif -namespace art { +namespace art HIDDEN { class OptimizingCompilerStats; diff --git a/compiler/optimizing/nodes_shared.cc b/compiler/optimizing/nodes_shared.cc index eca97d7a70..b3a7ad9a05 100644 --- a/compiler/optimizing/nodes_shared.cc +++ b/compiler/optimizing/nodes_shared.cc @@ -23,7 +23,7 @@ #include "instruction_simplifier_shared.h" -namespace art { +namespace art HIDDEN { using helpers::CanFitInShifterOperand; diff --git a/compiler/optimizing/nodes_shared.h b/compiler/optimizing/nodes_shared.h index 7dcac1787e..27e610328f 100644 --- a/compiler/optimizing/nodes_shared.h +++ b/compiler/optimizing/nodes_shared.h @@ -22,7 +22,7 @@ // (defining `HInstruction` and co). #include "nodes.h" -namespace art { +namespace art HIDDEN { class HMultiplyAccumulate final : public HExpression<3> { public: diff --git a/compiler/optimizing/nodes_test.cc b/compiler/optimizing/nodes_test.cc index 34f0e9b1e1..29210fe10f 100644 --- a/compiler/optimizing/nodes_test.cc +++ b/compiler/optimizing/nodes_test.cc @@ -17,11 +17,12 @@ #include "nodes.h" #include "base/arena_allocator.h" +#include "base/macros.h" #include "optimizing_unit_test.h" #include "gtest/gtest.h" -namespace art { +namespace art HIDDEN { class NodeTest : public OptimizingUnitTest {}; diff --git a/compiler/optimizing/nodes_vector.h b/compiler/optimizing/nodes_vector.h index a2cd86dc33..73f6c40a0d 100644 --- a/compiler/optimizing/nodes_vector.h +++ b/compiler/optimizing/nodes_vector.h @@ -21,7 +21,7 @@ // is included in the header file nodes.h itself. However it gives editing tools better context. #include "nodes.h" -namespace art { +namespace art HIDDEN { // Memory alignment, represented as an offset relative to a base, where 0 <= offset < base, // and base is a power of two. For example, the value Alignment(16, 0) means memory is diff --git a/compiler/optimizing/nodes_vector_test.cc b/compiler/optimizing/nodes_vector_test.cc index b0a665d704..e0a48db84f 100644 --- a/compiler/optimizing/nodes_vector_test.cc +++ b/compiler/optimizing/nodes_vector_test.cc @@ -15,10 +15,11 @@ */ #include "base/arena_allocator.h" +#include "base/macros.h" #include "nodes.h" #include "optimizing_unit_test.h" -namespace art { +namespace art HIDDEN { /** * Fixture class for testing vector nodes. diff --git a/compiler/optimizing/nodes_x86.h b/compiler/optimizing/nodes_x86.h index 8e8fbc1581..e246390aa5 100644 --- a/compiler/optimizing/nodes_x86.h +++ b/compiler/optimizing/nodes_x86.h @@ -17,7 +17,7 @@ #ifndef ART_COMPILER_OPTIMIZING_NODES_X86_H_ #define ART_COMPILER_OPTIMIZING_NODES_X86_H_ -namespace art { +namespace art HIDDEN { // Compute the address of the method for X86 Constant area support. class HX86ComputeBaseMethodAddress final : public HExpression<0> { diff --git a/compiler/optimizing/optimization.cc b/compiler/optimizing/optimization.cc index 2b7beddfab..e0c5933657 100644 --- a/compiler/optimizing/optimization.cc +++ b/compiler/optimizing/optimization.cc @@ -58,7 +58,7 @@ // Decide between default or alternative pass name. -namespace art { +namespace art HIDDEN { const char* OptimizationPassName(OptimizationPass pass) { switch (pass) { diff --git a/compiler/optimizing/optimization.h b/compiler/optimizing/optimization.h index 2113df0c81..76960bf314 100644 --- a/compiler/optimizing/optimization.h +++ b/compiler/optimizing/optimization.h @@ -18,10 +18,11 @@ #define ART_COMPILER_OPTIMIZING_OPTIMIZATION_H_ #include "base/arena_object.h" +#include "base/macros.h" #include "nodes.h" #include "optimizing_compiler_stats.h" -namespace art { +namespace art HIDDEN { class CodeGenerator; class DexCompilationUnit; diff --git a/compiler/optimizing/optimizing_cfi_test.cc b/compiler/optimizing/optimizing_cfi_test.cc index 73e1fbea55..f12e748941 100644 --- a/compiler/optimizing/optimizing_cfi_test.cc +++ b/compiler/optimizing/optimizing_cfi_test.cc @@ -18,6 +18,7 @@ #include <vector> #include "arch/instruction_set.h" +#include "base/macros.h" #include "base/runtime_debug.h" #include "cfi_test.h" #include "driver/compiler_options.h" @@ -32,7 +33,7 @@ namespace vixl32 = vixl::aarch32; -namespace art { +namespace art HIDDEN { // Run the tests only on host. #ifndef ART_TARGET_ANDROID diff --git a/compiler/optimizing/optimizing_compiler.cc b/compiler/optimizing/optimizing_compiler.cc index 76e35963db..f394635ede 100644 --- a/compiler/optimizing/optimizing_compiler.cc +++ b/compiler/optimizing/optimizing_compiler.cc @@ -61,7 +61,7 @@ #include "stack_map_stream.h" #include "utils/assembler.h" -namespace art { +namespace art HIDDEN { static constexpr size_t kArenaAllocatorMemoryReportThreshold = 8 * MB; diff --git a/compiler/optimizing/optimizing_compiler.h b/compiler/optimizing/optimizing_compiler.h index 95c5c0a861..737ffd034a 100644 --- a/compiler/optimizing/optimizing_compiler.h +++ b/compiler/optimizing/optimizing_compiler.h @@ -18,9 +18,10 @@ #define ART_COMPILER_OPTIMIZING_OPTIMIZING_COMPILER_H_ #include "base/globals.h" +#include "base/macros.h" #include "base/mutex.h" -namespace art { +namespace art HIDDEN { class ArtMethod; class CompiledCodeStorage; diff --git a/compiler/optimizing/optimizing_compiler_stats.h b/compiler/optimizing/optimizing_compiler_stats.h index 96dfdacead..192519bdd4 100644 --- a/compiler/optimizing/optimizing_compiler_stats.h +++ b/compiler/optimizing/optimizing_compiler_stats.h @@ -26,8 +26,9 @@ #include "base/atomic.h" #include "base/globals.h" +#include "base/macros.h" -namespace art { +namespace art HIDDEN { enum class MethodCompilationStat { kAttemptBytecodeCompilation = 0, diff --git a/compiler/optimizing/optimizing_unit_test.h b/compiler/optimizing/optimizing_unit_test.h index df211838d7..e62ccf0f3a 100644 --- a/compiler/optimizing/optimizing_unit_test.h +++ b/compiler/optimizing/optimizing_unit_test.h @@ -25,6 +25,7 @@ #include <vector> #include <variant> +#include "base/macros.h" #include "base/indenter.h" #include "base/malloc_arena_pool.h" #include "base/scoped_arena_allocator.h" @@ -46,7 +47,7 @@ #include "ssa_builder.h" #include "ssa_liveness_analysis.h" -namespace art { +namespace art HIDDEN { #define NUM_INSTRUCTIONS(...) \ (sizeof((uint16_t[]) {__VA_ARGS__}) /sizeof(uint16_t)) diff --git a/compiler/optimizing/parallel_move_resolver.cc b/compiler/optimizing/parallel_move_resolver.cc index 2036b4a370..9fc4cc86bf 100644 --- a/compiler/optimizing/parallel_move_resolver.cc +++ b/compiler/optimizing/parallel_move_resolver.cc @@ -19,7 +19,7 @@ #include "base/stl_util.h" #include "nodes.h" -namespace art { +namespace art HIDDEN { void ParallelMoveResolver::BuildInitialMoveList(HParallelMove* parallel_move) { // Perform a linear sweep of the moves to add them to the initial list of diff --git a/compiler/optimizing/parallel_move_resolver.h b/compiler/optimizing/parallel_move_resolver.h index 5fadcab402..17d5122542 100644 --- a/compiler/optimizing/parallel_move_resolver.h +++ b/compiler/optimizing/parallel_move_resolver.h @@ -18,11 +18,12 @@ #define ART_COMPILER_OPTIMIZING_PARALLEL_MOVE_RESOLVER_H_ #include "base/arena_containers.h" +#include "base/macros.h" #include "base/value_object.h" #include "data_type.h" #include "locations.h" -namespace art { +namespace art HIDDEN { class HParallelMove; class MoveOperands; diff --git a/compiler/optimizing/parallel_move_test.cc b/compiler/optimizing/parallel_move_test.cc index a8ab6cdd0c..a1c05e9cad 100644 --- a/compiler/optimizing/parallel_move_test.cc +++ b/compiler/optimizing/parallel_move_test.cc @@ -15,6 +15,7 @@ */ #include "base/arena_allocator.h" +#include "base/macros.h" #include "base/malloc_arena_pool.h" #include "nodes.h" #include "parallel_move_resolver.h" @@ -22,7 +23,7 @@ #include "gtest/gtest-typed-test.h" #include "gtest/gtest.h" -namespace art { +namespace art HIDDEN { constexpr int kScratchRegisterStartIndexForTest = 100; diff --git a/compiler/optimizing/pc_relative_fixups_x86.cc b/compiler/optimizing/pc_relative_fixups_x86.cc index 17f37f05c5..b7e773f541 100644 --- a/compiler/optimizing/pc_relative_fixups_x86.cc +++ b/compiler/optimizing/pc_relative_fixups_x86.cc @@ -18,7 +18,7 @@ #include "code_generator_x86.h" #include "intrinsics_x86.h" -namespace art { +namespace art HIDDEN { namespace x86 { /** diff --git a/compiler/optimizing/pc_relative_fixups_x86.h b/compiler/optimizing/pc_relative_fixups_x86.h index 3b470a6502..45578d8050 100644 --- a/compiler/optimizing/pc_relative_fixups_x86.h +++ b/compiler/optimizing/pc_relative_fixups_x86.h @@ -17,10 +17,11 @@ #ifndef ART_COMPILER_OPTIMIZING_PC_RELATIVE_FIXUPS_X86_H_ #define ART_COMPILER_OPTIMIZING_PC_RELATIVE_FIXUPS_X86_H_ +#include "base/macros.h" #include "nodes.h" #include "optimization.h" -namespace art { +namespace art HIDDEN { class CodeGenerator; diff --git a/compiler/optimizing/prepare_for_register_allocation.cc b/compiler/optimizing/prepare_for_register_allocation.cc index c2f3d0e741..91c1beac8e 100644 --- a/compiler/optimizing/prepare_for_register_allocation.cc +++ b/compiler/optimizing/prepare_for_register_allocation.cc @@ -22,7 +22,7 @@ #include "optimizing_compiler_stats.h" #include "well_known_classes.h" -namespace art { +namespace art HIDDEN { void PrepareForRegisterAllocation::Run() { // Order does not matter. diff --git a/compiler/optimizing/prepare_for_register_allocation.h b/compiler/optimizing/prepare_for_register_allocation.h index e0bb76eb22..0426f8470b 100644 --- a/compiler/optimizing/prepare_for_register_allocation.h +++ b/compiler/optimizing/prepare_for_register_allocation.h @@ -17,9 +17,10 @@ #ifndef ART_COMPILER_OPTIMIZING_PREPARE_FOR_REGISTER_ALLOCATION_H_ #define ART_COMPILER_OPTIMIZING_PREPARE_FOR_REGISTER_ALLOCATION_H_ +#include "base/macros.h" #include "nodes.h" -namespace art { +namespace art HIDDEN { class CompilerOptions; class OptimizingCompilerStats; diff --git a/compiler/optimizing/pretty_printer.h b/compiler/optimizing/pretty_printer.h index 8ef9ce4e8b..77ddb97707 100644 --- a/compiler/optimizing/pretty_printer.h +++ b/compiler/optimizing/pretty_printer.h @@ -19,9 +19,10 @@ #include "android-base/stringprintf.h" +#include "base/macros.h" #include "nodes.h" -namespace art { +namespace art HIDDEN { class HPrettyPrinter : public HGraphVisitor { public: diff --git a/compiler/optimizing/pretty_printer_test.cc b/compiler/optimizing/pretty_printer_test.cc index 6ef386b4a5..5ed39442bf 100644 --- a/compiler/optimizing/pretty_printer_test.cc +++ b/compiler/optimizing/pretty_printer_test.cc @@ -17,6 +17,7 @@ #include "pretty_printer.h" #include "base/arena_allocator.h" +#include "base/macros.h" #include "builder.h" #include "dex/dex_file.h" #include "dex/dex_instruction.h" @@ -25,7 +26,7 @@ #include "gtest/gtest.h" -namespace art { +namespace art HIDDEN { class PrettyPrinterTest : public OptimizingUnitTest { protected: diff --git a/compiler/optimizing/reference_type_propagation.cc b/compiler/optimizing/reference_type_propagation.cc index 3bfacde612..cfbf2aac76 100644 --- a/compiler/optimizing/reference_type_propagation.cc +++ b/compiler/optimizing/reference_type_propagation.cc @@ -29,7 +29,7 @@ #include "mirror/dex_cache.h" #include "scoped_thread_state_change-inl.h" -namespace art { +namespace art HIDDEN { static inline ObjPtr<mirror::DexCache> FindDexCacheWithHint( Thread* self, const DexFile& dex_file, Handle<mirror::DexCache> hint_dex_cache) diff --git a/compiler/optimizing/reference_type_propagation.h b/compiler/optimizing/reference_type_propagation.h index e2e178a9d8..d696e28bc2 100644 --- a/compiler/optimizing/reference_type_propagation.h +++ b/compiler/optimizing/reference_type_propagation.h @@ -18,12 +18,13 @@ #define ART_COMPILER_OPTIMIZING_REFERENCE_TYPE_PROPAGATION_H_ #include "base/arena_containers.h" +#include "base/macros.h" #include "mirror/class-inl.h" #include "nodes.h" #include "obj_ptr.h" #include "optimization.h" -namespace art { +namespace art HIDDEN { /** * Propagates reference types to instructions. diff --git a/compiler/optimizing/reference_type_propagation_test.cc b/compiler/optimizing/reference_type_propagation_test.cc index 839b1c6e43..2b012fcd67 100644 --- a/compiler/optimizing/reference_type_propagation_test.cc +++ b/compiler/optimizing/reference_type_propagation_test.cc @@ -19,6 +19,7 @@ #include <random> #include "base/arena_allocator.h" +#include "base/macros.h" #include "base/transform_array_ref.h" #include "base/transform_iterator.h" #include "builder.h" @@ -26,7 +27,7 @@ #include "object_lock.h" #include "optimizing_unit_test.h" -namespace art { +namespace art HIDDEN { // TODO It would be good to use the following but there is a miniscule amount of // chance for flakiness so we'll just use a set seed instead. diff --git a/compiler/optimizing/register_allocation_resolver.cc b/compiler/optimizing/register_allocation_resolver.cc index 875c633889..53e11f2c3d 100644 --- a/compiler/optimizing/register_allocation_resolver.cc +++ b/compiler/optimizing/register_allocation_resolver.cc @@ -21,7 +21,7 @@ #include "linear_order.h" #include "ssa_liveness_analysis.h" -namespace art { +namespace art HIDDEN { RegisterAllocationResolver::RegisterAllocationResolver(CodeGenerator* codegen, const SsaLivenessAnalysis& liveness) diff --git a/compiler/optimizing/register_allocation_resolver.h b/compiler/optimizing/register_allocation_resolver.h index 278371777d..f4782eb48e 100644 --- a/compiler/optimizing/register_allocation_resolver.h +++ b/compiler/optimizing/register_allocation_resolver.h @@ -18,10 +18,11 @@ #define ART_COMPILER_OPTIMIZING_REGISTER_ALLOCATION_RESOLVER_H_ #include "base/array_ref.h" +#include "base/macros.h" #include "base/value_object.h" #include "data_type.h" -namespace art { +namespace art HIDDEN { class ArenaAllocator; class CodeGenerator; diff --git a/compiler/optimizing/register_allocator.cc b/compiler/optimizing/register_allocator.cc index a9c217fc4f..e4c2d74908 100644 --- a/compiler/optimizing/register_allocator.cc +++ b/compiler/optimizing/register_allocator.cc @@ -27,7 +27,7 @@ #include "register_allocator_linear_scan.h" #include "ssa_liveness_analysis.h" -namespace art { +namespace art HIDDEN { RegisterAllocator::RegisterAllocator(ScopedArenaAllocator* allocator, CodeGenerator* codegen, diff --git a/compiler/optimizing/register_allocator.h b/compiler/optimizing/register_allocator.h index 4d226875bf..453e339cba 100644 --- a/compiler/optimizing/register_allocator.h +++ b/compiler/optimizing/register_allocator.h @@ -22,7 +22,7 @@ #include "base/arena_object.h" #include "base/macros.h" -namespace art { +namespace art HIDDEN { class CodeGenerator; class HBasicBlock; diff --git a/compiler/optimizing/register_allocator_graph_color.cc b/compiler/optimizing/register_allocator_graph_color.cc index 684aaf5750..a7c891d4e7 100644 --- a/compiler/optimizing/register_allocator_graph_color.cc +++ b/compiler/optimizing/register_allocator_graph_color.cc @@ -22,7 +22,7 @@ #include "ssa_liveness_analysis.h" #include "thread-current-inl.h" -namespace art { +namespace art HIDDEN { // Highest number of registers that we support for any platform. This can be used for std::bitset, // for example, which needs to know its size at compile time. diff --git a/compiler/optimizing/register_allocator_graph_color.h b/compiler/optimizing/register_allocator_graph_color.h index e5b86eacee..0e10152049 100644 --- a/compiler/optimizing/register_allocator_graph_color.h +++ b/compiler/optimizing/register_allocator_graph_color.h @@ -24,7 +24,7 @@ #include "base/scoped_arena_containers.h" #include "register_allocator.h" -namespace art { +namespace art HIDDEN { class CodeGenerator; class HBasicBlock; diff --git a/compiler/optimizing/register_allocator_linear_scan.cc b/compiler/optimizing/register_allocator_linear_scan.cc index 833c24d5bb..fcdaa2d34f 100644 --- a/compiler/optimizing/register_allocator_linear_scan.cc +++ b/compiler/optimizing/register_allocator_linear_scan.cc @@ -26,7 +26,7 @@ #include "register_allocation_resolver.h" #include "ssa_liveness_analysis.h" -namespace art { +namespace art HIDDEN { static constexpr size_t kMaxLifetimePosition = -1; static constexpr size_t kDefaultNumberOfSpillSlots = 4; diff --git a/compiler/optimizing/register_allocator_linear_scan.h b/compiler/optimizing/register_allocator_linear_scan.h index 9a1e0d7f10..c71a9e9ff1 100644 --- a/compiler/optimizing/register_allocator_linear_scan.h +++ b/compiler/optimizing/register_allocator_linear_scan.h @@ -22,7 +22,7 @@ #include "base/scoped_arena_containers.h" #include "register_allocator.h" -namespace art { +namespace art HIDDEN { class CodeGenerator; class HBasicBlock; diff --git a/compiler/optimizing/register_allocator_test.cc b/compiler/optimizing/register_allocator_test.cc index 682315545d..dabd4a3ca1 100644 --- a/compiler/optimizing/register_allocator_test.cc +++ b/compiler/optimizing/register_allocator_test.cc @@ -18,6 +18,7 @@ #include "arch/x86/instruction_set_features_x86.h" #include "base/arena_allocator.h" +#include "base/macros.h" #include "builder.h" #include "code_generator.h" #include "code_generator_x86.h" @@ -31,7 +32,7 @@ #include "ssa_liveness_analysis.h" #include "ssa_phi_elimination.h" -namespace art { +namespace art HIDDEN { using Strategy = RegisterAllocator::Strategy; diff --git a/compiler/optimizing/scheduler.cc b/compiler/optimizing/scheduler.cc index d6568980c8..116f52605e 100644 --- a/compiler/optimizing/scheduler.cc +++ b/compiler/optimizing/scheduler.cc @@ -32,7 +32,7 @@ #include "scheduler_arm.h" #endif -namespace art { +namespace art HIDDEN { void SchedulingGraph::AddDependency(SchedulingNode* node, SchedulingNode* dependency, diff --git a/compiler/optimizing/scheduler.h b/compiler/optimizing/scheduler.h index f7180a02d7..299fbc93f3 100644 --- a/compiler/optimizing/scheduler.h +++ b/compiler/optimizing/scheduler.h @@ -19,6 +19,7 @@ #include <fstream> +#include "base/macros.h" #include "base/scoped_arena_allocator.h" #include "base/scoped_arena_containers.h" #include "base/stl_util.h" @@ -28,7 +29,7 @@ #include "nodes.h" #include "optimization.h" -namespace art { +namespace art HIDDEN { // General description of instruction scheduling. // diff --git a/compiler/optimizing/scheduler_arm.cc b/compiler/optimizing/scheduler_arm.cc index 25dd1047e5..3f931c4c49 100644 --- a/compiler/optimizing/scheduler_arm.cc +++ b/compiler/optimizing/scheduler_arm.cc @@ -23,7 +23,7 @@ #include "mirror/array-inl.h" #include "mirror/string.h" -namespace art { +namespace art HIDDEN { namespace arm { using helpers::Int32ConstantFrom; diff --git a/compiler/optimizing/scheduler_arm.h b/compiler/optimizing/scheduler_arm.h index 6aeea6dde1..73103df971 100644 --- a/compiler/optimizing/scheduler_arm.h +++ b/compiler/optimizing/scheduler_arm.h @@ -17,10 +17,11 @@ #ifndef ART_COMPILER_OPTIMIZING_SCHEDULER_ARM_H_ #define ART_COMPILER_OPTIMIZING_SCHEDULER_ARM_H_ +#include "base/macros.h" #include "code_generator_arm_vixl.h" #include "scheduler.h" -namespace art { +namespace art HIDDEN { namespace arm { // AArch32 instruction latencies. // We currently assume that all ARM CPUs share the same instruction latency list. diff --git a/compiler/optimizing/scheduler_arm64.cc b/compiler/optimizing/scheduler_arm64.cc index 4f504c2100..3071afd951 100644 --- a/compiler/optimizing/scheduler_arm64.cc +++ b/compiler/optimizing/scheduler_arm64.cc @@ -20,7 +20,7 @@ #include "mirror/array-inl.h" #include "mirror/string.h" -namespace art { +namespace art HIDDEN { namespace arm64 { void SchedulingLatencyVisitorARM64::VisitBinaryOperation(HBinaryOperation* instr) { diff --git a/compiler/optimizing/scheduler_arm64.h b/compiler/optimizing/scheduler_arm64.h index ba5a743545..420f5583ec 100644 --- a/compiler/optimizing/scheduler_arm64.h +++ b/compiler/optimizing/scheduler_arm64.h @@ -17,9 +17,10 @@ #ifndef ART_COMPILER_OPTIMIZING_SCHEDULER_ARM64_H_ #define ART_COMPILER_OPTIMIZING_SCHEDULER_ARM64_H_ +#include "base/macros.h" #include "scheduler.h" -namespace art { +namespace art HIDDEN { namespace arm64 { static constexpr uint32_t kArm64MemoryLoadLatency = 5; diff --git a/compiler/optimizing/scheduler_test.cc b/compiler/optimizing/scheduler_test.cc index a1cc202a89..6eea87f8a2 100644 --- a/compiler/optimizing/scheduler_test.cc +++ b/compiler/optimizing/scheduler_test.cc @@ -17,6 +17,7 @@ #include "scheduler.h" #include "base/arena_allocator.h" +#include "base/macros.h" #include "builder.h" #include "codegen_test_utils.h" #include "common_compiler_test.h" @@ -34,7 +35,7 @@ #include "scheduler_arm.h" #endif -namespace art { +namespace art HIDDEN { // Return all combinations of ISA and code generator that are executable on // hardware, or on simulator, and that we'd like to test. diff --git a/compiler/optimizing/select_generator.cc b/compiler/optimizing/select_generator.cc index 63460dbb17..761e7b562e 100644 --- a/compiler/optimizing/select_generator.cc +++ b/compiler/optimizing/select_generator.cc @@ -19,7 +19,7 @@ #include "optimizing/nodes.h" #include "reference_type_propagation.h" -namespace art { +namespace art HIDDEN { static constexpr size_t kMaxInstructionsInBranch = 1u; diff --git a/compiler/optimizing/select_generator.h b/compiler/optimizing/select_generator.h index 4f13917ba3..7aa0803d89 100644 --- a/compiler/optimizing/select_generator.h +++ b/compiler/optimizing/select_generator.h @@ -57,11 +57,12 @@ #ifndef ART_COMPILER_OPTIMIZING_SELECT_GENERATOR_H_ #define ART_COMPILER_OPTIMIZING_SELECT_GENERATOR_H_ +#include "base/macros.h" #include "base/scoped_arena_containers.h" #include "optimization.h" #include "optimizing/nodes.h" -namespace art { +namespace art HIDDEN { class HSelectGenerator : public HOptimization { public: diff --git a/compiler/optimizing/select_generator_test.cc b/compiler/optimizing/select_generator_test.cc index b18d41abbb..fc9e150d92 100644 --- a/compiler/optimizing/select_generator_test.cc +++ b/compiler/optimizing/select_generator_test.cc @@ -17,12 +17,13 @@ #include "select_generator.h" #include "base/arena_allocator.h" +#include "base/macros.h" #include "builder.h" #include "nodes.h" #include "optimizing_unit_test.h" #include "side_effects_analysis.h" -namespace art { +namespace art HIDDEN { class SelectGeneratorTest : public OptimizingUnitTest { protected: diff --git a/compiler/optimizing/sharpening.cc b/compiler/optimizing/sharpening.cc index 17cf3d3477..1985b8c792 100644 --- a/compiler/optimizing/sharpening.cc +++ b/compiler/optimizing/sharpening.cc @@ -34,7 +34,7 @@ #include "runtime.h" #include "scoped_thread_state_change-inl.h" -namespace art { +namespace art HIDDEN { static bool IsInBootImage(ArtMethod* method) { gc::Heap* heap = Runtime::Current()->GetHeap(); diff --git a/compiler/optimizing/sharpening.h b/compiler/optimizing/sharpening.h index 975366918c..6dfe904f27 100644 --- a/compiler/optimizing/sharpening.h +++ b/compiler/optimizing/sharpening.h @@ -17,10 +17,11 @@ #ifndef ART_COMPILER_OPTIMIZING_SHARPENING_H_ #define ART_COMPILER_OPTIMIZING_SHARPENING_H_ +#include "base/macros.h" #include "nodes.h" #include "optimization.h" -namespace art { +namespace art HIDDEN { class CodeGenerator; class DexCompilationUnit; diff --git a/compiler/optimizing/side_effects_analysis.cc b/compiler/optimizing/side_effects_analysis.cc index ba97b43de9..56719b100e 100644 --- a/compiler/optimizing/side_effects_analysis.cc +++ b/compiler/optimizing/side_effects_analysis.cc @@ -16,7 +16,7 @@ #include "side_effects_analysis.h" -namespace art { +namespace art HIDDEN { bool SideEffectsAnalysis::Run() { // Inlining might have created more blocks, so we need to increase the size diff --git a/compiler/optimizing/side_effects_analysis.h b/compiler/optimizing/side_effects_analysis.h index 56a01e63f1..47fcdc5d1b 100644 --- a/compiler/optimizing/side_effects_analysis.h +++ b/compiler/optimizing/side_effects_analysis.h @@ -18,10 +18,11 @@ #define ART_COMPILER_OPTIMIZING_SIDE_EFFECTS_ANALYSIS_H_ #include "base/arena_containers.h" +#include "base/macros.h" #include "nodes.h" #include "optimization.h" -namespace art { +namespace art HIDDEN { class SideEffectsAnalysis : public HOptimization { public: diff --git a/compiler/optimizing/side_effects_test.cc b/compiler/optimizing/side_effects_test.cc index 268798ca7d..f2b781dfa4 100644 --- a/compiler/optimizing/side_effects_test.cc +++ b/compiler/optimizing/side_effects_test.cc @@ -16,10 +16,11 @@ #include <gtest/gtest.h> +#include "base/macros.h" #include "data_type.h" #include "nodes.h" -namespace art { +namespace art HIDDEN { // Only runtime types other than void are allowed. static const DataType::Type kTestTypes[] = { diff --git a/compiler/optimizing/ssa_builder.cc b/compiler/optimizing/ssa_builder.cc index a36b74bba9..a658252e69 100644 --- a/compiler/optimizing/ssa_builder.cc +++ b/compiler/optimizing/ssa_builder.cc @@ -27,7 +27,7 @@ #include "scoped_thread_state_change-inl.h" #include "ssa_phi_elimination.h" -namespace art { +namespace art HIDDEN { void SsaBuilder::FixNullConstantType() { // The order doesn't matter here. diff --git a/compiler/optimizing/ssa_builder.h b/compiler/optimizing/ssa_builder.h index a7d4e0ebd3..99a5469932 100644 --- a/compiler/optimizing/ssa_builder.h +++ b/compiler/optimizing/ssa_builder.h @@ -17,12 +17,13 @@ #ifndef ART_COMPILER_OPTIMIZING_SSA_BUILDER_H_ #define ART_COMPILER_OPTIMIZING_SSA_BUILDER_H_ +#include "base/macros.h" #include "base/scoped_arena_allocator.h" #include "base/scoped_arena_containers.h" #include "nodes.h" #include "optimization.h" -namespace art { +namespace art HIDDEN { /** * Transforms a graph into SSA form. The liveness guarantees of diff --git a/compiler/optimizing/ssa_liveness_analysis.cc b/compiler/optimizing/ssa_liveness_analysis.cc index 18942a1823..317e0999d7 100644 --- a/compiler/optimizing/ssa_liveness_analysis.cc +++ b/compiler/optimizing/ssa_liveness_analysis.cc @@ -21,7 +21,7 @@ #include "linear_order.h" #include "nodes.h" -namespace art { +namespace art HIDDEN { void SsaLivenessAnalysis::Analyze() { // Compute the linear order directly in the graph's data structure diff --git a/compiler/optimizing/ssa_liveness_analysis.h b/compiler/optimizing/ssa_liveness_analysis.h index 7f31585f34..cc2b49cf22 100644 --- a/compiler/optimizing/ssa_liveness_analysis.h +++ b/compiler/optimizing/ssa_liveness_analysis.h @@ -21,11 +21,12 @@ #include "base/intrusive_forward_list.h" #include "base/iteration_range.h" +#include "base/macros.h" #include "base/scoped_arena_allocator.h" #include "base/scoped_arena_containers.h" #include "nodes.h" -namespace art { +namespace art HIDDEN { class CodeGenerator; class SsaLivenessAnalysis; diff --git a/compiler/optimizing/ssa_liveness_analysis_test.cc b/compiler/optimizing/ssa_liveness_analysis_test.cc index a477893d57..2df0f34c7d 100644 --- a/compiler/optimizing/ssa_liveness_analysis_test.cc +++ b/compiler/optimizing/ssa_liveness_analysis_test.cc @@ -20,12 +20,13 @@ #include "arch/instruction_set_features.h" #include "base/arena_allocator.h" #include "base/arena_containers.h" +#include "base/macros.h" #include "code_generator.h" #include "driver/compiler_options.h" #include "nodes.h" #include "optimizing_unit_test.h" -namespace art { +namespace art HIDDEN { class SsaLivenessAnalysisTest : public OptimizingUnitTest { protected: diff --git a/compiler/optimizing/ssa_phi_elimination.cc b/compiler/optimizing/ssa_phi_elimination.cc index 8fd6962500..ce343dffec 100644 --- a/compiler/optimizing/ssa_phi_elimination.cc +++ b/compiler/optimizing/ssa_phi_elimination.cc @@ -21,7 +21,7 @@ #include "base/scoped_arena_containers.h" #include "base/bit_vector-inl.h" -namespace art { +namespace art HIDDEN { bool SsaDeadPhiElimination::Run() { MarkDeadPhis(); diff --git a/compiler/optimizing/ssa_phi_elimination.h b/compiler/optimizing/ssa_phi_elimination.h index c5cc752ffc..f606f928fa 100644 --- a/compiler/optimizing/ssa_phi_elimination.h +++ b/compiler/optimizing/ssa_phi_elimination.h @@ -17,10 +17,11 @@ #ifndef ART_COMPILER_OPTIMIZING_SSA_PHI_ELIMINATION_H_ #define ART_COMPILER_OPTIMIZING_SSA_PHI_ELIMINATION_H_ +#include "base/macros.h" #include "nodes.h" #include "optimization.h" -namespace art { +namespace art HIDDEN { /** * Optimization phase that removes dead phis from the graph. Dead phis are unused diff --git a/compiler/optimizing/ssa_test.cc b/compiler/optimizing/ssa_test.cc index e679893af2..008e435a77 100644 --- a/compiler/optimizing/ssa_test.cc +++ b/compiler/optimizing/ssa_test.cc @@ -17,6 +17,7 @@ #include "android-base/stringprintf.h" #include "base/arena_allocator.h" +#include "base/macros.h" #include "builder.h" #include "dex/dex_file.h" #include "dex/dex_instruction.h" @@ -27,7 +28,7 @@ #include "gtest/gtest.h" -namespace art { +namespace art HIDDEN { class SsaTest : public OptimizingUnitTest { protected: diff --git a/compiler/optimizing/stack_map_stream.cc b/compiler/optimizing/stack_map_stream.cc index 31428d5c2a..1a368ed347 100644 --- a/compiler/optimizing/stack_map_stream.cc +++ b/compiler/optimizing/stack_map_stream.cc @@ -33,7 +33,7 @@ #include "scoped_thread_state_change-inl.h" #include "stack_map.h" -namespace art { +namespace art HIDDEN { constexpr static bool kVerifyStackMaps = kIsDebugBuild; diff --git a/compiler/optimizing/stack_map_stream.h b/compiler/optimizing/stack_map_stream.h index 2ba60279ff..643af2da94 100644 --- a/compiler/optimizing/stack_map_stream.h +++ b/compiler/optimizing/stack_map_stream.h @@ -21,6 +21,7 @@ #include "base/arena_bit_vector.h" #include "base/bit_table.h" #include "base/bit_vector-inl.h" +#include "base/macros.h" #include "base/memory_region.h" #include "base/scoped_arena_containers.h" #include "base/value_object.h" @@ -28,7 +29,7 @@ #include "nodes.h" #include "stack_map.h" -namespace art { +namespace art HIDDEN { class CodeGenerator; diff --git a/compiler/optimizing/stack_map_test.cc b/compiler/optimizing/stack_map_test.cc index 23af1f7fa1..a2c30e7681 100644 --- a/compiler/optimizing/stack_map_test.cc +++ b/compiler/optimizing/stack_map_test.cc @@ -18,12 +18,13 @@ #include "art_method.h" #include "base/arena_bit_vector.h" +#include "base/macros.h" #include "base/malloc_arena_pool.h" #include "stack_map_stream.h" #include "gtest/gtest.h" -namespace art { +namespace art HIDDEN { // Check that the stack mask of given stack map is identical // to the given bit vector. Returns true if they are same. diff --git a/compiler/optimizing/superblock_cloner.cc b/compiler/optimizing/superblock_cloner.cc index a5f919c31c..ba56eb83b3 100644 --- a/compiler/optimizing/superblock_cloner.cc +++ b/compiler/optimizing/superblock_cloner.cc @@ -22,7 +22,7 @@ #include <sstream> -namespace art { +namespace art HIDDEN { using HBasicBlockMap = SuperblockCloner::HBasicBlockMap; using HInstructionMap = SuperblockCloner::HInstructionMap; diff --git a/compiler/optimizing/superblock_cloner.h b/compiler/optimizing/superblock_cloner.h index 1f6ee74fbd..421701fb19 100644 --- a/compiler/optimizing/superblock_cloner.h +++ b/compiler/optimizing/superblock_cloner.h @@ -20,9 +20,10 @@ #include "base/arena_bit_vector.h" #include "base/arena_containers.h" #include "base/bit_vector-inl.h" +#include "base/macros.h" #include "nodes.h" -namespace art { +namespace art HIDDEN { class InductionVarRange; diff --git a/compiler/optimizing/superblock_cloner_test.cc b/compiler/optimizing/superblock_cloner_test.cc index d8d68b7763..ea2563ea7d 100644 --- a/compiler/optimizing/superblock_cloner_test.cc +++ b/compiler/optimizing/superblock_cloner_test.cc @@ -14,6 +14,7 @@ * limitations under the License. */ +#include "base/macros.h" #include "graph_checker.h" #include "nodes.h" #include "optimizing_unit_test.h" @@ -21,7 +22,7 @@ #include "gtest/gtest.h" -namespace art { +namespace art HIDDEN { using HBasicBlockMap = SuperblockCloner::HBasicBlockMap; using HInstructionMap = SuperblockCloner::HInstructionMap; diff --git a/compiler/optimizing/suspend_check_test.cc b/compiler/optimizing/suspend_check_test.cc index 33823e2a11..93a84b4e0a 100644 --- a/compiler/optimizing/suspend_check_test.cc +++ b/compiler/optimizing/suspend_check_test.cc @@ -14,6 +14,7 @@ * limitations under the License. */ +#include "base/macros.h" #include "builder.h" #include "dex/dex_instruction.h" #include "nodes.h" @@ -22,7 +23,7 @@ #include "gtest/gtest.h" -namespace art { +namespace art HIDDEN { /** * Check that the HGraphBuilder adds suspend checks to backward branches. diff --git a/compiler/optimizing/x86_memory_gen.cc b/compiler/optimizing/x86_memory_gen.cc index b1abcf6747..82652142a7 100644 --- a/compiler/optimizing/x86_memory_gen.cc +++ b/compiler/optimizing/x86_memory_gen.cc @@ -18,7 +18,7 @@ #include "code_generator.h" #include "driver/compiler_options.h" -namespace art { +namespace art HIDDEN { namespace x86 { /** diff --git a/compiler/optimizing/x86_memory_gen.h b/compiler/optimizing/x86_memory_gen.h index 3f4178d58a..1cae1a5d3a 100644 --- a/compiler/optimizing/x86_memory_gen.h +++ b/compiler/optimizing/x86_memory_gen.h @@ -17,10 +17,11 @@ #ifndef ART_COMPILER_OPTIMIZING_X86_MEMORY_GEN_H_ #define ART_COMPILER_OPTIMIZING_X86_MEMORY_GEN_H_ +#include "base/macros.h" #include "nodes.h" #include "optimization.h" -namespace art { +namespace art HIDDEN { class CodeGenerator; namespace x86 { |