diff options
| author | 2016-09-13 10:47:28 -0700 | |
|---|---|---|
| committer | 2016-09-26 10:59:22 -0700 | |
| commit | 3fec9ac0d5af1358d216eb2fdc2000ec0205f3f0 (patch) | |
| tree | f38d8d8aae51f53e7ee6b474f47597b784fc2316 /compiler | |
| parent | 0cfe19af3b7395658210ea6044a65c9811962a7a (diff) | |
ART: Use libbase logging
Move most of our logging infrastructure over to system/core/base.
Retain VLOG.
Using unified Android infrastructure has two main advantages. First,
it reduces the complexity/maintenance burden in ART. Second, it
allows to detach logging for the cases where we do not want or need
a runtime, e.g., dexdump, the disassembler, etc. As a part of the
latter, libbase is also supported for all hosts (including Windows).
From a developer viewpoint, there are minor behavior changes for the
LOG statements (see above), but otherwise usage is the same. Explicit
severity enum items are in the android::base namespace now.
Bug: 31338270
Test: m test-art-host
Change-Id: I5abcb2f45f5b03d49951874c48544f72a283a91b
Diffstat (limited to 'compiler')
| -rw-r--r-- | compiler/Android.bp | 1 | ||||
| -rw-r--r-- | compiler/oat_writer.cc | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/compiler/Android.bp b/compiler/Android.bp index 09c53b6889..e56d8b2e0a 100644 --- a/compiler/Android.bp +++ b/compiler/Android.bp @@ -288,6 +288,7 @@ art_cc_library { shared_libs: [ "libartd-compiler", "libart-runtime-gtest", + "libbase", ], } diff --git a/compiler/oat_writer.cc b/compiler/oat_writer.cc index 9045817832..c840a9e64a 100644 --- a/compiler/oat_writer.cc +++ b/compiler/oat_writer.cc @@ -966,7 +966,7 @@ class OatWriter::InitImageMethodVisitor : public OatDexMethodVisitor { nullptr, invoke_type); if (method == nullptr) { - LOG(INTERNAL_FATAL) << "Unexpected failure to resolve a method: " + LOG(FATAL_WITHOUT_ABORT) << "Unexpected failure to resolve a method: " << PrettyMethod(it.GetMemberIndex(), *dex_file_, true); soa.Self()->AssertPendingException(); mirror::Throwable* exc = soa.Self()->GetException(); |