diff options
| author | 2016-04-24 05:17:17 +0000 | |
|---|---|---|
| committer | 2016-04-24 05:17:17 +0000 | |
| commit | d89e2418f2c6d9897fee219f8df9c20ca93c80db (patch) | |
| tree | 86cc7ff6e15d316be62f9621d4f34e1ebc1eb07f /compiler/utils/arm/assembler_thumb2.cc | |
| parent | 1f2ce44db2613a1e60a66c3c454834b72e994f57 (diff) | |
Revert "Thumb2: Reduce memory used for fixup dependencies."
Bug: 28343425
This reverts commit 1f2ce44db2613a1e60a66c3c454834b72e994f57.
Change-Id: I39edb37fb6fa4e84ac3fd0e11650fbb92d05ffcb
Diffstat (limited to 'compiler/utils/arm/assembler_thumb2.cc')
| -rw-r--r-- | compiler/utils/arm/assembler_thumb2.cc | 17 | 
1 files changed, 0 insertions, 17 deletions
diff --git a/compiler/utils/arm/assembler_thumb2.cc b/compiler/utils/arm/assembler_thumb2.cc index 3a4c23d059..2c73fb8095 100644 --- a/compiler/utils/arm/assembler_thumb2.cc +++ b/compiler/utils/arm/assembler_thumb2.cc @@ -37,9 +37,6 @@ void Thumb2Assembler::Fixup::PrepareDependents(Thumb2Assembler* assembler) {    const FixupId end_id = assembler->fixups_.size();    Fixup* fixups = assembler->fixups_.data();    for (FixupId fixup_id = 0u; fixup_id != end_id; ++fixup_id) { -    if (!fixups[fixup_id].CanExpand()) { -      continue; -    }      uint32_t target = fixups[fixup_id].target_;      if (target > fixups[fixup_id].location_) {        for (FixupId id = fixup_id + 1u; id != end_id && fixups[id].location_ < target; ++id) { @@ -65,9 +62,6 @@ void Thumb2Assembler::Fixup::PrepareDependents(Thumb2Assembler* assembler) {    assembler->fixup_dependents_.resize(number_of_dependents);    FixupId* dependents = assembler->fixup_dependents_.data();    for (FixupId fixup_id = 0u; fixup_id != end_id; ++fixup_id) { -    if (!fixups[fixup_id].CanExpand()) { -      continue; -    }      uint32_t target = fixups[fixup_id].target_;      if (target > fixups[fixup_id].location_) {        for (FixupId id = fixup_id + 1u; id != end_id && fixups[id].location_ < target; ++id) { @@ -121,7 +115,6 @@ void Thumb2Assembler::AdjustFixupIfNeeded(Fixup* fixup, uint32_t* current_code_s                                            std::deque<FixupId>* fixups_to_recalculate) {    uint32_t adjustment = fixup->AdjustSizeIfNeeded(*current_code_size);    if (adjustment != 0u) { -    DCHECK(fixup->CanExpand());      *current_code_size += adjustment;      for (FixupId dependent_id : fixup->Dependents(*this)) {        Fixup* dependent = GetFixup(dependent_id); @@ -2553,19 +2546,9 @@ void Thumb2Assembler::EmitBranch(Condition cond, Label* label, bool link, bool x        }      } else {        branch_type = Fixup::kUnconditional;             // B. -      // The T2 encoding offset is `SignExtend(imm11:'0', 32)` and there is a PC adjustment of 4. -      static constexpr size_t kMaxT2BackwardDistance = (1u << 11) - 4u; -      if (!use32bit && label->IsBound() && pc - label->Position() > kMaxT2BackwardDistance) { -        use32bit = true; -      }      }    } else {      branch_type = Fixup::kConditional;                 // B<cond>. -    // The T1 encoding offset is `SignExtend(imm8:'0', 32)` and there is a PC adjustment of 4. -    static constexpr size_t kMaxT1BackwardDistance = (1u << 8) - 4u; -    if (!use32bit && label->IsBound() && pc - label->Position() > kMaxT1BackwardDistance) { -      use32bit = true; -    }    }    Fixup::Size size = use32bit ? Fixup::kBranch32Bit : Fixup::kBranch16Bit;  |